Re: [Freedreno] [PATCH v3 0/7] drm/msm: add support for SM8550

2023-03-30 Thread Neil Armstrong
On 29/03/2023 22:13, Dmitry Baryshkov wrote: On 29/03/2023 22:52, Rob Herring wrote: On Tue, Mar 28, 2023 at 5:38 PM Dmitry Baryshkov wrote: On Mon, 09 Jan 2023 11:15:17 +0100, Neil Armstrong wrote: This adds support for the MDSS/DPU/DSI on the Qualcomm SM8550 platform. This patchset is ba

[Freedreno] [PATCH 1/6] drm/msm: Clear aperture ownership outside of fbdev code

2023-03-30 Thread Thomas Zimmermann
Move aperture management out of the fbdev code. It is unrelated and needs to run even if fbdev support has been disabled. Call the helper at the top of msm_drm_init() to take over hardware from other drivers. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_drv.c | 6 ++ driver

[Freedreno] [PATCH 3/6] drm/msm: Remove struct msm_fbdev

2023-03-30 Thread Thomas Zimmermann
Remove struct msm_fbdev, which is an empty wrapper around struct drm_fb_helper. Use the latter directly. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_fbdev.c | 19 +++ 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/drivers/gp

[Freedreno] [PATCH 2/6] drm/msm: Remove fb from struct msm_fbdev

2023-03-30 Thread Thomas Zimmermann
Fbdev's struct fb_helper stores a pointer to the framebuffer. Remove struct msm_fbdev.fb, which contains thre same value. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_fbdev.c | 32 +--- 1 file changed, 13 insertions(+), 19 deleti

[Freedreno] [PATCH 4/6] drm/msm: Remove fbdev from struct msm_drm_private

2023-03-30 Thread Thomas Zimmermann
The DRM device stores a pointer to the fbdev helper. Remove struct msm_drm_private.fbdev, which contains the same value. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_debugfs.c | 5 ++--- drivers/gpu/drm/msm/msm_drv.c | 4 ++-- drivers/gpu/drm/msm/msm_dr

[Freedreno] [PATCH 0/6] drm/msm: Convert fbdev to DRM client

2023-03-30 Thread Thomas Zimmermann
Convert msm' fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. As with most other drivers' fbdev emulation, fbdev in msm is now just another DRM client that runs after the DRM device has been registered. Once all drivers' fbdev

[Freedreno] [PATCH 6/6] drm/msm: Implement fbdev emulation as in-kernel client

2023-03-30 Thread Thomas Zimmermann
Move code from ad-hoc fbdev callbacks into DRM client functions and remove the old callbacks. The functions instruct the client to poll for changed output or restore the display. The DRM core calls both, the old callbacks and the new client helpers, from the same places. The new functions perform t

[Freedreno] [PATCH 5/6] drm/msm: Initialize fbdev DRM client

2023-03-30 Thread Thomas Zimmermann
Initialize the fbdev client in the fbdev code with empty helper functions. Also clean up the client. The helpers will later implement various functionality of the DRM client. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_fbdev.c | 38

Re: [Freedreno] [PATCH 0/6] drm/msm: Convert fbdev to DRM client

2023-03-30 Thread Dmitry Baryshkov
On Thu, 30 Mar 2023 at 10:41, Thomas Zimmermann wrote: > > Convert msm' fbdev code to struct drm_client. Replaces the current > ad-hoc integration. The conversion includes a number of cleanups. As > with most other drivers' fbdev emulation, fbdev in msm is now just > another DRM client that runs a

Re: [Freedreno] [PATCH 1/6] drm/msm: Clear aperture ownership outside of fbdev code

2023-03-30 Thread Dmitry Baryshkov
On Thu, 30 Mar 2023 at 10:41, Thomas Zimmermann wrote: > > Move aperture management out of the fbdev code. It is unrelated > and needs to run even if fbdev support has been disabled. Call > the helper at the top of msm_drm_init() to take over hardware > from other drivers. > > Signed-off-by: Thoma

Re: [Freedreno] [PATCH 2/6] drm/msm: Remove fb from struct msm_fbdev

2023-03-30 Thread Dmitry Baryshkov
On Thu, 30 Mar 2023 at 10:41, Thomas Zimmermann wrote: > > Fbdev's struct fb_helper stores a pointer to the framebuffer. Remove > struct msm_fbdev.fb, which contains thre same value. No functional > changes. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/msm/msm_fbdev.c | 32 ++

Re: [Freedreno] [PATCH 3/6] drm/msm: Remove struct msm_fbdev

2023-03-30 Thread Dmitry Baryshkov
On Thu, 30 Mar 2023 at 10:41, Thomas Zimmermann wrote: > > Remove struct msm_fbdev, which is an empty wrapper around struct > drm_fb_helper. Use the latter directly. No functional changes. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/msm/msm_fbdev.c | 19 +++ > 1

Re: [Freedreno] [PATCH 4/6] drm/msm: Remove fbdev from struct msm_drm_private

2023-03-30 Thread Dmitry Baryshkov
On Thu, 30 Mar 2023 at 10:41, Thomas Zimmermann wrote: > > The DRM device stores a pointer to the fbdev helper. Remove struct > msm_drm_private.fbdev, which contains the same value. No functional > changes. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/msm/msm_debugfs.c | 5 ++---

Re: [Freedreno] [PATCH 5/6] drm/msm: Initialize fbdev DRM client

2023-03-30 Thread Dmitry Baryshkov
On Thu, 30 Mar 2023 at 10:41, Thomas Zimmermann wrote: > > Initialize the fbdev client in the fbdev code with empty helper > functions. Also clean up the client. The helpers will later > implement various functionality of the DRM client. No functional > changes. > > Signed-off-by: Thomas Zimmerman

Re: [Freedreno] [PATCH 6/6] drm/msm: Implement fbdev emulation as in-kernel client

2023-03-30 Thread kernel test robot
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.3-rc4] [cannot apply to next-20230330] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [Freedreno] [PATCH 6/6] drm/msm: Implement fbdev emulation as in-kernel client

2023-03-30 Thread kernel test robot
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.3-rc4] [cannot apply to next-20230330] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [Freedreno] [RFC PATCH 0/3] drm/msm/a5xx: scale MX following the frequency changes

2023-03-30 Thread Konrad Dybcio
On 30.03.2023 00:24, Dmitry Baryshkov wrote: > Konrad brought up the topic of scaling the MX domain according to the > OPP changes. Here is my RFC for this functionality. I post it as an RFC > for two reasons: > > 1) I'm not sure that we should scale MX if we are not scaling main > voltage foll

Re: [Freedreno] [RFC PATCH 0/3] drm/msm/a5xx: scale MX following the frequency changes

2023-03-30 Thread Dmitry Baryshkov
On 30/03/2023 14:06, Konrad Dybcio wrote: On 30.03.2023 00:24, Dmitry Baryshkov wrote: Konrad brought up the topic of scaling the MX domain according to the OPP changes. Here is my RFC for this functionality. I post it as an RFC for two reasons: 1) I'm not sure that we should scale MX if we a

Re: [Freedreno] [RFC PATCH 0/3] drm/msm/a5xx: scale MX following the frequency changes

2023-03-30 Thread Konrad Dybcio
On 30.03.2023 13:15, Dmitry Baryshkov wrote: > On 30/03/2023 14:06, Konrad Dybcio wrote: >> >> >> On 30.03.2023 00:24, Dmitry Baryshkov wrote: >>> Konrad brought up the topic of scaling the MX domain according to the >>> OPP changes. Here is my RFC for this functionality. I post it as an RFC >>>

Re: [Freedreno] [RFC PATCH 0/3] drm/msm/a5xx: scale MX following the frequency changes

2023-03-30 Thread Dmitry Baryshkov
On Thu, 30 Mar 2023 at 14:16, Konrad Dybcio wrote: > > > > On 30.03.2023 13:15, Dmitry Baryshkov wrote: > > On 30/03/2023 14:06, Konrad Dybcio wrote: > >> > >> > >> On 30.03.2023 00:24, Dmitry Baryshkov wrote: > >>> Konrad brought up the topic of scaling the MX domain according to the > >>> OPP ch

Re: [Freedreno] [v2, 19/50] drm/msm/dpu: split SM8450 catalog entry to the separate file

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_8_1_sm8450.h| 203 + > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 204 +- > 2 files changed, 205 insertions(+), 202 deletions(-) > crea

Re: [Freedreno] [v2, 20/50] drm/msm/dpu: split SC8280XP catalog entry to the separate file

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h | 196 ++ > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 189 + > 2 files changed, 197 insertions(+), 188 deletions(-) > crea

Re: [Freedreno] [v2, 21/50] drm/msm/dpu: split SC7280 catalog entry to the separate file

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_7_2_sc7280.h| 149 ++ > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 145 + > 2 files changed, 151 insertions(+), 143 deletions(-) > crea

Re: [Freedreno] [v2, 22/50] drm/msm/dpu: split SM8350 catalog entry to the separate file

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_7_0_sm8350.h| 175 ++ > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 175 +- > 2 files changed, 176 insertions(+), 174 deletions(-) > cre

Re: [Freedreno] [v2, 23/50] drm/msm/dpu: split SM6115 catalog entry to the separate file

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_6_3_sm6115.h| 96 +++ > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 90 + > 2 files changed, 98 insertions(+), 88 deletions(-) > create

Re: [Freedreno] [v2, 24/50] drm/msm/dpu: split QCM2290 catalog entry to the separate file

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_6_5_qcm2290.h | 116 ++ > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 108 +--- > 2 files changed, 117 insertions(+), 107 deletions(-) > creat

Re: [Freedreno] [v2, 24/50] drm/msm/dpu: split QCM2290 catalog entry to the separate file

2023-03-30 Thread Dmitry Baryshkov
On 30/03/2023 14:50, Konrad Dybcio wrote: On 12.02.2023 00:12, Dmitry Baryshkov wrote: Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_6_5_qcm2290.h | 116 ++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 108 +--- 2 files changed, 117 ins

Re: [Freedreno] [v2, 24/50] drm/msm/dpu: split QCM2290 catalog entry to the separate file

2023-03-30 Thread Konrad Dybcio
On 30.03.2023 13:52, Dmitry Baryshkov wrote: > On 30/03/2023 14:50, Konrad Dybcio wrote: >> >> >> On 12.02.2023 00:12, Dmitry Baryshkov wrote: >>> Signed-off-by: Dmitry Baryshkov >>> --- >>>   .../msm/disp/dpu1/catalog/dpu_6_5_qcm2290.h   | 116 ++ >>>   .../gpu/drm/msm/disp/dpu1

Re: [Freedreno] [v2, 25/50] drm/msm/dpu: split SC7180 catalog entry to the separate file

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_6_2_sc7180.h| 148 ++ > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 144 + > 2 files changed, 149 insertions(+), 143 deletions(-) > crea

Re: [Freedreno] [v2, 26/50] drm/msm/dpu: split SM8250 catalog entry to the separate file

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_6_0_sm8250.h| 131 + > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 132 +- > 2 files changed, 132 insertions(+), 131 deletions(-) > crea

Re: [Freedreno] [v2, 27/50] drm/msm/dpu: split SC8180X catalog entry to the separate file

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h | 108 ++ > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 106 + > 2 files changed, 109 insertions(+), 105 deletions(-) > crea

Re: [Freedreno] [v2, 28/50] drm/msm/dpu: split SM8150 catalog entry to the separate file

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_5_0_sm8150.h| 194 ++ > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 187 + > 2 files changed, 195 insertions(+), 186 deletions(-) > crea

Re: [Freedreno] [v2, 29/50] drm/msm/dpu: split MSM8998 catalog entry to the separate file

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 189 + > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 191 +- > 2 files changed, 191 insertions(+), 189 deletions(-) > crea

Re: [Freedreno] [v2, 30/50] drm/msm/dpu: split SDM845 catalog entry to the separate file

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_4_0_sdm845.h| 203 + > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 208 +- > 2 files changed, 204 insertions(+), 207 deletions(-) > crea

Re: [Freedreno] [v2, 31/50] drm/msm/dpu: duplicate sdm845 catalog entries

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Duplicate some of sdm845 catalog entries to remove dependencies between > DPU major generations. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > .../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 19 +++- > .../ms

Re: [Freedreno] [v2, 32/50] drm/msm/dpu: duplicate sc7180 catalog entries

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Duplicate some of sc7180 catalog entries to remove dependencies between > DPU major generations. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_7_2_sc7280.h | 9 +++-- > 1 file changed, 7 insertions(+),

Re: [Freedreno] [v2, 32/50] drm/msm/dpu: duplicate sc7180 catalog entries

2023-03-30 Thread Dmitry Baryshkov
On 30/03/2023 15:22, Konrad Dybcio wrote: On 12.02.2023 00:12, Dmitry Baryshkov wrote: Duplicate some of sc7180 catalog entries to remove dependencies between DPU major generations. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_7_2_sc7280.h | 9 +++-- 1

Re: [Freedreno] [v2, 33/50] drm/msm/dpu: duplicate sm8150 catalog entries

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Duplicate some of sm8150 catalog entries to remove dependencies between > DPU major generations. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > .../msm/disp/dpu1/catalog/dpu_6_0_sm8250.h| 134 -

Re: [Freedreno] [v2, 34/50] drm/msm/dpu: duplicate sm8250 catalog entries

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Duplicate some of sm8250 catalog entries to remove dependencies between > DPU major generations. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > .../msm/disp/dpu1/catalog/dpu_7_0_sm8350.h| 23 +-

Re: [Freedreno] [v2, 35/50] drm/msm/dpu: duplicate sm8350 catalog entries

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Duplicate some of sm8350 catalog entries to remove dependencies between > DPU major generations. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > .../gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h | 10 -

Re: [Freedreno] [v2, 36/50] drm/msm/dpu: use defined symbol for sc8280xp's maxwidth

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Use defined name DEFAULT_DPU_OUTPUT_LINE_WIDTH instead of open coding > the value. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h | 2 +- > 1 file changed,

Re: [Freedreno] [v2, 37/50] drm/msm/dpu: enable DPU_CTL_SPLIT_DISPLAY for sc8280xp

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Theoretically since sm8150 we should be using a single CTL for the > source split case, but since we do not support it for now, fallback to > DPU_CTL_SPLIT_DISPLAY. > > Signed-off-by: Dmitry Baryshkov > --- Hmm.. so is it a software construct? E.g

Re: [Freedreno] [v2, 38/50] drm/msm/dpu: enable DSPP_2/3 for LM_2/3 on sm8450

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Mark DSPP_2 and DSPP_3 as used for LM_2 and LM_3 > > Signed-off-by: Dmitry Baryshkov > --- Could you point me to where it's specified downstream? I can't find it. Also, deserves a Fixes. Konrad > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_1_sm

Re: [Freedreno] [v2, 39/50] drm/msm/dpu: drop duplicate vig_sblk instances

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > After fixing scaler version we are sure that sm8450 and sc8280xp vig > sblk's are duplicates of sm8250_vig_sblk and thus can be dropped. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > .../msm/disp/dpu1/catalog/dpu

Re: [Freedreno] [v2, 38/50] drm/msm/dpu: enable DSPP_2/3 for LM_2/3 on sm8450

2023-03-30 Thread Dmitry Baryshkov
On 30/03/2023 15:33, Konrad Dybcio wrote: On 12.02.2023 00:12, Dmitry Baryshkov wrote: Mark DSPP_2 and DSPP_3 as used for LM_2 and LM_3 Signed-off-by: Dmitry Baryshkov --- Could you point me to where it's specified downstream? I can't find it. https://git.codelinaro.org/clo/la/platform/ve

Re: [Freedreno] [v2,40/50] drm/msm/dpu: enable DSPP on sc8180x

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Enable DSPP blocks on sc8180x platform, basing on the vendor dtsi. > > Signed-off-by: Dmitry Baryshkov > --- There's only a single difference between 8150 and 8180: qcom,sde-dspp-dither = <0x82c 0x00010007>; is only present on the former. Not su

Re: [Freedreno] [v2, 38/50] drm/msm/dpu: enable DSPP_2/3 for LM_2/3 on sm8450

2023-03-30 Thread Konrad Dybcio
On 30.03.2023 14:38, Dmitry Baryshkov wrote: > On 30/03/2023 15:33, Konrad Dybcio wrote: >> >> >> On 12.02.2023 00:12, Dmitry Baryshkov wrote: >>> Mark DSPP_2 and DSPP_3 as used for LM_2 and LM_3 >>> >>> Signed-off-by: Dmitry Baryshkov >>> --- >> Could you point me to where it's specified downs

Re: [Freedreno] [v2, 41/50] drm/msm/dpu: deduplicate sc8180x with sm8150

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Remove duplicate between sc8180x and sm8150, which belong to the same > DPU major revision. The merged file is named using the DPU major version > and the amount of LM units. > > Signed-off-by: Dmitry Baryshkov > --- Rebase Reviewed-by: Konrad Dy

Re: [Freedreno] [v2, 42/50] drm/msm/dpu: deduplicate sm6115 with qcm2290

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Remove duplicate between sm6115 and qcm2290, which belong to the same > DPU major revision. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > .../msm/disp/dpu1/catalog/dpu_6_3_sm6115.h| 36 -- > .../msm/d

Re: [Freedreno] [v2, 43/50] drm/msm/dpu: deduplicate sc8280xp with sm8450

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Remove duplicate between sc8280xp and sm8450, which belong to the same > DPU major revision. > > Signed-off-by: Dmitry Baryshkov > --- Rebase Reviewed-by: Konrad Dybcio Konrad > .../msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h | 131 ++---

Re: [Freedreno] [v2, 44/50] drm/msm/dpu: drop unused macros from hw catalog

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Drop the version comparison macros from dpu_hw_catalog.h, they are > unused. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 16 > 1 file changed, 1

Re: [Freedreno] [v2,45/50] drm/msm/dpu: inline IRQ_n_MASK defines

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > IRQ masks are rarely shared between different DPU revisions. Inline them > to the dpu_mdss_cfg intances and drop them from the dpu_hw_catalog.c > > Signed-off-by: Dmitry Baryshkov > --- Everything looks good! Reviewed-by: Konrad Dybcio Konrad >

Re: [Freedreno] [v2, 46/50] drm/msm/dpu: rename INTF_foo_MASK to contain major DPU version

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > To ease review and reuse rename INTF feature masks to contain base DPU > version since which this mask is used. > > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h| 8 > .../drm/msm/disp/dpu1/cata

Re: [Freedreno] [v2, 47/50] drm/msm/dpu: rename CTL_foo_MASK to contain major DPU version

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > To ease review and reuse rename CTL feature masks to contain base DPU > version since which this mask is used. > > Signed-off-by: Dmitry Baryshkov > --- > .../gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 10 +- > .../gpu/drm/msm/dis

Re: [Freedreno] [v2, 47/50] drm/msm/dpu: rename CTL_foo_MASK to contain major DPU version

2023-03-30 Thread Konrad Dybcio
On 30.03.2023 15:15, Konrad Dybcio wrote: > > > On 12.02.2023 00:12, Dmitry Baryshkov wrote: >> To ease review and reuse rename CTL feature masks to contain base DPU >> version since which this mask is used. >> >> Signed-off-by: Dmitry Baryshkov >> --- >> .../gpu/drm/msm/disp/dpu1/catalog/dp

Re: [Freedreno] [v2, 48/50] drm/msm/dpu: rename VIG and DMA_foo_MASK to contain major DPU version

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > To ease review and reuse rename VIG and DMA feature masks to contain > base DPU version since which this mask is used. > > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 16 ++--- > .../msm/disp/dp

Re: [Freedreno] [v2, 49/50] drm/msm/dpu: rename MIXER_foo_MASK to contain major DPU version

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > To ease review and reuse rename MIXER feature masks to contain base DPU > version since which this mask is used. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > .../gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h

Re: [Freedreno] [v2, 46/50] drm/msm/dpu: rename INTF_foo_MASK to contain major DPU version

2023-03-30 Thread Dmitry Baryshkov
On Thu, 30 Mar 2023 at 16:14, Konrad Dybcio wrote: > > > > On 12.02.2023 00:12, Dmitry Baryshkov wrote: > > To ease review and reuse rename INTF feature masks to contain base DPU > > version since which this mask is used. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > .../msm/disp/dpu1/cata

Re: [Freedreno] [v2, 50/50] drm/msm/dpu: rename MERGE_3D_foo_MASK to contain major DPU version

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > To ease review and reuse rename MERGE_3D feature masks to contain base > DPU version since which this mask is used. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 4

Re: [Freedreno] [v2, 47/50] drm/msm/dpu: rename CTL_foo_MASK to contain major DPU version

2023-03-30 Thread Dmitry Baryshkov
On Thu, 30 Mar 2023 at 16:16, Konrad Dybcio wrote: > > > > On 30.03.2023 15:15, Konrad Dybcio wrote: > > > > > > On 12.02.2023 00:12, Dmitry Baryshkov wrote: > >> To ease review and reuse rename CTL feature masks to contain base DPU > >> version since which this mask is used. > >> > >> Signed-off-

Re: [Freedreno] [v2, 47/50] drm/msm/dpu: rename CTL_foo_MASK to contain major DPU version

2023-03-30 Thread Konrad Dybcio
On 30.03.2023 15:26, Dmitry Baryshkov wrote: > On Thu, 30 Mar 2023 at 16:16, Konrad Dybcio wrote: >> >> >> >> On 30.03.2023 15:15, Konrad Dybcio wrote: >>> >>> >>> On 12.02.2023 00:12, Dmitry Baryshkov wrote: To ease review and reuse rename CTL feature masks to contain base DPU versio

Re: [Freedreno] [PATCH v14 14/14] drm/msm/dp: set self refresh aware based on PSR support

2023-03-30 Thread Doug Anderson
Hi, On Wed, Mar 29, 2023 at 8:47 AM Doug Anderson wrote: > > Hi, > > On Wed, Mar 29, 2023 at 8:16 AM Vinod Polimera > wrote: > > > > > > > > > -Original Message- > > > From: Stephen Boyd > > > Sent: Monday, March 27, 2023 9:58 PM > > > To: Bjorn Andersson ; Vinod Polimera (QUIC) > > >

Re: [Freedreno] [PATCH] arm64: dts: qcom: sc7280: remove hbr3 support on herobrine boards

2023-03-30 Thread Doug Anderson
Hi, On Wed, Mar 29, 2023 at 4:34 PM Abhinav Kumar wrote: > > There are some interop issues seen across a few DP monitors with > HBR3 and herobrine boards where the DP display stays blank with hbr3. > This is still under investigation but in preparation for supporting > higher resolutions, its bet

Re: [Freedreno] [PATCH v14 14/14] drm/msm/dp: set self refresh aware based on PSR support

2023-03-30 Thread Vinod Polimera
> -Original Message- > From: Doug Anderson > Sent: Thursday, March 30, 2023 7:54 PM > To: Vinod Polimera > Cc: Stephen Boyd ; Bjorn Andersson > ; Vinod Polimera (QUIC) > ; robdcl...@gmail.com; dri- > de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; > freedreno@lists.freedeskt

Re: [Freedreno] [PATCH] drm/msm/adreno: adreno_gpu: Use suspend() instead of idle() on load error

2023-03-30 Thread Konrad Dybcio
On 29.03.2023 21:45, Dmitry Baryshkov wrote: > On Wed, 29 Mar 2023 at 18:48, Konrad Dybcio wrote: >> >> >> >> On 29.03.2023 16:37, Johan Hovold wrote: >>> On Wed, Mar 29, 2023 at 04:04:44PM +0200, Konrad Dybcio wrote: If we fail to initialize the GPU for whatever reason (say we don't

Re: [Freedreno] [PATCH] drm/msm/adreno: adreno_gpu: Use suspend() instead of idle() on load error

2023-03-30 Thread Johan Hovold
On Wed, Mar 29, 2023 at 10:45:52PM +0300, Dmitry Baryshkov wrote: > On Wed, 29 Mar 2023 at 18:48, Konrad Dybcio wrote: > > On 29.03.2023 16:37, Johan Hovold wrote: > > > On Wed, Mar 29, 2023 at 04:04:44PM +0200, Konrad Dybcio wrote: > > >> If we fail to initialize the GPU for whatever reason (say

Re: [Freedreno] [PATCH] drm/msm/adreno: adreno_gpu: Use suspend() instead of idle() on load error

2023-03-30 Thread Dmitry Baryshkov
On 30/03/2023 17:34, Konrad Dybcio wrote: On 29.03.2023 21:45, Dmitry Baryshkov wrote: On Wed, 29 Mar 2023 at 18:48, Konrad Dybcio wrote: On 29.03.2023 16:37, Johan Hovold wrote: On Wed, Mar 29, 2023 at 04:04:44PM +0200, Konrad Dybcio wrote: If we fail to initialize the GPU for whatever

Re: [Freedreno] [PATCH v7 08/10] dt-bindings: msm/dp: Add bindings for HDCP registers

2023-03-30 Thread Doug Anderson
Hi, On Fri, Mar 24, 2023 at 12:56 PM Mark Yacoub wrote: > > From: Sean Paul > > Add the bindings for the MSM DisplayPort HDCP registers > which are required to write the HDCP key into the display controller as > well as the registers to enable HDCP authentication/key > exchange/encryption. > > C

Re: [Freedreno] [PATCH v7 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller

2023-03-30 Thread Doug Anderson
Hi, On Fri, Mar 24, 2023 at 12:56 PM Mark Yacoub wrote: > > From: Sean Paul > > Add the register ranges required for HDCP key injection and > HDCP TrustZone interaction as described in the dt-bindings for the > sc7180 dp controller. > > Signed-off-by: Sean Paul > Signed-off-by: Mark Yacoub > >

Re: [Freedreno] [v2, 37/50] drm/msm/dpu: enable DPU_CTL_SPLIT_DISPLAY for sc8280xp

2023-03-30 Thread Dmitry Baryshkov
On 30/03/2023 15:29, Konrad Dybcio wrote: On 12.02.2023 00:12, Dmitry Baryshkov wrote: Theoretically since sm8150 we should be using a single CTL for the source split case, but since we do not support it for now, fallback to DPU_CTL_SPLIT_DISPLAY. Signed-off-by: Dmitry Baryshkov --- Hmm.. s

Re: [Freedreno] [v2,40/50] drm/msm/dpu: enable DSPP on sc8180x

2023-03-30 Thread Dmitry Baryshkov
On 30/03/2023 15:39, Konrad Dybcio wrote: On 12.02.2023 00:12, Dmitry Baryshkov wrote: Enable DSPP blocks on sc8180x platform, basing on the vendor dtsi. Signed-off-by: Dmitry Baryshkov --- There's only a single difference between 8150 and 8180: qcom,sde-dspp-dither = <0x82c 0x00010007>;

[Freedreno] [PATCH v3 00/38] drm/msm/dpu: rework HW catalog

2023-03-30 Thread Dmitry Baryshkov
This huge series attempts to restructure the DPU HW catalog into a manageable and reviewable data set. In order to ease review and testing I merged all the necessary fixes into this series. Also I cherry-picked & slightly fixed Konrad's patch adding size to the SSPP and INTF macros. First 4 patche

[Freedreno] [PATCH v3 01/38] drm/msm/dpu: Allow variable SSPP/INTF_BLK size

2023-03-30 Thread Dmitry Baryshkov
From: Konrad Dybcio These blocks are of variable length on different SoCs. Set the correct values where I was able to retrieve it from downstream DTs and leave the old defaults (0x1c8 for sspp and 0x280 for intf) otherwise. Signed-off-by: Konrad Dybcio [DB: fixed some of lengths] Signed-off-by:

[Freedreno] [PATCH v3 06/38] drm/msm/dpu: split SM8450 catalog entry to the separate file

2023-03-30 Thread Dmitry Baryshkov
Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_8_1_sm8450.h| 202 + .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 203 +- 2 files changed, 204 insertions(+), 201 deletions(-) create mode 100644 drivers/gpu/drm/m

[Freedreno] [PATCH v3 03/38] drm/msm/dpu: mark remaining pp data as const

2023-03-30 Thread Dmitry Baryshkov
Fix several leftover _pp strutures and mark them as const, making all hw catalog fit into the rodata section. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/d

[Freedreno] [PATCH v3 02/38] drm/msm/dpu: constify DSC data structures

2023-03-30 Thread Dmitry Baryshkov
DSC hw catalog data is not supposed to be changed, so mark it as const data. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 4 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c

[Freedreno] [PATCH v3 04/38] drm/msm/dpu: move UBWC/memory configuration to separate struct

2023-03-30 Thread Dmitry Baryshkov
UBWC and highest bank settings differ slightly between different DPU units of the same generation, while the dpu_caps and dpu_mdp_cfg are much more stable. To ease configuration reuse move ubwc_swizzle and highest_bank_bit data to separate structure. Reviewed-by: Konrad Dybcio Signed-off-by: Dmit

[Freedreno] [PATCH v3 05/38] drm/msm/dpu: split SM8550 catalog entry to the separate file

2023-03-30 Thread Dmitry Baryshkov
Reviewed-by: Konrad DYbcio Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_9_0_sm8550.h| 177 + .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 180 +- 2 files changed, 179 insertions(+), 178 deletions(-) create mode 100644 drivers/gpu/drm/m

[Freedreno] [PATCH v3 07/38] drm/msm/dpu: split SC8280XP catalog entry to the separate file

2023-03-30 Thread Dmitry Baryshkov
Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h | 194 ++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 188 + 2 files changed, 195 insertions(+), 187 deletions(-) create mode 100644 drivers/gpu/drm/m

[Freedreno] [PATCH v3 09/38] drm/msm/dpu: split SM8350 catalog entry to the separate file

2023-03-30 Thread Dmitry Baryshkov
Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_7_0_sm8350.h| 174 ++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 174 +- 2 files changed, 175 insertions(+), 173 deletions(-) create mode 100644 drivers/gpu/drm/

[Freedreno] [PATCH v3 12/38] drm/msm/dpu: split SC7180 catalog entry to the separate file

2023-03-30 Thread Dmitry Baryshkov
Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_6_2_sc7180.h| 147 ++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 143 + 2 files changed, 148 insertions(+), 142 deletions(-) create mode 100644 drivers/gpu/drm/m

[Freedreno] [PATCH v3 08/38] drm/msm/dpu: split SC7280 catalog entry to the separate file

2023-03-30 Thread Dmitry Baryshkov
Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_7_2_sc7280.h| 148 ++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 144 + 2 files changed, 150 insertions(+), 142 deletions(-) create mode 100644 drivers/gpu/drm/m

[Freedreno] [PATCH v3 14/38] drm/msm/dpu: split SC8180X catalog entry to the separate file

2023-03-30 Thread Dmitry Baryshkov
Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h | 107 ++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 105 + 2 files changed, 108 insertions(+), 104 deletions(-) create mode 100644 drivers/gpu/drm/m

[Freedreno] [PATCH v3 17/38] drm/msm/dpu: split SDM845 catalog entry to the separate file

2023-03-30 Thread Dmitry Baryshkov
Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_4_0_sdm845.h| 202 + .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 207 +- 2 files changed, 203 insertions(+), 206 deletions(-) create mode 100644 drivers/gpu/drm/m

[Freedreno] [PATCH v3 15/38] drm/msm/dpu: split SM8150 catalog entry to the separate file

2023-03-30 Thread Dmitry Baryshkov
Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_5_0_sm8150.h| 193 ++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 186 + 2 files changed, 194 insertions(+), 185 deletions(-) create mode 100644 drivers/gpu/drm/m

[Freedreno] [PATCH v3 19/38] drm/msm/dpu: duplicate sc7180 catalog entries

2023-03-30 Thread Dmitry Baryshkov
Duplicate some of sc7180 catalog entries to remove dependencies between DPU major generations. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_7_2_sc7280.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drive

[Freedreno] [PATCH v3 10/38] drm/msm/dpu: split SM6115 catalog entry to the separate file

2023-03-30 Thread Dmitry Baryshkov
Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_6_3_sm6115.h| 95 +++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 89 + 2 files changed, 97 insertions(+), 87 deletions(-) create mode 100644 drivers/gpu/drm/msm/

[Freedreno] [PATCH v3 26/38] drm/msm/dpu: enable DSPP_2/3 for LM_2/3 on sm8450

2023-03-30 Thread Dmitry Baryshkov
Mark DSPP_2 and DSPP_3 as used for LM_2 and LM_3 Fixes: 100d7ef6995d ("drm/msm/dpu: add support for SM8450") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_1_sm8450.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp

[Freedreno] [PATCH v3 13/38] drm/msm/dpu: split SM8250 catalog entry to the separate file

2023-03-30 Thread Dmitry Baryshkov
Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_6_0_sm8250.h| 130 + .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 131 +- 2 files changed, 131 insertions(+), 130 deletions(-) create mode 100644 drivers/gpu/drm/m

[Freedreno] [PATCH v3 34/38] drm/msm/dpu: rename INTF_foo_MASK to contain major DPU version

2023-03-30 Thread Dmitry Baryshkov
To ease review and reuse rename INTF feature masks to contain base DPU version since which this mask is used. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h| 8 .../drm/msm/disp/dpu1/catalog/dpu_4_0_sdm845.h | 8

[Freedreno] [PATCH v3 20/38] drm/msm/dpu: duplicate sm8150 catalog entries

2023-03-30 Thread Dmitry Baryshkov
Duplicate some of sm8150 catalog entries to remove dependencies between DPU major generations. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_6_0_sm8250.h| 134 -- .../msm/disp/dpu1/catalog/dpu_7_0_sm8350.h| 34 - .../ms

[Freedreno] [PATCH v3 21/38] drm/msm/dpu: duplicate sm8250 catalog entries

2023-03-30 Thread Dmitry Baryshkov
Duplicate some of sm8250 catalog entries to remove dependencies between DPU major generations. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_7_0_sm8350.h| 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/dr

[Freedreno] [PATCH v3 22/38] drm/msm/dpu: duplicate sm8350 catalog entries

2023-03-30 Thread Dmitry Baryshkov
Duplicate some of sm8350 catalog entries to remove dependencies between DPU major generations. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/dri

[Freedreno] [PATCH v3 16/38] drm/msm/dpu: split MSM8998 catalog entry to the separate file

2023-03-30 Thread Dmitry Baryshkov
Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 188 + .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 190 +- 2 files changed, 190 insertions(+), 188 deletions(-) create mode 100644 drivers/gpu/drm/m

[Freedreno] [PATCH v3 29/38] drm/msm/dpu: deduplicate sc8180x with sm8150

2023-03-30 Thread Dmitry Baryshkov
Remove duplicate between sc8180x and sm8150, which belong to the same DPU major revision. The merged file is named using the DPU major version and the amount of LM units. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_5_0_sm8150.h| 172 ++---

[Freedreno] [PATCH v3 35/38] drm/msm/dpu: rename CTL_foo_MASK to contain major DPU version

2023-03-30 Thread Dmitry Baryshkov
To ease review and reuse rename CTL feature masks to contain base DPU version since which this mask is used. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 10 +- .../msm/disp/dpu1/catalog/dpu_4_0_sdm845.h| 10 +

[Freedreno] [PATCH v3 33/38] drm/msm/dpu: inline IRQ_n_MASK defines

2023-03-30 Thread Dmitry Baryshkov
IRQ masks are rarely shared between different DPU revisions. Inline them to the dpu_mdss_cfg intances and drop them from the dpu_hw_catalog.c Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 9 ++- .../msm/disp/dpu1/catalog/dpu_4_0_

[Freedreno] [PATCH v3 18/38] drm/msm/dpu: duplicate sdm845 catalog entries

2023-03-30 Thread Dmitry Baryshkov
Duplicate some of sdm845 catalog entries to remove dependencies between DPU major generations. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- .../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 19 +++- .../msm/disp/dpu1/catalog/dpu_5_0_sm8150.h| 43 +-- .../

[Freedreno] [PATCH v3 23/38] drm/msm/dpu: use defined symbol for sc8280xp's maxwidth

2023-03-30 Thread Dmitry Baryshkov
Use defined name DEFAULT_DPU_OUTPUT_LINE_WIDTH instead of open coding the value. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/d

[Freedreno] [PATCH v3 38/38] drm/msm/dpu: rename MERGE_3D_foo_MASK to contain major DPU version

2023-03-30 Thread Dmitry Baryshkov
To ease review and reuse rename MERGE_3D feature masks to contain base DPU version since which this mask is used. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

  1   2   >