Re: [Freedreno] [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

On Mon, 20 Feb 2023 08:14:47 -0800 Rob Clark wrote: > On Mon, Feb 20, 2023 at 12:53 AM Pekka Paalanen wrote: > > > > On Sat, 18 Feb 2023 13:15:49 -0800 > > Rob Clark wrote: > > > > > From: Rob Clark > > > > > > Allow userspace to use the EPOLLPRI/POLLPRI flag to indicate an urgent > > > wait

Re: [Freedreno] [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

On Mon, 20 Feb 2023 09:31:41 +0100 Christian König wrote: > Am 18.02.23 um 22:15 schrieb Rob Clark: > > From: Rob Clark > > > > Allow userspace to use the EPOLLPRI/POLLPRI flag to indicate an urgent > > wait (as opposed to a "housekeeping" wait to know when to cleanup after > > some work has com

Re: [Freedreno] [PATCH v4 05/14] dma-buf/sync_file: Add SET_DEADLINE ioctl

On Mon, 20 Feb 2023 08:09:04 -0800 Rob Clark wrote: > On Mon, Feb 20, 2023 at 12:27 AM Christian König > wrote: > > > > Am 18.02.23 um 22:15 schrieb Rob Clark: > > > From: Rob Clark > > > > > > The initial purpose is for igt tests, but this would also be useful for > > > compositors that wait

Re: [Freedreno] [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

On Mon, 20 Feb 2023 07:55:41 -0800 Rob Clark wrote: > On Mon, Feb 20, 2023 at 1:08 AM Pekka Paalanen wrote: > > > > On Sat, 18 Feb 2023 13:15:53 -0800 > > Rob Clark wrote: > > > > > From: Rob Clark > > > > > > Will be used in the next commit to set a deadline on fences that an > > > atomic u

Re: [Freedreno] [PATCH v5 09/14] drm/syncobj: Add deadline support for syncobj waits

On Mon, 20 Feb 2023 12:18:56 -0800 Rob Clark wrote: > From: Rob Clark > > Add a new flag to let userspace provide a deadline as a hint for syncobj > and timeline waits. This gives a hint to the driver signaling the > backing fences about how soon userspace needs it to compete work, so it > can

[Freedreno] [PATCH 0/4] drm/msm/adreno: fix runtime PM imbalance at unbind

As reported by Bjorn, we can end up with an unbalanced runtime PM disable count if unbind() is called before the drm device is opened (e.g. if component bind fails due to the panel driver not having been loaded yet). As runtime PM must currently stay disabled until the firmware has been loaded, fi

[Freedreno] [PATCH 1/4] drm/msm/adreno: fix runtime PM imbalance at unbind

A recent commit moved enabling of runtime PM from adreno_gpu_init() to adreno_load_gpu() (called on first open()), which means that unbind() may now be called with runtime PM disabled in case the device was never opened in between. Make sure to only forcibly suspend and disable runtime PM at unbin

[Freedreno] [PATCH 3/4] drm/msm/adreno: drop redundant pm_runtime_disable()

Since commit 4b18299b3365 ("drm/msm/adreno: Defer enabling runpm until hw_init()") runtime PM is no longer enabled at adreno_gpu_init(), which means that there are no longer any bind() error paths for which adreno_gpu_cleanup() is called with runtime PM enabled. As the runtime PM enable on first o

[Freedreno] [PATCH 2/4] drm/msm/adreno: drop bogus pm_runtime_set_active()

The runtime PM status can only be updated while runtime PM is disabled. Drop the bogus pm_runtime_set_active() call that was made after enabling runtime PM and which (incidentally but correctly) left the runtime PM status set to 'suspended'. Fixes: 2c087a336676 ("drm/msm/adreno: Load the firmware

[Freedreno] [PATCH 4/4] drm/msm/adreno: clean up component ops indentation

Clean up the component ops initialisers which were indented one level too far. Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/adreno/adreno_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adre

Re: [Freedreno] [PATCH] drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini()

Thomas Zimmermann writes: > Move drm_fb_helper_unprepare() from drm_fb_helper_fini() into the > calling fbdev implementation. Avoids a possible stale mutex with > generic fbdev code. > > As indicated by its name, drm_fb_helper_prepare() prepares struct > drm_fb_helper before setting up the fbdev

Re: [Freedreno] [PATCH] drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini()

Hi Am 21.02.23 um 11:27 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Move drm_fb_helper_unprepare() from drm_fb_helper_fini() into the calling fbdev implementation. Avoids a possible stale mutex with generic fbdev code. As indicated by its name, drm_fb_helper_prepare() prepare

Re: [Freedreno] [PATCH] drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini()

Thomas Zimmermann writes: > Hi > > Am 21.02.23 um 11:27 schrieb Javier Martinez Canillas: >> Thomas Zimmermann writes: >> >>> Move drm_fb_helper_unprepare() from drm_fb_helper_fini() into the >>> calling fbdev implementation. Avoids a possible stale mutex with >>> generic fbdev code. >>> >>> As

Re: [Freedreno] [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

On Tue, Feb 21, 2023 at 10:45:51AM +0200, Pekka Paalanen wrote: > On Mon, 20 Feb 2023 07:55:41 -0800 > Rob Clark wrote: > > > On Mon, Feb 20, 2023 at 1:08 AM Pekka Paalanen wrote: > > > > > > On Sat, 18 Feb 2023 13:15:53 -0800 > > > Rob Clark wrote: > > > > > > > From: Rob Clark > > > > > >

Re: [Freedreno] [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

On Tue, 21 Feb 2023 15:01:35 +0200 Ville Syrjälä wrote: > On Tue, Feb 21, 2023 at 10:45:51AM +0200, Pekka Paalanen wrote: > > On Mon, 20 Feb 2023 07:55:41 -0800 > > Rob Clark wrote: > > > > > On Mon, Feb 20, 2023 at 1:08 AM Pekka Paalanen > > > wrote: > > > > > > > > On Sat, 18 Feb 2023 1

Re: [Freedreno] [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

On Tue, Feb 21, 2023 at 03:11:33PM +0200, Pekka Paalanen wrote: > On Tue, 21 Feb 2023 15:01:35 +0200 > Ville Syrjälä wrote: > > > On Tue, Feb 21, 2023 at 10:45:51AM +0200, Pekka Paalanen wrote: > > > On Mon, 20 Feb 2023 07:55:41 -0800 > > > Rob Clark wrote: > > > > > > > On Mon, Feb 20, 2023

Re: [Freedreno] [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

On Tue, Feb 21, 2023 at 9:38 AM Pekka Paalanen wrote: > > On Mon, 20 Feb 2023 08:14:47 -0800 > Rob Clark wrote: > > > On Mon, Feb 20, 2023 at 12:53 AM Pekka Paalanen wrote: > > > > > > On Sat, 18 Feb 2023 13:15:49 -0800 > > > Rob Clark wrote: > > > > > > > From: Rob Clark > > > > > > > > Allow

Re: [Freedreno] [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

On 2023-02-20 11:14, Rob Clark wrote: > On Mon, Feb 20, 2023 at 12:53 AM Pekka Paalanen wrote: >> >> On Sat, 18 Feb 2023 13:15:49 -0800 >> Rob Clark wrote: >> >>> From: Rob Clark >>> >>> Allow userspace to use the EPOLLPRI/POLLPRI flag to indicate an urgent >>> wait (as opposed to a "housekeepin

Re: [Freedreno] [PATCH v5 09/14] drm/syncobj: Add deadline support for syncobj waits

On Tue, Feb 21, 2023 at 12:53 AM Pekka Paalanen wrote: > > On Mon, 20 Feb 2023 12:18:56 -0800 > Rob Clark wrote: > > > From: Rob Clark > > > > Add a new flag to let userspace provide a deadline as a hint for syncobj > > and timeline waits. This gives a hint to the driver signaling the > > backi

Re: [Freedreno] [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

On Tue, Feb 21, 2023 at 5:01 AM Ville Syrjälä wrote: > > On Tue, Feb 21, 2023 at 10:45:51AM +0200, Pekka Paalanen wrote: > > On Mon, 20 Feb 2023 07:55:41 -0800 > > Rob Clark wrote: > > > > > On Mon, Feb 20, 2023 at 1:08 AM Pekka Paalanen > > > wrote: > > > > > > > > On Sat, 18 Feb 2023 13:15:53

Re: [Freedreno] [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

On Tue, Feb 21, 2023 at 8:48 AM Luben Tuikov wrote: > > On 2023-02-20 11:14, Rob Clark wrote: > > On Mon, Feb 20, 2023 at 12:53 AM Pekka Paalanen wrote: > >> > >> On Sat, 18 Feb 2023 13:15:49 -0800 > >> Rob Clark wrote: > >> > >>> From: Rob Clark > >>> > >>> Allow userspace to use the EPOLLPRI/

Re: [Freedreno] [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

On Tue, Feb 21, 2023 at 8:01 AM Sebastian Wick wrote: > > On Tue, Feb 21, 2023 at 9:38 AM Pekka Paalanen wrote: > > > > On Mon, 20 Feb 2023 08:14:47 -0800 > > Rob Clark wrote: > > > > > On Mon, Feb 20, 2023 at 12:53 AM Pekka Paalanen > > > wrote: > > > > > > > > On Sat, 18 Feb 2023 13:15:49 -0

[Freedreno] [PATCH v4 0/4] Move TE setup to prepare_for_kickoff()

Move TE setup to prepare_for_kickoff() and remove empty prepare_commit() functions in both MDP4 and DPU drivers. Changes in V2: - Added changes to remove empty prepare_commit() functions Changes in V3: - Reordered "drm/msm/dpu: Move TE setup to prepare_for_kickoff()" for clarity - Fixed spelli

[Freedreno] [PATCH v4 1/4] drm/msm/dpu: Move TE setup to prepare_for_kickoff()

Currently, DPU will enable TE during prepare_commit(). However, this will cause a crash and reboot to sahara when trying to read/write to register in get_autorefresh_config(), because the core clock rates aren't set at that time. This used to work because phys_enc->hw_pp is only initialized in mod

[Freedreno] [PATCH v4 2/4] drm/msm: Check for NULL before calling prepare_commit()

Add a NULL check before calling prepare_commit() in msm_atomic_commit_tail() Signed-off-by: Jessica Zhang Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_atomic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_atomic.c b/drivers/gpu/drm/m

[Freedreno] [PATCH v4 3/4] drm/msm/dpu: Remove empty prepare_commit() function

Now that the TE setup has been moved to prepare_for_kickoff(), we have not prepare_commit() callbacks left. This makes dpu_encoder_prepare_commit() do nothing. Remove prepare_commit() from DPU driver. Changes in V3: - Reworded commit message to be more clear - Corrected spelling mistake in commit

[Freedreno] [PATCH v4 4/4] drm/msm/mdp4: Remove empty prepare_commit() function

Remove empty prepare_commit() function from MDP4 driver. Signed-off-by: Jessica Zhang Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4

Re: [Freedreno] [PATCH v4 08/14] drm/scheduler: Add fence deadline support

On 2023-02-18 16:15, Rob Clark wrote: > As the finished fence is the one that is exposed to userspace, and > therefore the one that other operations, like atomic update, would > block on, we need to propagate the deadline from from the finished > fence to the actual hw fence. > > v2: Split into dr

Re: [Freedreno] [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

On Tue, Feb 21, 2023 at 5:01 AM Ville Syrjälä wrote: > > On Tue, Feb 21, 2023 at 10:45:51AM +0200, Pekka Paalanen wrote: > > On Mon, 20 Feb 2023 07:55:41 -0800 > > Rob Clark wrote: > > > > > On Mon, Feb 20, 2023 at 1:08 AM Pekka Paalanen > > > wrote: > > > > > > > > On Sat, 18 Feb 2023 13:15:53

Re: [Freedreno] [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

On Tue, Feb 21, 2023 at 11:54:55AM -0800, Rob Clark wrote: > On Tue, Feb 21, 2023 at 5:01 AM Ville Syrjälä > wrote: > > > > On Tue, Feb 21, 2023 at 10:45:51AM +0200, Pekka Paalanen wrote: > > > On Mon, 20 Feb 2023 07:55:41 -0800 > > > Rob Clark wrote: > > > > > > > On Mon, Feb 20, 2023 at 1:08 AM

Re: [Freedreno] [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

On Tue, Feb 21, 2023 at 11:39:40PM +0200, Ville Syrjälä wrote: > On Tue, Feb 21, 2023 at 11:54:55AM -0800, Rob Clark wrote: > > On Tue, Feb 21, 2023 at 5:01 AM Ville Syrjälä > > wrote: > > > > > > On Tue, Feb 21, 2023 at 10:45:51AM +0200, Pekka Paalanen wrote: > > > > On Mon, 20 Feb 2023 07:55:41

Re: [Freedreno] [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

On Tue, Feb 21, 2023 at 1:48 PM Ville Syrjälä wrote: > > On Tue, Feb 21, 2023 at 11:39:40PM +0200, Ville Syrjälä wrote: > > On Tue, Feb 21, 2023 at 11:54:55AM -0800, Rob Clark wrote: > > > On Tue, Feb 21, 2023 at 5:01 AM Ville Syrjälä > > > wrote: > > > > > > > > On Tue, Feb 21, 2023 at 10:45:51A

Re: [Freedreno] [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

On Tue, Feb 21, 2023 at 02:28:10PM -0800, Rob Clark wrote: > On Tue, Feb 21, 2023 at 1:48 PM Ville Syrjälä > wrote: > > > > On Tue, Feb 21, 2023 at 11:39:40PM +0200, Ville Syrjälä wrote: > > > On Tue, Feb 21, 2023 at 11:54:55AM -0800, Rob Clark wrote: > > > > On Tue, Feb 21, 2023 at 5:01 AM Ville

Re: [Freedreno] [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

On Tue, Feb 21, 2023 at 2:46 PM Ville Syrjälä wrote: > > On Tue, Feb 21, 2023 at 02:28:10PM -0800, Rob Clark wrote: > > On Tue, Feb 21, 2023 at 1:48 PM Ville Syrjälä > > wrote: > > > > > > On Tue, Feb 21, 2023 at 11:39:40PM +0200, Ville Syrjälä wrote: > > > > On Tue, Feb 21, 2023 at 11:54:55AM -0

Re: [Freedreno] [PATCH v4 10/14] drm/vblank: Add helper to get next vblank time

On Tue, Feb 21, 2023 at 3:20 PM Rob Clark wrote: > > On Tue, Feb 21, 2023 at 2:46 PM Ville Syrjälä > wrote: > > > > On Tue, Feb 21, 2023 at 02:28:10PM -0800, Rob Clark wrote: > > > On Tue, Feb 21, 2023 at 1:48 PM Ville Syrjälä > > > wrote: > > > > > > > > On Tue, Feb 21, 2023 at 11:39:40PM +0200