Re: [Freedreno] [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread Geert Uytterhoeven
Hi Dmitry, On Tue, Jan 10, 2023 at 5:37 PM Dmitry Baryshkov wrote: > On 10/01/2023 08:57, Laurentiu Palcu wrote: > > On Mon, Jan 09, 2023 at 10:26:28PM +0200, Dmitry Baryshkov wrote: > >> On 09/01/2023 18:21, Laurentiu Palcu wrote: > >>> It looks like there are some issues with this patchset... :

Re: [Freedreno] [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread Geert Uytterhoeven
On Tue, Jan 10, 2023 at 11:20 AM Geert Uytterhoeven wrote: > On Tue, Jan 10, 2023 at 8:07 AM Laurentiu Palcu > wrote: > > On Mon, Jan 09, 2023 at 10:26:28PM +0200, Dmitry Baryshkov wrote: > > > On 09/01/2023 18:21, Laurentiu Palcu wrote: > > > > It looks like there are some issues with this patch

Re: [Freedreno] [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread Neil Armstrong
Hi Geert, On 07/02/2023 10:40, Geert Uytterhoeven wrote: Hi Dmitry, On Tue, Jan 10, 2023 at 5:37 PM Dmitry Baryshkov wrote: On 10/01/2023 08:57, Laurentiu Palcu wrote: On Mon, Jan 09, 2023 at 10:26:28PM +0200, Dmitry Baryshkov wrote: On 09/01/2023 18:21, Laurentiu Palcu wrote: It looks lik

Re: [Freedreno] [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread Geert Uytterhoeven
Hi Neil, On Tue, Feb 7, 2023 at 10:59 AM Neil Armstrong wrote: > On 07/02/2023 10:40, Geert Uytterhoeven wrote: > > On Tue, Jan 10, 2023 at 5:37 PM Dmitry Baryshkov > > wrote: > >> On 10/01/2023 08:57, Laurentiu Palcu wrote: > >>> On Mon, Jan 09, 2023 at 10:26:28PM +0200, Dmitry Baryshkov wrote:

Re: [Freedreno] [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread neil . armstrong
On 07/02/2023 11:02, Geert Uytterhoeven wrote: Hi Neil, On Tue, Feb 7, 2023 at 10:59 AM Neil Armstrong wrote: On 07/02/2023 10:40, Geert Uytterhoeven wrote: On Tue, Jan 10, 2023 at 5:37 PM Dmitry Baryshkov wrote: On 10/01/2023 08:57, Laurentiu Palcu wrote: On Mon, Jan 09, 2023 at 10:26:28P

Re: [Freedreno] [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread Geert Uytterhoeven
Hi Neil, On Tue, Feb 7, 2023 at 11:02 AM Geert Uytterhoeven wrote: > On Tue, Feb 7, 2023 at 10:59 AM Neil Armstrong > wrote: > > On 07/02/2023 10:40, Geert Uytterhoeven wrote: > > > On Tue, Jan 10, 2023 at 5:37 PM Dmitry Baryshkov > > > wrote: > > >> On 10/01/2023 08:57, Laurentiu Palcu wrote:

Re: [Freedreno] [Intel-gfx] [PATCH v3 2/2] drm/probe_helper: sort out poll_running vs poll_enabled

2023-02-07 Thread Geert Uytterhoeven
Hi Dmitry, On Tue, 24 Jan 2023, Dmitry Baryshkov wrote: There are two flags attemting to guard connector polling: poll_enabled and poll_running. While poll_enabled semantics is clearly defined and fully adhered (mark that drm_kms_helper_poll_init() was called and not finalized by the _fi

Re: [Freedreno] [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread neil . armstrong
t in any later version? $ git log --oneline --author=dmitry next-20230207 drivers/gpu/drm/drm_probe_helper.c c8268795c9a9 drm/probe-helper: enable and disable HPD on connectors 78b991ccfa64 drm/poll-helper: merge drm_kms_helper_poll_disable() and _fini() $

Re: [Freedreno] [PATCH v12 13/14] drm/msm/disp/dpu: add PSR support for eDP interface in dpu driver

2023-02-07 Thread Vinod Polimera
> -Original Message- > From: Dmitry Baryshkov > Sent: Tuesday, January 31, 2023 6:29 PM > To: Vinod Polimera (QUIC) ; dri- > de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; > freedreno@lists.freedesktop.org; devicet...@vger.kernel.org > Cc: linux-ker...@vger.kernel.org; robdc

Re: [Freedreno] [PATCH v12 09/14] drm/msm/dp: disable self_refresh_aware after entering psr

2023-02-07 Thread Vinod Polimera
> -Original Message- > From: Dmitry Baryshkov > Sent: Tuesday, January 31, 2023 6:19 PM > To: Vinod Polimera (QUIC) ; dri- > de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; > freedreno@lists.freedesktop.org; devicet...@vger.kernel.org > Cc: Sankeerth Billakanti (QUIC) ; linux

[Freedreno] [PATCH v2 0/4] Reserve DSPPs based on user request

2023-02-07 Thread Kalyan Thota
This series will enable color features on sc7280 target which has primary panel as eDP The series removes DSPP allocation based on encoder type and allows the DSPP reservation based on user request via CTM. The series will release/reserve the dpu resources when ever there is a topology change

[Freedreno] [PATCH v2 2/4] drm/msm/dpu: add DSPPs into reservation upon a CTM request

2023-02-07 Thread Kalyan Thota
Add DSPP blocks into the topology for reservation, if there is a CTM request for that composition. Signed-off-by: Kalyan Thota --- Changes in v1: - Minor nits (Dmitry) Changes in v2: - Populate DSPPs into the reservation only if CTM is requested (Dmitry) --- drivers/gpu/drm/msm/disp/dpu1/dpu_en

[Freedreno] [PATCH v2 1/4] drm/msm/dpu: clear DSPP reservations in rm release

2023-02-07 Thread Kalyan Thota
Clear DSPP reservations from the global state during rm release Fixes: e47616df008b ("drm/msm/dpu: add support for color processing blocks in dpu driver") Signed-off-by: Kalyan Thota Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten --- drivers/gpu/drm/msm/disp/dp

[Freedreno] [PATCH v2 4/4] drm/msm/dpu: reserve the resources on topology change

2023-02-07 Thread Kalyan Thota
Some features like CTM can be enabled dynamically. Release and reserve the DPU resources whenever a topology change occurs such that required hw blocks are allocated appropriately. Signed-off-by: Kalyan Thota --- Changes in v1: - Avoid mode_set call directly (Dmitry) Changes in v2: - Minor nits

[Freedreno] [PATCH v2 3/4] drm/msm/dpu: avoid unnecessary check in DPU reservations

2023-02-07 Thread Kalyan Thota
Return immediately on failure, this will make dpu reservations part look cleaner. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

Re: [Freedreno] [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread Neil Armstrong
nabled") in next-20230127 next-20230130 next-20230131 but not in any later version? $ git log --oneline --author=dmitry next-20230207 drivers/gpu/drm/drm_probe_helper.c c8268795c9a9 drm/probe-helper: enable and disable HPD on connectors 78b991ccfa64 drm/poll-helper: merge drm_kms_helper_poll_disa

Re: [Freedreno] [PATCH v2 1/4] drm/msm/dpu: clear DSPP reservations in rm release

2023-02-07 Thread Dmitry Baryshkov
On 07/02/2023 16:29, Kalyan Thota wrote: Clear DSPP reservations from the global state during rm release Fixes: e47616df008b ("drm/msm/dpu: add support for color processing blocks in dpu driver") This should fit into a single line (even it is longer than the recommended l

Re: [Freedreno] [PATCH v2 2/4] drm/msm/dpu: add DSPPs into reservation upon a CTM request

2023-02-07 Thread Dmitry Baryshkov
On 07/02/2023 16:29, Kalyan Thota wrote: Add DSPP blocks into the topology for reservation, if there is a CTM request for that composition. Signed-off-by: Kalyan Thota --- Changes in v1: - Minor nits (Dmitry) Changes in v2: - Populate DSPPs into the reservation only if CTM is requested (Dmitry

Re: [Freedreno] [PATCH v2 3/4] drm/msm/dpu: avoid unnecessary check in DPU reservations

2023-02-07 Thread Dmitry Baryshkov
On 07/02/2023 16:29, Kalyan Thota wrote: Return immediately on failure, this will make dpu reservations part look cleaner. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) Reviewed-by:

Re: [Freedreno] [PATCH v2 4/4] drm/msm/dpu: reserve the resources on topology change

2023-02-07 Thread Dmitry Baryshkov
On 07/02/2023 16:29, Kalyan Thota wrote: Some features like CTM can be enabled dynamically. Release and reserve the DPU resources whenever a topology change occurs such that required hw blocks are allocated appropriately. Signed-off-by: Kalyan Thota --- Changes in v1: - Avoid mode_set call dire

Re: [Freedreno] [PATCH v12 09/14] drm/msm/dp: disable self_refresh_aware after entering psr

2023-02-07 Thread Dmitry Baryshkov
On 07/02/2023 16:28, Vinod Polimera wrote: -Original Message- From: Dmitry Baryshkov Sent: Tuesday, January 31, 2023 6:19 PM To: Vinod Polimera (QUIC) ; dri- de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; freedreno@lists.freedesktop.org; devicet...@vger.kernel.org Cc: San

Re: [Freedreno] [PATCH v12 13/14] drm/msm/disp/dpu: add PSR support for eDP interface in dpu driver

2023-02-07 Thread Dmitry Baryshkov
On 07/02/2023 16:26, Vinod Polimera wrote: -Original Message- From: Dmitry Baryshkov Sent: Tuesday, January 31, 2023 6:29 PM To: Vinod Polimera (QUIC) ; dri- de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; freedreno@lists.freedesktop.org; devicet...@vger.kernel.org Cc: lin

Re: [Freedreno] [PATCH v3 23/27] drm/msm/dpu: rework dpu_plane_atomic_check()

2023-02-07 Thread Abhinav Kumar
On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Split pipe-dependent code from dpu_plane_atomic_check() into the separate function dpu_plane_atomic_check_pipe(). This is one of Same comment as prev patch, dpu_plane_atomic_check_pipe() ---> dpu_plane_atomic_check_sspp() preparational steps

Re: [Freedreno] [PATCH v3 23/27] drm/msm/dpu: rework dpu_plane_atomic_check()

2023-02-07 Thread Dmitry Baryshkov
On 07/02/2023 19:49, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Split pipe-dependent code from dpu_plane_atomic_check() into the separate function dpu_plane_atomic_check_pipe(). This is one of Same comment as prev patch, dpu_plane_atomic_check_pipe() ---> dpu_plane_a

Re: [Freedreno] [PATCH v3 23/27] drm/msm/dpu: rework dpu_plane_atomic_check()

2023-02-07 Thread Abhinav Kumar
On 2/7/2023 9:51 AM, Dmitry Baryshkov wrote: On 07/02/2023 19:49, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Split pipe-dependent code from dpu_plane_atomic_check() into the separate function dpu_plane_atomic_check_pipe(). This is one of Same comment as prev patch

Re: [Freedreno] [PATCH v3 23/27] drm/msm/dpu: rework dpu_plane_atomic_check()

2023-02-07 Thread Dmitry Baryshkov
On 07/02/2023 19:57, Abhinav Kumar wrote: On 2/7/2023 9:51 AM, Dmitry Baryshkov wrote: On 07/02/2023 19:49, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Split pipe-dependent code from dpu_plane_atomic_check() into the separate function dpu_plane_atomic_check_pipe(). T

Re: [Freedreno] [PATCH v3 23/27] drm/msm/dpu: rework dpu_plane_atomic_check()

2023-02-07 Thread Abhinav Kumar
On 2/7/2023 9:59 AM, Dmitry Baryshkov wrote: On 07/02/2023 19:57, Abhinav Kumar wrote: On 2/7/2023 9:51 AM, Dmitry Baryshkov wrote: On 07/02/2023 19:49, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Split pipe-dependent code from dpu_plane_atomic_check() into the s

Re: [Freedreno] [PATCH v3 23/27] drm/msm/dpu: rework dpu_plane_atomic_check()

2023-02-07 Thread Dmitry Baryshkov
On 07/02/2023 20:08, Abhinav Kumar wrote: On 2/7/2023 9:59 AM, Dmitry Baryshkov wrote: On 07/02/2023 19:57, Abhinav Kumar wrote: On 2/7/2023 9:51 AM, Dmitry Baryshkov wrote: On 07/02/2023 19:49, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Split pipe-dependent cod

Re: [Freedreno] [PATCH v3 24/27] drm/msm/dpu: rework plane CSC setting

2023-02-07 Thread Abhinav Kumar
On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Rework the code flushing CSC settings for the plane. Separate out the pipe and pipe_cfg as a preparation for r_pipe support. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 45 +-- 1 file cha

Re: [Freedreno] [PATCH v2 1/8] dt-bindings: clock: Merge qcom, gpucc-sm8350 into qcom, gpucc.yaml

2023-02-07 Thread Rob Herring
On Mon, 06 Feb 2023 16:57:00 +0200, Dmitry Baryshkov wrote: > The GPU clock controller bindings for the Qualcomm sm8350 platform are > not correct. The driver uses .fw_name instead of using indices to bind > parent clocks, thus demanding the clock-names usage. With the proper > clock-names in pla

Re: [Freedreno] [PATCH v2 3/8] dt-bindings: display/msm/gmu: add Adreno 660 support

2023-02-07 Thread Rob Herring
On Mon, 06 Feb 2023 16:57:02 +0200, Dmitry Baryshkov wrote: > Add Adreno A660 to the A635 clause to define all version-specific > properties. There is no need to add it to the top-level clause, since > top-level compatible uses pattern to define compatible strings. > > Signed-off-by: Dmitry Bary

Re: [Freedreno] [PATCH v3 24/27] drm/msm/dpu: rework plane CSC setting

2023-02-07 Thread Dmitry Baryshkov
On Tue, 7 Feb 2023 at 22:05, Abhinav Kumar wrote: > > > > On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: > > Rework the code flushing CSC settings for the plane. Separate out the > > pipe and pipe_cfg as a preparation for r_pipe support. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > driver

Re: [Freedreno] [PATCH v3 24/27] drm/msm/dpu: rework plane CSC setting

2023-02-07 Thread Abhinav Kumar
On 2/7/2023 12:44 PM, Dmitry Baryshkov wrote: On Tue, 7 Feb 2023 at 22:05, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Rework the code flushing CSC settings for the plane. Separate out the pipe and pipe_cfg as a preparation for r_pipe support. Signed-off-by: Dmitr

[Freedreno] [PATCH 0/3] drm/msm/adreno: GPU support on SC8280XP

2023-02-07 Thread Bjorn Andersson
This series introduces support for A690 in the DRM/MSM driver and enables it for the two SC8280XP laptops. Bjorn Andersson (3): drm/msm/adreno: Add Adreno A690 support arm64: dts: qcom: sc8280xp: Add GPU related nodes arm64: dts: qcom: sc8280xp: Enable GPU related nodes arch/arm64/boot/dts

[Freedreno] [PATCH 1/3] drm/msm/adreno: Add Adreno A690 support

2023-02-07 Thread Bjorn Andersson
From: Bjorn Andersson Introduce support for the Adreno A690, found in Qualcomm SC8280XP. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 120 - drivers/gpu/drm/msm/adreno/a6xx_hfi.c | 34 ++ drivers/g

[Freedreno] [PATCH 2/3] arm64: dts: qcom: sc8280xp: Add GPU related nodes

2023-02-07 Thread Bjorn Andersson
From: Bjorn Andersson Add Adreno SMMU, GPU clock controller, GMU and GPU nodes for the SC8280XP. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 171 + 1 file changed, 171 insertions(+) diff --git a/arch/arm64

[Freedreno] [PATCH 3/3] arm64: dts: qcom: sc8280xp: Enable GPU related nodes

2023-02-07 Thread Bjorn Andersson
From: Bjorn Andersson Add memory reservation for the zap-shader and enable the Adreno SMMU, GPU clock controller, GMU and the GPU nodes for the SC8280XP CRD and the Lenovo ThinkPad X13s. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sc8280xp-crd.dt