[Freedreno] [PATCH v2 01/12] dt-bindings: display: msm: Add qcom, sm8350-dpu binding

2022-11-15 Thread Robert Foss
Mobile Display Subsystem (MDSS) encapsulates sub-blocks like DPU display controller, DSI etc. Add YAML schema for DPU device tree bindings Signed-off-by: Robert Foss --- .../bindings/display/msm/qcom,sm8350-dpu.yaml | 120 ++ 1 file changed, 120 insertions(+) create mode 100644

[Freedreno] [PATCH v2 00/12] Enable Display for SM8350

2022-11-15 Thread Robert Foss
Dependencies: https://lore.kernel.org/all/20221102231309.583587-1-dmitry.barysh...@linaro.org/ https://lore.kernel.org/all/20221024164225.3236654-1-dmitry.barysh...@linaro.org/ https://lore.kernel.org/all/20221104130324.1024242-5-dmitry.barysh...@linaro.org/ Branch: https://git.linaro.org/people/r

[Freedreno] [PATCH v2 03/12] drm/msm/dpu: Refactor sc7280_pp location

2022-11-15 Thread Robert Foss
The sc7280_pp declaration is not located by the other _pp declarations, but rather hidden around the _merge_3d declarations. Let's fix this to avoid confusion. Signed-off-by: Robert Foss Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 14 +++--- 1 file

[Freedreno] [PATCH v2 02/12] dt-bindings: display: msm: Add qcom, sm8350-mdss binding

2022-11-15 Thread Robert Foss
Mobile Display Subsystem (MDSS) encapsulates sub-blocks like DPU display controller, DSI etc. Add YAML schema for MDSS device tree bindings Signed-off-by: Robert Foss --- .../display/msm/qcom,sm8350-mdss.yaml | 240 ++ 1 file changed, 240 insertions(+) create mode 100644

Re: [Freedreno] [PATCH v2 00/12] Enable Display for SM8350

2022-11-15 Thread Konrad Dybcio
On 15/11/2022 12:17, Robert Foss wrote: Dependencies: https://lore.kernel.org/all/20221102231309.583587-1-dmitry.barysh...@linaro.org/ https://lore.kernel.org/all/20221024164225.3236654-1-dmitry.barysh...@linaro.org/ https://lore.kernel.org/all/20221104130324.1024242-5-dmitry.barysh...@linaro.

[Freedreno] [PATCH v2 01/12] dt-bindings: display: msm: Add qcom, sm8350-dpu binding

2022-11-15 Thread Robert Foss
Mobile Display Subsystem (MDSS) encapsulates sub-blocks like DPU display controller, DSI etc. Add YAML schema for DPU device tree bindings Signed-off-by: Robert Foss --- .../bindings/display/msm/qcom,sm8350-dpu.yaml | 120 ++ 1 file changed, 120 insertions(+) create mode 100644

[Freedreno] [PATCH v2 02/12] dt-bindings: display: msm: Add qcom, sm8350-mdss binding

2022-11-15 Thread Robert Foss
Mobile Display Subsystem (MDSS) encapsulates sub-blocks like DPU display controller, DSI etc. Add YAML schema for MDSS device tree bindings Signed-off-by: Robert Foss --- .../display/msm/qcom,sm8350-mdss.yaml | 240 ++ 1 file changed, 240 insertions(+) create mode 100644

[Freedreno] [PATCH v2 00/12] Enable Display for SM8350

2022-11-15 Thread Robert Foss
Dependencies: https://lore.kernel.org/all/20221102231309.583587-1-dmitry.barysh...@linaro.org/ https://lore.kernel.org/all/20221024164225.3236654-1-dmitry.barysh...@linaro.org/ https://lore.kernel.org/all/20221104130324.1024242-5-dmitry.barysh...@linaro.org/ Branch: https://git.linaro.org/people/r

[Freedreno] [PATCH v2 03/12] drm/msm/dpu: Refactor sc7280_pp location

2022-11-15 Thread Robert Foss
The sc7280_pp declaration is not located by the other _pp declarations, but rather hidden around the _merge_3d declarations. Let's fix this to avoid confusion. Signed-off-by: Robert Foss Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 14 +++--- 1 file

[Freedreno] [PATCH v2 05/12] drm/msm/dpu: Add support for SM8350

2022-11-15 Thread Robert Foss
Add compatibles string, "qcom,sm8350-dpu", for the display processing unit used on Qualcomm SM8350 platform. Signed-off-by: Robert Foss --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/d

[Freedreno] [PATCH v2 04/12] drm/msm/dpu: Add SM8350 to hw catalog

2022-11-15 Thread Robert Foss
Add compatibility for SM8350 display subsystem, including required entries in DPU hw catalog. Signed-off-by: Robert Foss --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 196 ++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h| 1 + 2 files changed, 197 insertions(+) diff --g

[Freedreno] [PATCH v2 06/12] drm/msm: Add support for SM8350

2022-11-15 Thread Robert Foss
Add compatibles string, "qcom,sm8350-mdss", for the multimedia display subsystem unit used on Qualcomm SM8350 platform. Signed-off-by: Robert Foss --- drivers/gpu/drm/msm/msm_mdss.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_m

[Freedreno] [PATCH v2 11/12] arm64: dts: qcom: sm8350-hdk: Enable display & dsi nodes

2022-11-15 Thread Robert Foss
Enable the display subsystem and the dsi0 output for the sm8350-hdk board. Signed-off-by: Robert Foss --- arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350

[Freedreno] [PATCH v2 08/12] arm64: dts: qcom: sm8350: Remove mmxc power-domain-name

2022-11-15 Thread Robert Foss
The mmxc power-domain-name is not required, and is not used by either earlier or later SoC versions (sm8250 / sm8450). Signed-off-by: Robert Foss --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dt

[Freedreno] [PATCH v2 12/12] arm64: dts: qcom: sm8350-hdk: Enable lt9611uxc dsi-hdmi bridge

2022-11-15 Thread Robert Foss
The sm8350-hdk ships with the LT9611 UXC DSI/HDMI bridge chip. In order to toggle the board to enable the HDMI output, switch #7 & #8 on the rightmost multi-switch package have to be toggled to On. Signed-off-by: Robert Foss --- arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 105

[Freedreno] [PATCH v2 09/12] arm64: dts: qcom: sm8350: Use 2 interconnect cells

2022-11-15 Thread Robert Foss
Use two interconnect cells in order to optionally support a path tag. Signed-off-by: Robert Foss --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts

[Freedreno] [PATCH v2 07/12] arm64: dts: qcom: sm8350: Add &tlmm gpio-line-names

2022-11-15 Thread Robert Foss
Add GPIO line names as described by the sm8350-hdk schematic. Signed-off-by: Robert Foss --- arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 205 1 file changed, 205 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts

[Freedreno] [PATCH v2 10/12] arm64: dts: qcom: sm8350: Add display system nodes

2022-11-15 Thread Robert Foss
Add mdss, mdss_mdp, dsi0, dsi0_phy nodes. With these nodes the display subsystem is configured to support one DSI output. Signed-off-by: Robert Foss --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 197 ++- 1 file changed, 193 insertions(+), 4 deletions(-) diff --git a/arch/ar

Re: [Freedreno] [PATCH v2 03/12] drm/msm/dpu: Refactor sc7280_pp location

2022-11-15 Thread Konrad Dybcio
On 15/11/2022 14:30, Robert Foss wrote: The sc7280_pp declaration is not located by the other _pp declarations, but rather hidden around the _merge_3d declarations. Let's fix this to avoid confusion. Signed-off-by: Robert Foss Reviewed-by: Dmitry Baryshkov --- This is already merged. http

Re: [Freedreno] [PATCH v2 04/12] drm/msm/dpu: Add SM8350 to hw catalog

2022-11-15 Thread Konrad Dybcio
On 15/11/2022 14:30, Robert Foss wrote: Add compatibility for SM8350 display subsystem, including required entries in DPU hw catalog. Signed-off-by: Robert Foss --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 196 ++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h| 1

Re: [Freedreno] [PATCH v2 06/12] drm/msm: Add support for SM8350

2022-11-15 Thread Konrad Dybcio
On 15/11/2022 14:30, Robert Foss wrote: Add compatibles string, "qcom,sm8350-mdss", for the multimedia display subsystem unit used on Qualcomm SM8350 platform. Signed-off-by: Robert Foss --- drivers/gpu/drm/msm/msm_mdss.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu

Re: [Freedreno] [PATCH v2 08/12] arm64: dts: qcom: sm8350: Remove mmxc power-domain-name

2022-11-15 Thread Konrad Dybcio
On 15/11/2022 14:31, Robert Foss wrote: The mmxc power-domain-name is not required, and is not used by either earlier or later SoC versions (sm8250 / sm8450). Signed-off-by: Robert Foss --- Reviewed-by: Konrad Dybcio Konrad arch/arm64/boot/dts/qcom/sm8350.dtsi | 1 - 1 file changed, 1

Re: [Freedreno] [PATCH v2 09/12] arm64: dts: qcom: sm8350: Use 2 interconnect cells

2022-11-15 Thread Konrad Dybcio
On 15/11/2022 14:31, Robert Foss wrote: Use two interconnect cells in order to optionally support a path tag. Signed-off-by: Robert Foss --- Reviewed-by: Konrad Dybcio Konrad arch/arm64/boot/dts/qcom/sm8350.dtsi | 28 ++-- 1 file changed, 14 insertions(+), 14 d

Re: [Freedreno] [PATCH v2 10/12] arm64: dts: qcom: sm8350: Add display system nodes

2022-11-15 Thread Konrad Dybcio
On 15/11/2022 14:31, Robert Foss wrote: Add mdss, mdss_mdp, dsi0, dsi0_phy nodes. With these nodes the display subsystem is configured to support one DSI output. Signed-off-by: Robert Foss --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 197 ++- 1 file changed, 193 inse

[Freedreno] [PATCH] drm/msm/hdmi: remove unnecessary NULL check

2022-11-15 Thread Dan Carpenter
This code was refactored in commit 69a88d8633ec ("drm/msm/hdmi: move resource allocation to probe function") and now the "hdmi" pointer can't be NULL. Checking causes a Smatch warning: drivers/gpu/drm/msm/hdmi/hdmi.c:141 msm_hdmi_init() warn: variable dereferenced before check 'hdmi' (see

Re: [Freedreno] [PATCH v2 01/12] dt-bindings: display: msm: Add qcom, sm8350-dpu binding

2022-11-15 Thread Rob Herring
On Tue, 15 Nov 2022 12:17:10 +0100, Robert Foss wrote: > Mobile Display Subsystem (MDSS) encapsulates sub-blocks > like DPU display controller, DSI etc. Add YAML schema for DPU device > tree bindings > > Signed-off-by: Robert Foss > --- > .../bindings/display/msm/qcom,sm8350-dpu.yaml | 120 +++

Re: [Freedreno] [PATCH v2 02/12] dt-bindings: display: msm: Add qcom, sm8350-mdss binding

2022-11-15 Thread Rob Herring
On Tue, 15 Nov 2022 12:17:11 +0100, Robert Foss wrote: > Mobile Display Subsystem (MDSS) encapsulates sub-blocks > like DPU display controller, DSI etc. Add YAML schema for MDSS device > tree bindings > > Signed-off-by: Robert Foss > --- > .../display/msm/qcom,sm8350-mdss.yaml | 240 ++

Re: [Freedreno] [PATCH v2 00/12] Enable Display for SM8350

2022-11-15 Thread Krzysztof Kozlowski
On 15/11/2022 14:30, Robert Foss wrote: > Dependencies: > https://lore.kernel.org/all/20221102231309.583587-1-dmitry.barysh...@linaro.org/ > https://lore.kernel.org/all/20221024164225.3236654-1-dmitry.barysh...@linaro.org/ > https://lore.kernel.org/all/20221104130324.1024242-5-dmitry.barysh...@lina

[Freedreno] [PATCH v3] drm/msm/a6xx: Fix speed-bin detection vs probe-defer

2022-11-15 Thread Rob Clark
From: Rob Clark If we get an error (other than -ENOENT) we need to propagate that up the stack. Otherwise if the nvmem driver hasn't probed yet, we'll end up end up claiming that we support all the OPPs which is not likely to be true (and on some generations impossible to be true, ie. if there a

[Freedreno] [PATCH] drm/msm: Enable clamp_to_idle for 7c3

2022-11-15 Thread Rob Clark
From: Rob Clark This was overlooked. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index ebe9599a8316..e495d8e1

Re: [Freedreno] [PATCH] drm/msm: Enable clamp_to_idle for 7c3

2022-11-15 Thread Doug Anderson
Hi, On Tue, Nov 15, 2022 at 7:55 AM Rob Clark wrote: > > From: Rob Clark > > This was overlooked. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Douglas Anderson

[Freedreno] [PATCH] drm/msm: Enable unpin/eviction by default

2022-11-15 Thread Rob Clark
From: Rob Clark We've had this enabled in the CrOS kernel for a while now without seeing issues, so let's flip the switch upstream now. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_shrinker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/ms

Re: [Freedreno] [PATCH v2 01/12] dt-bindings: display: msm: Add qcom, sm8350-dpu binding

2022-11-15 Thread Rob Herring
On Tue, Nov 15, 2022 at 12:17:10PM +0100, Robert Foss wrote: > Mobile Display Subsystem (MDSS) encapsulates sub-blocks > like DPU display controller, DSI etc. Add YAML schema for DPU device > tree bindings > > Signed-off-by: Robert Foss > --- > .../bindings/display/msm/qcom,sm8350-dpu.yaml | 120

Re: [Freedreno] [PATCH v2 02/12] dt-bindings: display: msm: Add qcom, sm8350-mdss binding

2022-11-15 Thread Rob Herring
On Tue, Nov 15, 2022 at 12:17:11PM +0100, Robert Foss wrote: > Mobile Display Subsystem (MDSS) encapsulates sub-blocks > like DPU display controller, DSI etc. Add YAML schema for MDSS device > tree bindings > > Signed-off-by: Robert Foss > --- > .../display/msm/qcom,sm8350-mdss.yaml | 24

Re: [Freedreno] [PATCH] drm/msm: Enable clamp_to_idle for 7c3

2022-11-15 Thread Chia-I Wu
On Tue, Nov 15, 2022 at 8:01 AM Doug Anderson wrote: > > Hi, > > On Tue, Nov 15, 2022 at 7:55 AM Rob Clark wrote: > > > > From: Rob Clark > > > > This was overlooked. > > > > Signed-off-by: Rob Clark > > --- > > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 14 +++--- > > 1 file changed, 7 i

Re: [Freedreno] [PATCH] drm/msm/dp: remove limitation of link rate at 5.4G to support HBR3

2022-11-15 Thread Kuogee Hsieh
On 11/9/2022 11:43 PM, Dmitry Baryshkov wrote: On 10/11/2022 02:47, Kuogee Hsieh wrote: On 11/2/2022 11:04 AM, Dmitry Baryshkov wrote: On 02/11/2022 20:28, Doug Anderson wrote: Hi, On Wed, Nov 2, 2022 at 10:23 AM Dmitry Baryshkov wrote: 1. Someone figures out how to model this with the

Re: [Freedreno] [PATCH 1/5] drm/msm/dsi: add support for DSI-PHY on SM8350 and SM8450

2022-11-15 Thread Abhinav Kumar
On 11/7/2022 3:02 PM, Dmitry Baryshkov wrote: On 07/11/2022 07:27, Abhinav Kumar wrote: On 9/22/2022 4:30 AM, Dmitry Baryshkov wrote: SM8350 and SM8450 use 5nm DSI PHYs, which share register definitions with 7nm DSI PHYs. Rather than duplicating the driver, handle 5nm variants inside the c

Re: [Freedreno] [PATCH v3 5/8] drm/msm/dsi: add support for DSI 2.6.0

2022-11-15 Thread Abhinav Kumar
On 11/4/2022 6:03 AM, Dmitry Baryshkov wrote: Add support for DSI 2.6.0 (block used on sm8450). Tested-by: Vinod Koul Reviewed-by: Vinod Koul Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 ++ drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1

Re: [Freedreno] [PATCH v3 6/8] drm/msm/dpu: add support for MDP_TOP blackhole

2022-11-15 Thread Abhinav Kumar
On 11/4/2022 6:03 AM, Dmitry Baryshkov wrote: On sm8450 a register block was removed from MDP TOP. Accessing it during snapshotting results in NoC errors / immediate reboot. Skip accessing these registers during snapshot. Tested-by: Vinod Koul Reviewed-by: Vinod Koul Signed-off-by: Dmitry B

Re: [Freedreno] [PATCH v3 8/8] drm/msm: mdss: add support for SM8450

2022-11-15 Thread Abhinav Kumar
On 11/4/2022 6:03 AM, Dmitry Baryshkov wrote: Add support for the MDSS block on SM8450 platform. Tested-by: Vinod Koul Reviewed-by: Vinod Koul Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/msm_mdss.c | 5 + 1 file changed, 5 insertions(+) dif