[Freedreno] [v8] drm/msm/disp/dpu1: add support for dspp sub block flush in sc7280

2022-11-09 Thread Kalyan Thota
Flush mechanism for DSPP blocks has changed in sc7280 family, it allows individual sub blocks to be flushed in coordination with master flush control. Representation: master_flush && (PCC_flush | IGC_flush .. etc ) This change adds necessary support for the above design. Changes in v1: - Few nit

[Freedreno] [PATCH 1/4] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder

2022-11-09 Thread Kalyan Thota
Pin each crtc with one encoder. This arrangement will disallow crtc switching between encoders and also will facilitate to advertise certain features on crtc based on encoder type. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 10 +- 1 file changed, 5 insertio

[Freedreno] [PATCH 2/4] drm/msm/disp/dpu1: populate disp_info if an interface is external

2022-11-09 Thread Kalyan Thota
DRM encoder type is same for eDP and DP (DRM_MODE_ENCODER_TMDS) populate is_external information in the disp_info so as to differentiate between eDP and DP on the DPU encoder side. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 20 +--- drivers/gpu/

[Freedreno] [PATCH 3/4] drm/msm/disp/dpu1: helper function to determine if encoder is virtual

2022-11-09 Thread Kalyan Thota
Add a helper function to determine if an encoder is of type virtual. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 11 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 6 ++ 2 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu

[Freedreno] [PATCH 4/4] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-09 Thread Kalyan Thota
Add color management support for the crtc provided there are enough dspps that can be allocated from the catalogue Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 15 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h| 6 drivers/gpu/drm/msm/disp/dpu1/dpu_e

Re: [Freedreno] [PATCH 1/4] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder

2022-11-09 Thread Dmitry Baryshkov
On 09/11/2022 15:16, Kalyan Thota wrote: Pin each crtc with one encoder. This arrangement will disallow crtc switching between encoders and also will facilitate to advertise certain features on crtc based on encoder type. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c

Re: [Freedreno] [PATCH 2/4] drm/msm/disp/dpu1: populate disp_info if an interface is external

2022-11-09 Thread Dmitry Baryshkov
On 09/11/2022 15:16, Kalyan Thota wrote: DRM encoder type is same for eDP and DP (DRM_MODE_ENCODER_TMDS) populate is_external information in the disp_info so as to differentiate between eDP and DP on the DPU encoder side. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_encod

Re: [Freedreno] [PATCH 3/4] drm/msm/disp/dpu1: helper function to determine if encoder is virtual

2022-11-09 Thread Dmitry Baryshkov
On 09/11/2022 15:16, Kalyan Thota wrote: Add a helper function to determine if an encoder is of type virtual. Please use commit messages to describe why you are doing something, not what you are doing. In this case I can predict, why do you need this API without going to patch 4. Signed-o

Re: [Freedreno] [PATCH 4/4] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-09 Thread Dmitry Baryshkov
On 09/11/2022 15:16, Kalyan Thota wrote: Add color management support for the crtc provided there are enough dspps that can be allocated from the catalogue Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 15 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h|

Re: [Freedreno] [PATCH 4/4] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-09 Thread Kalyan Thota
>-Original Message- >From: Dmitry Baryshkov >Sent: Wednesday, November 9, 2022 6:02 PM >To: Kalyan Thota (QUIC) ; dri- >de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; >freedreno@lists.freedesktop.org; devicet...@vger.kernel.org >Cc: linux-ker...@vger.kernel.org; robdcl...@ch

Re: [Freedreno] [v8] drm/msm/disp/dpu1: add support for dspp sub block flush in sc7280

2022-11-09 Thread Dmitry Baryshkov
On 09/11/2022 15:14, Kalyan Thota wrote: Flush mechanism for DSPP blocks has changed in sc7280 family, it allows individual sub blocks to be flushed in coordination with master flush control. Representation: master_flush && (PCC_flush | IGC_flush .. etc ) This change adds necessary support for

Re: [Freedreno] [PATCH 4/4] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-09 Thread Dmitry Baryshkov
On 09/11/2022 15:39, Kalyan Thota wrote: -Original Message- From: Dmitry Baryshkov Sent: Wednesday, November 9, 2022 6:02 PM To: Kalyan Thota (QUIC) ; dri- de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; freedreno@lists.freedesktop.org; devicet...@vger.kernel.org Cc: linux

Re: [Freedreno] [PATCH 4/4] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-09 Thread Kalyan Thota
>-Original Message- >From: Dmitry Baryshkov >Sent: Wednesday, November 9, 2022 6:02 PM >To: Kalyan Thota (QUIC) ; dri- >de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; >freedreno@lists.freedesktop.org; devicet...@vger.kernel.org >Cc: linux-ker...@vger.kernel.org; robdcl...@ch

Re: [Freedreno] [RFC PATCH 1/3] drm: Introduce color fill properties for drm plane

2022-11-09 Thread Daniel Vetter
On Tue, Nov 08, 2022 at 06:25:29PM +, Simon Ser wrote: > On Saturday, October 29th, 2022 at 13:23, Dmitry Baryshkov > wrote: > > > On 29/10/2022 01:59, Jessica Zhang wrote: > > > > > Add support for COLOR_FILL and COLOR_FILL_FORMAT properties for > > > drm_plane. In addition, add support fo

Re: [Freedreno] [RFC PATCH 1/3] drm: Introduce color fill properties for drm plane

2022-11-09 Thread Dmitry Baryshkov
On 09/11/2022 16:52, Daniel Vetter wrote: On Tue, Nov 08, 2022 at 06:25:29PM +, Simon Ser wrote: On Saturday, October 29th, 2022 at 13:23, Dmitry Baryshkov wrote: On 29/10/2022 01:59, Jessica Zhang wrote: Add support for COLOR_FILL and COLOR_FILL_FORMAT properties for drm_plane. In add

Re: [Freedreno] [RFC PATCH 1/3] drm: Introduce color fill properties for drm plane

2022-11-09 Thread Daniel Vetter
On Wed, Nov 09, 2022 at 04:53:45PM +0300, Dmitry Baryshkov wrote: > On 09/11/2022 16:52, Daniel Vetter wrote: > > On Tue, Nov 08, 2022 at 06:25:29PM +, Simon Ser wrote: > > > On Saturday, October 29th, 2022 at 13:23, Dmitry Baryshkov > > > wrote: > > > > > > > On 29/10/2022 01:59, Jessica Zh

Re: [Freedreno] [RFC PATCH 1/3] drm: Introduce color fill properties for drm plane

2022-11-09 Thread Pekka Paalanen
On Tue, 8 Nov 2022 23:01:47 +0100 Sebastian Wick wrote: > On Tue, Nov 8, 2022 at 7:51 PM Simon Ser wrote: > > > > cc'ing Pekka and wayland-devel for userspace devs feedback on the new uAPI. Hi all, thanks! Comments below. > > > > On Saturday, October 29th, 2022 at 14:08, Dmitry Baryshkov > >

Re: [Freedreno] [PATCH 4/4] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-09 Thread Kalyan Thota
>-Original Message- >From: Kalyan Thota >Sent: Wednesday, November 9, 2022 6:53 PM >To: dmitry.barysh...@linaro.org; Kalyan Thota (QUIC) >; dri-de...@lists.freedesktop.org; linux-arm- >m...@vger.kernel.org; freedreno@lists.freedesktop.org; >devicet...@vger.kernel.org >Cc: linux-ker...@vg

[Freedreno] [PATCH v2 0/2] Add DP max link rate support

2022-11-09 Thread Kuogee Hsieh
dd DP link-frequencies property to DTS file and support function to DP driver. Kuogee Hsieh (2): arm64: dts: qcom: Add link-frequencies property to specify the max link rate allowed drm/msm/dp: add support of max dp link rate arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 1 + drivers/

[Freedreno] [PATCH v2 1/2] arm64: dts: qcom: Add link-frequencies property to specify the max link rate allowed

2022-11-09 Thread Kuogee Hsieh
This patch add link-frequencies property to allow each platform to specify its DP max link rate. Signed-off-by: Kuogee Hsieh --- arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dt

[Freedreno] [PATCH v2 2/2] drm/msm/dp: add support of max dp link rate

2022-11-09 Thread Kuogee Hsieh
Since it is not every platform supports HBR3 link rate, this patch limit the DP link rate at max link rate if it is specified at DTS file. Otherwise, the max dp link rate will be limited at HBR2 as before. Changes in v2: -- add max link rate from dtsi Signed-off-by: Kuogee Hsieh --- drivers/gpu

Re: [Freedreno] [PATCH v2 1/2] arm64: dts: qcom: Add link-frequencies property to specify the max link rate allowed

2022-11-09 Thread Dmitry Baryshkov
On 09/11/2022 21:34, Kuogee Hsieh wrote: This patch add link-frequencies property to allow each platform to specify its DP max link rate. Signed-off-by: Kuogee Hsieh --- arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qco

Re: [Freedreno] [PATCH] drm/msm/dp: remove limitation of link rate at 5.4G to support HBR3

2022-11-09 Thread Kuogee Hsieh
On 11/2/2022 11:04 AM, Dmitry Baryshkov wrote: On 02/11/2022 20:28, Doug Anderson wrote: Hi, On Wed, Nov 2, 2022 at 10:23 AM Dmitry Baryshkov wrote: 1. Someone figures out how to model this with the bridge chain and then we only allow HBR3 if we detect we've got a TCPC that supports it. T

Re: [Freedreno] [PATCH v3 2/2] drm/msm: Hangcheck progress detection

2022-11-09 Thread Chia-I Wu
On Fri, Nov 4, 2022 at 8:08 AM Rob Clark wrote: > > From: Rob Clark > > If the hangcheck timer expires, check if the fw's position in the > cmdstream has advanced (changed) since last timer expiration, and > allow it up to three additional "extensions" to it's alotted time. > The intention is to

Re: [Freedreno] [RFC PATCH 1/3] drm: Introduce color fill properties for drm plane

2022-11-09 Thread Jessica Zhang
On 11/9/2022 5:59 AM, Daniel Vetter wrote: On Wed, Nov 09, 2022 at 04:53:45PM +0300, Dmitry Baryshkov wrote: On 09/11/2022 16:52, Daniel Vetter wrote: On Tue, Nov 08, 2022 at 06:25:29PM +, Simon Ser wrote: On Saturday, October 29th, 2022 at 13:23, Dmitry Baryshkov wrote: On 29/10/20

Re: [Freedreno] [PATCH] drm/msm/dp: remove limitation of link rate at 5.4G to support HBR3

2022-11-09 Thread Dmitry Baryshkov
On 10/11/2022 02:47, Kuogee Hsieh wrote: On 11/2/2022 11:04 AM, Dmitry Baryshkov wrote: On 02/11/2022 20:28, Doug Anderson wrote: Hi, On Wed, Nov 2, 2022 at 10:23 AM Dmitry Baryshkov wrote: 1. Someone figures out how to model this with the bridge chain and then we only allow HBR3 if we de