Re: [Freedreno] [PATCH v3 1/3] dt-bindings: phy: qcom, hdmi-phy-qmp: add clock-cells and XO clock

2022-07-05 Thread Vinod Koul
On 04-07-22, 19:11, Dmitry Baryshkov wrote: > As the QMP HDMI PHY is a clock provider, add constant #clock-cells > property. For the compatibility with older DTs the property is not > marked as required. Also add the XO clock to the list of the clocks used > by the driver. Acked-By: Vinod Koul >

Re: [Freedreno] [PATCH] drm/msm/dp: make eDP panel as the first connected connector

2022-07-05 Thread Abhinav Kumar
On 7/4/2022 11:14 AM, Dmitry Baryshkov wrote: On 30/06/2022 09:14, Dmitry Baryshkov wrote: On 30 June 2022 04:57:35 GMT+03:00, Rob Clark wrote: On Wed, Jun 29, 2022 at 5:36 PM Doug Anderson wrote: Hi, On Tue, Jun 28, 2022 at 1:14 PM Dmitry Baryshkov wrote: On 28 June 2022 18:20:06

Re: [Freedreno] [PATCH v15 2/3] phy: qcom-qmp: add regulator_set_load to dp phy

2022-07-05 Thread Vinod Koul
On 21-06-22, 10:01, Kuogee Hsieh wrote: > This patch add regulator_set_load() before enable regulator at > DP phy driver. > > Signed-off-by: Kuogee Hsieh > Reviewed-by: Stephen Boyd > Reviewed-by: Douglas Anderson > --- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 43 > ++

Re: [Freedreno] [PATCH 1/3] dt-bindings: phy: qcom, hdmi-phy-qmp: add clock-cells

2022-07-05 Thread Vinod Koul
On 17-06-22, 13:36, Dmitry Baryshkov wrote: > As the QMP HDMI PHY is a clock provider, add constant #clock-cells > property. For the compatibility with older DTs the property is not > marked as required. Acked-By: Vinod Koul -- ~Vinod

[Freedreno] [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-05 Thread Kuogee Hsieh
0) rebase on https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tree 1) add regulator_set_load() to eDP phy 2) add regulator_set_load() to DP phy 3) remove vdda related function out of eDP/DP controller Kuogee Hsieh (3): phy: qcom-edp: add regulator_set_load to edp phy phy: qco

[Freedreno] [PATCH v16 1/3] phy: qcom-edp: add regulator_set_load to edp phy

2022-07-05 Thread Kuogee Hsieh
This patch add regulator_set_load() before enable regulator at eDP phy driver. Signed-off-by: Kuogee Hsieh Reviewed-by: Douglas Anderson Reviewed-by: Dmitry Baryshkov --- drivers/phy/qualcomm/phy-qcom-edp.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/phy/qualcomm/

[Freedreno] [PATCH v16 2/3] phy: qcom-qmp: add regulator_set_load to dp phy

2022-07-05 Thread Kuogee Hsieh
This patch add regulator_set_load() before enable regulator at DP phy driver. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Reviewed-by: Douglas Anderson --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 41 --- 1 file changed, 32 insertions(+), 9 deletions(-)

[Freedreno] [PATCH v16 3/3] drm/msm/dp: delete vdda regulator related functions from eDP/DP controller

2022-07-05 Thread Kuogee Hsieh
Vdda regulators are related to both eDP and DP phy so that it should be managed at eDP and DP phy driver instead of controller. This patch removes vdda regulators related functions out of eDP/DP controller. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Reviewed-by: Dmitry Baryshkov Revi

[Freedreno] [PATCH v4 3/7] drm/msm/dp: Add basic PSR support for eDP

2022-07-05 Thread Vinod Polimera
Add support for basic panel self refresh (PSR) feature for eDP. Add a new interface to set PSR state in the sink from DPU. Program the eDP controller to issue PSR enter and exit SDP to the sink. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/dp/dp_cata

[Freedreno] [PATCH v4 0/7] Add PSR support for eDP

2022-07-05 Thread Vinod Polimera
Changes in v2: - Use dp bridge to set psr entry/exit instead of dpu_enocder. - Don't modify whitespaces. - Set self refresh aware from atomic_check. - Set self refresh aware only if psr is supported. - Provide a stub for msm_dp_display_set_psr. - Move dp functions to bridge code. Chang

[Freedreno] [PATCH v4 6/7] drm/msm/disp/dpu1: use atomic enable/disable callbacks for encoder functions

2022-07-05 Thread Vinod Polimera
Use atomic variants for encoder callback functions such that certain states like self-refresh can be accessed as part of enable/disable sequence. Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10 ++

[Freedreno] [PATCH v4 5/7] drm/bridge: Add psr support for panel bridge callbacks

2022-07-05 Thread Vinod Polimera
This change will handle the psr entry exit cases in the panel bridge atomic callback functions. For example, the panel power should not turn off if the panel is entering psr. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera --- drivers/gpu/drm/bridge/panel.c | 48 ++

[Freedreno] [PATCH v4 2/7] drm: add helper functions to retrieve old and new crtc

2022-07-05 Thread Vinod Polimera
Add new helper functions, drm_atomic_get_old_crtc_for_encoder and drm_atomic_get_new_crtc_for_encoder to retrieve the corresponding crtc for the encoder. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera --- drivers/gpu/drm/drm_atomic.c | 60 +

[Freedreno] [PATCH v4 7/7] drm/msm/disp/dpu1: add PSR support for eDP interface in dpu driver

2022-07-05 Thread Vinod Polimera
Enable PSR on eDP interface using drm self-refresh librabry. This patch uses a trigger from self-refresh library to enter/exit into PSR, when there are no updates from framework. Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 13 +

[Freedreno] [PATCH v4 4/7] drm/bridge: use atomic enable/disable callbacks for panel bridge

2022-07-05 Thread Vinod Polimera
Use atomic variants for panel bridge callback functions such that certain states like self-refresh can be accessed as part of enable/disable sequence. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera --- drivers/gpu/drm/bridge/panel.c | 20 1 file changed,

[Freedreno] [PATCH v4 1/7] drm/msm/disp/dpu1: clear dpu_assign_crtc and get crtc from drm_enc instead of dpu_enc

2022-07-05 Thread Vinod Polimera
Update crtc retrieval from dpu_enc to drm_enc, since new links get set as part of the update legacy mode set. The dpu_enc->crtc cache is no more needed, hence cleaning it as part of this change. Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 4 drivers/gpu/

Re: [Freedreno] [PATCH v4 1/7] drm/msm/disp/dpu1: clear dpu_assign_crtc and get crtc from drm_enc instead of dpu_enc

2022-07-05 Thread Dmitry Baryshkov
On 05/07/2022 20:00, Vinod Polimera wrote: Update crtc retrieval from dpu_enc to drm_enc, since new links get set as part of the update legacy mode set. The dpu_enc->crtc cache is no more needed, hence cleaning it as part of this change. NAK. Quoting the documentation: only really meaningful f

Re: [Freedreno] [PATCH v4 4/7] drm/bridge: use atomic enable/disable callbacks for panel bridge

2022-07-05 Thread Dmitry Baryshkov
On 05/07/2022 20:00, Vinod Polimera wrote: Use atomic variants for panel bridge callback functions such that certain states like self-refresh can be accessed as part of enable/disable sequence. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov

Re: [Freedreno] [PATCH v4 6/7] drm/msm/disp/dpu1: use atomic enable/disable callbacks for encoder functions

2022-07-05 Thread Dmitry Baryshkov
On 05/07/2022 20:00, Vinod Polimera wrote: Use atomic variants for encoder callback functions such that certain states like self-refresh can be accessed as part of enable/disable sequence. Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov No. Your sign

Re: [Freedreno] [PATCH v4 7/7] drm/msm/disp/dpu1: add PSR support for eDP interface in dpu driver

2022-07-05 Thread Dmitry Baryshkov
On 05/07/2022 20:00, Vinod Polimera wrote: Enable PSR on eDP interface using drm self-refresh librabry. This patch uses a trigger from self-refresh library to enter/exit into PSR, when there are no updates from framework. Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera --- drivers/

Re: [Freedreno] [PATCH v4 3/7] drm/msm/dp: Add basic PSR support for eDP

2022-07-05 Thread Dmitry Baryshkov
On 05/07/2022 20:00, Vinod Polimera wrote: Add support for basic panel self refresh (PSR) feature for eDP. Add a new interface to set PSR state in the sink from DPU. Program the eDP controller to issue PSR enter and exit SDP to the sink. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod