Re: [Freedreno] [PATCH v4] drm/msm/dp: force link training for display resolution change

2022-06-13 Thread Kuogee Hsieh
On 6/10/2022 2:04 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-05-27 14:32:13) During display resolution changes display have to be disabled first followed by display enabling with new resolution. Display disable will turn off both pixel clock and main link clock so that main link have t

[Freedreno] [PATCH] drm/msm/adreno: Defer enabling runpm until hw_init()

2022-06-13 Thread Rob Clark
From: Rob Clark To avoid preventing the display from coming up before the rootfs is mounted, without resorting to packing fw in the initrd, the GPU has this limbo state where the device is probed, but we aren't ready to start sending commands to it. This is particularly problematic for a6xx, sin

[Freedreno] [PATCH] drm/msm: Deprecate MSM_BO_UNCACHED harder

2022-06-13 Thread Rob Clark
From: Rob Clark Handle the demotion to MSM_BO_WC at the userspace ABI level, and fix the remaining internal MSM_BO_UNCACHED user. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 13 + drivers/gpu/drm/msm/msm_gem.c | 7 +++ drivers/gpu/drm/msm/msm_gpu.c | 2 +- 3

[Freedreno] [PATCH] drm/msm: Make msm_gem_free_object() static

2022-06-13 Thread Rob Clark
From: Rob Clark Misc small cleanup I noticed. Not called from another object file since 3c9edd9c85f5 ("drm/msm: Introduce GEM object funcs") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 2 +- drivers/gpu/drm/msm/msm_gem.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)

[Freedreno] [PATCH] drm/msm/gem: Drop obj lock in msm_gem_free_object()

2022-06-13 Thread Rob Clark
From: Rob Clark The only reason we grabbed the lock was to satisfy a bunch of places that WARN_ON() if called without the lock held. But this angers lockdep which doesn't realize no one else can be holding the lock by the time we end up destroying the object (and sees what would otherwise be a l

[Freedreno] [PATCH v5] drm/msm/dp: force link training for display resolution change

2022-06-13 Thread Kuogee Hsieh
During display resolution changes display have to be disabled first followed by display enabling with new resolution. Display disable will turn off both pixel clock and main link clock so that main link have to be re-trained during display enable to have new video stream flow again. At current impl

[Freedreno] [PATCH v2] drm/msm: use for_each_sgtable_sg to iterate over scatterlist

2022-06-13 Thread Jonathan Marek
The dma_map_sgtable() call (used to invalidate cache) overwrites sgt->nents with 1, so msm_iommu_pagetable_map maps only the first physical segment. To fix this problem use for_each_sgtable_sg(), which uses orig_nents. Fixes: b145c6e65eb0 ("drm/msm: Add support to create a local pagetable") Signe

Re: [Freedreno] [PATCH] drm/msm: Make msm_gem_free_object() static

2022-06-13 Thread Abhinav Kumar
On 6/13/2022 1:49 PM, Rob Clark wrote: From: Rob Clark Misc small cleanup I noticed. Not called from another object file since 3c9edd9c85f5 ("drm/msm: Introduce GEM object funcs") Signed-off-by: Rob Clark Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/msm_gem.c | 2 +- drivers/g