Re: [Freedreno] [PATCH v2 04/11] drm/msm/dsi/phy: Reindent and reflow multiline function calls

2022-06-10 Thread Marijn Suijten
On 2022-06-02 13:14:26, Dmitry Baryshkov wrote: > On Thu, 2 Jun 2022 at 01:07, Marijn Suijten > wrote: > > > > Patch 613cbd1da3c9 ("drm/msm/dsi: use devm_clk_*register to registe DSI > > PHY clocks") introduced the devm_ prefix to clk_hw registration calls, > > without updating the indentation of

Re: [Freedreno] [PATCH v2 03/11] clk: fixed-factor: Introduce *clk_hw_register_fixed_factor_parent_hw()

2022-06-10 Thread Marijn Suijten
On 2022-06-09 15:12:09, Stephen Boyd wrote: > Quoting Dmitry Baryshkov (2022-06-02 03:20:19) > > On Thu, 2 Jun 2022 at 01:07, Marijn Suijten > > wrote: > > > diff --git a/drivers/clk/clk-fixed-factor.c > > > b/drivers/clk/clk-fixed-factor.c > > > index 54942d758ee6..fabb98d0cdb2 100644 > > > ---

Re: [Freedreno] [PATCH v3] drm/msm: Avoid unclocked GMU register access in 6xx gpu_busy

2022-06-10 Thread Rob Clark
On Thu, Jun 9, 2022 at 5:10 PM Douglas Anderson wrote: > > From testing on sc7180-trogdor devices, reading the GMU registers > needs the GMU clocks to be enabled. Those clocks get turned on in > a6xx_gmu_resume(). Confusingly enough, that function is called as a > result of the runtime_pm of the G

[Freedreno] [PATCH] drm/msm/gem: Drop early returns in close/purge vma

2022-06-10 Thread Rob Clark
From: Rob Clark Keep the warn, but drop the early return. If we do manage to hit this sort of issue, skipping the cleanup just makes things worse (dangling drm_mm_nodes when the msm_gem_vma is freed, etc). Whereas the worst that happens if we tear down a mapping the GPU is accessing is that we

Re: [Freedreno] [PATCH v2 03/11] clk: fixed-factor: Introduce *clk_hw_register_fixed_factor_parent_hw()

2022-06-10 Thread Stephen Boyd
Quoting Marijn Suijten (2022-06-10 00:46:32) > On 2022-06-09 15:12:09, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2022-06-02 03:20:19) > > > On Thu, 2 Jun 2022 at 01:07, Marijn Suijten > > > wrote: > > > > diff --git a/drivers/clk/clk-fixed-factor.c > > > > b/drivers/clk/clk-fixed-factor.c

[Freedreno] [PATCH v4] drm/msm: Avoid unclocked GMU register access in 6xx gpu_busy

2022-06-10 Thread Douglas Anderson
>From testing on sc7180-trogdor devices, reading the GMU registers needs the GMU clocks to be enabled. Those clocks get turned on in a6xx_gmu_resume(). Confusingly enough, that function is called as a result of the runtime_pm of the GPU "struct device", not the GMU "struct device". Unfortunately th

Re: [Freedreno] [PATCH] drm/msm/hdmi: fill the pwr_regs bulk regulators

2022-06-10 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-09 04:31:48) > Conversion to use bulk regulator API omitted filling the pwr_regs with > proper regulator IDs. This was left unnoticed, since none of my testing > platforms has used the pwr_regs. Fix this by propagating regulator ids > properly. > > Fixes: 31b3b1f5e

Re: [Freedreno] [PATCH v3 06/14] drm/msm/hdmi: drop unused GPIO support

2022-06-10 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-09 05:23:42) > The HDMI driver has code to configure extra GPIOs, which predates > pinctrl support. Nowadays all platforms should use pinctrl instead. > Neither of upstreamed Qualcomm platforms uses these properties, so it's > safe to drop them. > > Reported-by: ke

Re: [Freedreno] [PATCH v3 06/14] drm/msm/hdmi: drop unused GPIO support

2022-06-10 Thread Dmitry Baryshkov
On 10/06/2022 23:46, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-06-09 05:23:42) The HDMI driver has code to configure extra GPIOs, which predates pinctrl support. Nowadays all platforms should use pinctrl instead. Neither of upstreamed Qualcomm platforms uses these properties, so it's sa

Re: [Freedreno] [PATCH v4] drm/msm/dp: force link training for display resolution change

2022-06-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-05-27 14:32:13) > During display resolution changes display have to be disabled first > followed by display enabling with new resolution. Display disable > will turn off both pixel clock and main link clock so that main link > have to be re trained during display enable t

Re: [Freedreno] [PATCH v2] drm/msm/dp: check core_initialized before disable interrupts at dp_display_unbind()

2022-06-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-06-06 10:55:39) > During msm initialize phase, dp_display_unbind() will be called to undo > initializations had been done by dp_display_bind() previously if there is > error happen at msm_drm_bind. In this case, core_initialized flag had to > be check to make sure clocks

[Freedreno] [PATCH] drm/msm/dsi: Use single function for reset

2022-06-10 Thread Luca Weiss
From: Vladimir Lypak There is currently two function for performing reset: dsi_sw_reset and dsi_sw_reset_restore. Only difference betwean those is that latter one assumes that DSI controller is enabled. In contrary former one assumes that controller is disabled and executed during power-on. Howev

Re: [Freedreno] [PATCH] drm/msm: less magic numbers in msm_mdss_enable

2022-06-10 Thread Abhinav Kumar
On 6/8/2022 11:08 PM, Dmitry Baryshkov wrote: On Thu, 9 Jun 2022 at 02:37, Abhinav Kumar wrote: On 6/8/2022 3:46 PM, Dmitry Baryshkov wrote: On 09/06/2022 01:42, Abhinav Kumar wrote: On 6/8/2022 3:38 PM, Dmitry Baryshkov wrote: On 09/06/2022 01:35, Abhinav Kumar wrote: On 6/8/2022

[Freedreno] [PATCH 1/2] drm/msm/mdp5: Add perf data for MDP v1.16

2022-06-10 Thread Luca Weiss
From: Vladimir Lypak Add the perf data for the mdp found in msm8953. Signed-off-by: Vladimir Lypak Signed-off-by: Luca Weiss --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c b/drivers/gpu/drm/msm/di

Re: [Freedreno] [PATCH] drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf

2022-06-10 Thread Abhinav Kumar
On 6/7/2022 4:08 AM, Miaoqian Lin wrote: of_graph_get_remote_node() returns remote device node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 86418f90a4c1 ("drm: convert drivers to use of_gra

Re: [Freedreno] [PATCH 1/2] drm/msm/mdp5: Add perf data for MDP v1.16

2022-06-10 Thread Dmitry Baryshkov
On 11/06/2022 01:53, Luca Weiss wrote: From: Vladimir Lypak Add the perf data for the mdp found in msm8953. Signed-off-by: Vladimir Lypak Signed-off-by: Luca Weiss Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 5 + 1 file changed, 5 insertions(+) d

Re: [Freedreno] [PATCH] drm/msm/dsi: Use single function for reset

2022-06-10 Thread Abhinav Kumar
On 6/10/2022 3:02 PM, Luca Weiss wrote: From: Vladimir Lypak There is currently two function for performing reset: dsi_sw_reset and dsi_sw_reset_restore. Only difference betwean those is that latter one betwean --> between assumes that DSI controller is enabled. In contrary former one assu

[Freedreno] [PATCH 2/2] arm64: dts: qcom: msm8953: add MDSS

2022-06-10 Thread Luca Weiss
From: Vladimir Lypak Add the MDSS, MDP and DSI nodes that are found on msm8953 SoC. IOMMU is not added because support for it isn't yet upstream and MDSS works fine without IOMMU on 8953. Signed-off-by: Vladimir Lypak Signed-off-by: Luca Weiss --- arch/arm64/boot/dts/qcom/msm8953.dtsi | 202