[Freedreno] [PATCH] drm/msm/disp/dpu1: remove supoerflous init

2022-05-24 Thread Vinod Koul
Commit 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in encoder") added dsc_common_mode variable which was set to zero but then again programmed, so drop the supoerflous init. Fixes: 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in encoder") Reported-by: kernel test robot Signed-o

Re: [Freedreno] [PATCH] drm/msm/disp/dpu1: remove supoerflous init

2022-05-24 Thread Dmitry Baryshkov
On Tue, 24 May 2022 at 13:35, Vinod Koul wrote: > > Commit 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in > encoder") added dsc_common_mode variable which was set to zero but then > again programmed, so drop the supoerflous init. > > Fixes: 58dca9810749 ("drm/msm/disp/dpu1: Add support f

Re: [Freedreno] [PATCH] drm/msm/disp/dpu1: remove supoerflous init

2022-05-24 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Vinod Koul >Sent: Tuesday, May 24, 2022 6:36 AM >To: Dmitry Baryshkov >Cc: Liu, Yujie ; linux-arm-...@vger.kernel.org; Abhinav >Kumar ; dri-de...@lists.freedesktop.org; Bjorn >Andersson ; Vinod Koul ; >freedreno@lists.freedesktop.org >

Re: [Freedreno] [PATCH v4 12/13] drm/msm: Utilize gpu scheduler priorities

2022-05-24 Thread Tvrtko Ursulin
On 23/05/2022 23:53, Rob Clark wrote: On Mon, May 23, 2022 at 7:45 AM Tvrtko Ursulin wrote: Hi Rob, On 28/07/2021 02:06, Rob Clark wrote: From: Rob Clark The drm/scheduler provides additional prioritization on top of that provided by however many number of ringbuffers (each with their o

Re: [Freedreno] [PATCH v4 12/13] drm/msm: Utilize gpu scheduler priorities

2022-05-24 Thread Rob Clark
On Tue, May 24, 2022 at 6:45 AM Tvrtko Ursulin wrote: > > > On 23/05/2022 23:53, Rob Clark wrote: > > On Mon, May 23, 2022 at 7:45 AM Tvrtko Ursulin > > wrote: > >> > >> > >> Hi Rob, > >> > >> On 28/07/2021 02:06, Rob Clark wrote: > >>> From: Rob Clark > >>> > >>> The drm/scheduler provides addi

Re: [Freedreno] [PATCH v4 12/13] drm/msm: Utilize gpu scheduler priorities

2022-05-24 Thread Rob Clark
On Tue, May 24, 2022 at 6:45 AM Tvrtko Ursulin wrote: > > On 23/05/2022 23:53, Rob Clark wrote: > > > > btw, one fun (but unrelated) issue I'm hitting with scheduler... I'm > > trying to add an igt test to stress shrinker/eviction, similar to the > > existing tests/i915/gem_shrink.c. But we hit a

[Freedreno] [PATCH] drm/msm/dpu: Remove unused code

2022-05-24 Thread Jiapeng Chong
Eliminate the follow clang warning: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:544:33: warning: variable ‘mode’ set but not used [-Wunused-but-set-variable]. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 -- 1 file changed, 2 deletio

Re: [Freedreno] [PATCH] drm/msm/disp/dpu1: remove supoerflous init

2022-05-24 Thread Abhinav Kumar
On 5/24/2022 3:35 AM, Vinod Koul wrote: Commit 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in encoder") added dsc_common_mode variable which was set to zero but then again programmed, so drop the supoerflous init. Both in the subject line and here, typo supoerflous ---> superfluous

Re: [Freedreno] [PATCH 5/9] drm/msm/dsi_phy_28nm_8960: Replace parent names with clk_hw pointers

2022-05-24 Thread Marijn Suijten
On 2022-05-24 01:44:49, Dmitry Baryshkov wrote: > On Tue, 24 May 2022 at 01:44, Dmitry Baryshkov > wrote: > > > > On Tue, 24 May 2022 at 00:38, Marijn Suijten > > wrote: > > > > > > parent_hw pointers are easier to manage and cheaper to use than > > > repeatedly formatting the parent name and sub

Re: [Freedreno] [PATCH 0/9] drm/msm/dsi_phy: Replace parent names with clk_hw pointers

2022-05-24 Thread Marijn Suijten
On 2022-05-24 02:43:01, Dmitry Baryshkov wrote: > Hi, > > On Tue, 24 May 2022 at 00:38, Marijn Suijten > wrote: > > > > As stated in [1] I promised to tackle and send this series. > > > > parent_hw pointers are easier to manage and cheaper to use than > > repeatedly formatting the parent name and

Re: [Freedreno] [PATCH v11 1/3] phy: qcom-edp: add regulator_set_load to edp phy

2022-05-24 Thread Doug Anderson
Hi, On Fri, May 20, 2022 at 2:28 PM Kuogee Hsieh wrote: > > This patch add regulator_set_load() before enable regulator at > eDP phy driver. > > Signed-off-by: Kuogee Hsieh > --- > drivers/phy/qualcomm/phy-qcom-edp.c | 12 > 1 file changed, 12 insertions(+) Reviewed-by: Douglas An

Re: [Freedreno] [PATCH v11 2/3] phy: qcom-qmp: add regulator_set_load to dp phy

2022-05-24 Thread Doug Anderson
Hi, On Fri, May 20, 2022 at 2:27 PM Kuogee Hsieh wrote: > > This patch add regulator_set_load() before enable regulator at > DP phy driver. > > Signed-off-by: Kuogee Hsieh > Reviewed-by: Stephen Boyd > --- > drivers/phy/qualcomm/phy-qcom-qmp.c | 25 - > 1 file changed,

Re: [Freedreno] [PATCH v11 3/3] drm/msm/dp: delete vdda regulator related functions from eDP/DP controller

2022-05-24 Thread Doug Anderson
Hi, On Fri, May 20, 2022 at 2:27 PM Kuogee Hsieh wrote: > > @@ -101,11 +101,6 @@ struct dp_reg_entry { > int disable_load; > }; > > -struct dp_regulator_cfg { > - int num; > - struct dp_reg_entry regs[DP_DEV_REGULATOR_MAX]; You forgot to delete the #define of DP_DEV_REGULATO

Re: [Freedreno] [PATCH v4 12/13] drm/msm: Utilize gpu scheduler priorities

2022-05-24 Thread Rob Clark
On Tue, May 24, 2022 at 7:57 AM Rob Clark wrote: > > On Tue, May 24, 2022 at 6:45 AM Tvrtko Ursulin > wrote: > > > > On 23/05/2022 23:53, Rob Clark wrote: > > > > > > btw, one fun (but unrelated) issue I'm hitting with scheduler... I'm > > > trying to add an igt test to stress shrinker/eviction,