[Freedreno] [PATCH] drm/msm/adreno: Do not propagate void return values

With sparse ("make C=2"), lots of error: return expression in void function messages are seen. Fix this by removing the return statements to propagate void return values. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +- drivers/gpu/drm/msm/adreno/a6xx_gmu.

Re: [Freedreno] [PATCH] drm/msm/adreno: Do not propagate void return values

On 5/20/22 05:53, Geert Uytterhoeven wrote: With sparse ("make C=2"), lots of error: return expression in void function messages are seen. Fix this by removing the return statements to propagate void return values. Signed-off-by: Geert Uytterhoeven Reviewed-by: Guenter Roeck --- dr

Re: [Freedreno] [PATCH v6 1/3] phy: qcom-edp: add regulator_set_load to edp phy

On 5/19/2022 5:19 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-05-19 16:11:40) diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c index cacd32f..78b7306 100644 --- a/drivers/phy/qualcomm/phy-qcom-edp.c +++ b/drivers/phy/qualcomm/phy-qcom-edp.c @@ -87,

[Freedreno] [PATCH v7 0/3] eDP/DP Phy vdda realted function

1) add regulator_set_load() to eDP phy 2) add regulator_set_load() to DP phy 3) remove vdda related function out of eDP/DP controller Kuogee Hsieh (3): phy: qcom-edp: add regulator_set_load to edp phy phy: qcom-qmp: add regulator_set_load to dp phy drm/msm/dp: delete vdda regulator related f

[Freedreno] [PATCH v7 1/3] phy: qcom-edp: add regulator_set_load to edp phy

This patch add regulator_set_load() before enable regulator at eDP phy driver. Signed-off-by: Kuogee Hsieh --- drivers/phy/qualcomm/phy-qcom-edp.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-ed

[Freedreno] [PATCH v7 2/3] phy: qcom-qmp: add regulator_set_load to dp phy

This patch add regulator_set_load() before enable regulator at DP phy driver. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd --- drivers/phy/qualcomm/phy-qcom-qmp.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qu

[Freedreno] [PATCH v7 3/3] drm/msm/dp: delete vdda regulator related functions from eDP/DP controller

Vdda regulators are related to both eDP and DP phy so that it should be managed at eDP and DP phy driver instead of controller. This patch removes vdda regulators related functions out of eDP/DP controller. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Reviewed-by: Dmitry Baryshkov ---

Re: [Freedreno] [PATCH v6 1/3] phy: qcom-edp: add regulator_set_load to edp phy

On Fri, 20 May 2022 at 18:09, Kuogee Hsieh wrote: > > > On 5/19/2022 5:19 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2022-05-19 16:11:40) > >> diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c > >> b/drivers/phy/qualcomm/phy-qcom-edp.c > >> index cacd32f..78b7306 100644 > >> --- a/drivers/p

Re: [Freedreno] [PATCH v7 1/3] phy: qcom-edp: add regulator_set_load to edp phy

On Fri, 20 May 2022 at 18:21, Kuogee Hsieh wrote: > > This patch add regulator_set_load() before enable regulator at > eDP phy driver. > > Signed-off-by: Kuogee Hsieh > --- > drivers/phy/qualcomm/phy-qcom-edp.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/dr

[Freedreno] [PATCH v8 1/3] phy: qcom-edp: add regulator_set_load to edp phy

This patch add regulator_set_load() before enable regulator at eDP phy driver. Signed-off-by: Kuogee Hsieh --- drivers/phy/qualcomm/phy-qcom-edp.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c index cacd32f..

[Freedreno] [PATCH v8 2/3] phy: qcom-qmp: add regulator_set_load to dp phy

This patch add regulator_set_load() before enable regulator at DP phy driver. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd --- drivers/phy/qualcomm/phy-qcom-qmp.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qu

[Freedreno] [PATCH v8 3/3] drm/msm/dp: delete vdda regulator related functions from eDP/DP controller

Vdda regulators are related to both eDP and DP phy so that it should be managed at eDP and DP phy driver instead of controller. This patch removes vdda regulators related functions out of eDP/DP controller. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Reviewed-by: Dmitry Baryshkov ---

[Freedreno] [PATCH v8 0/3] eDP/DP Phy vdda realted function

1) add regulator_set_load() to eDP phy 2) add regulator_set_load() to DP phy 3) remove vdda related function out of eDP/DP controller Kuogee Hsieh (3): phy: qcom-edp: add regulator_set_load to edp phy phy: qcom-qmp: add regulator_set_load to dp phy drm/msm/dp: delete vdda regulator related f

Re: [Freedreno] [PATCH v8 1/3] phy: qcom-edp: add regulator_set_load to edp phy

On Fri 20 May 09:26 PDT 2022, Kuogee Hsieh wrote: > This patch add regulator_set_load() before enable regulator at > eDP phy driver. > > Signed-off-by: Kuogee Hsieh > --- > drivers/phy/qualcomm/phy-qcom-edp.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/phy/qualcomm/

[Freedreno] [PATCH v9 0/3] eDP/DP Phy vdda realted function

1) add regulator_set_load() to eDP phy 2) add regulator_set_load() to DP phy 3) remove vdda related function out of eDP/DP controller Kuogee Hsieh (3): phy: qcom-edp: add regulator_set_load to edp phy phy: qcom-qmp: add regulator_set_load to dp phy drm/msm/dp: delete vdda regulator related f

[Freedreno] [PATCH v9 1/3] phy: qcom-edp: add regulator_set_load to edp phy

This patch add regulator_set_load() before enable regulator at eDP phy driver. Signed-off-by: Kuogee Hsieh --- drivers/phy/qualcomm/phy-qcom-edp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c index cacd32f..0b7f

[Freedreno] [PATCH v9 2/3] phy: qcom-qmp: add regulator_set_load to dp phy

This patch add regulator_set_load() before enable regulator at DP phy driver. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd --- drivers/phy/qualcomm/phy-qcom-qmp.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c

[Freedreno] [PATCH v9 3/3] drm/msm/dp: delete vdda regulator related functions from eDP/DP controller

Vdda regulators are related to both eDP and DP phy so that it should be managed at eDP and DP phy driver instead of controller. This patch removes vdda regulators related functions out of eDP/DP controller. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Reviewed-by: Dmitry Baryshkov ---

Re: [Freedreno] [PATCH v7] drm/msm/dp: Always clear mask bits to disable interrupts at dp_ctrl_reset_irq_ctrl()

Quoting Kuogee Hsieh (2022-05-17 09:21:34) > dp_catalog_ctrl_reset() will software reset DP controller. But it will > not reset programmable registers to default value. DP driver still have > to clear mask bits to interrupt status registers to disable interrupts > after software reset of controller

Re: [Freedreno] [PATCH v9 1/3] phy: qcom-edp: add regulator_set_load to edp phy

Quoting Kuogee Hsieh (2022-05-20 13:06:05) > This patch add regulator_set_load() before enable regulator at > eDP phy driver. > > Signed-off-by: Kuogee Hsieh > --- > drivers/phy/qualcomm/phy-qcom-edp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c

Re: [Freedreno] [PATCH v3 1/4] drm/dp: Export symbol / kerneldoc fixes for DP AUX bus

Hi, On Tue, May 10, 2022 at 12:30 PM Douglas Anderson wrote: > > While working on the DP AUX bus code I found a few small things that > should be fixed. Namely the non-devm version of > of_dp_aux_populate_ep_devices() was missing an export. There was also > an extra blank line in a kerneldoc and

Re: [Freedreno] [PATCH v3 3/4] drm/bridge: Add devm_drm_bridge_add()

Hi, On Tue, May 10, 2022 at 5:22 PM Dmitry Baryshkov wrote: > > On Tue, 10 May 2022 at 22:30, Douglas Anderson wrote: > > > > This adds a devm managed version of drm_bridge_add(). Like other > > "devm" function listed in drm_bridge.h, this function takes an > > explicit "dev" to use for the life

[Freedreno] [PATCH v10 0/3] eDP/DP Phy vdda realted function

1) add regulator_set_load() to eDP phy 2) add regulator_set_load() to DP phy 3) remove vdda related function out of eDP/DP controller Kuogee Hsieh (3): phy: qcom-edp: add regulator_set_load to edp phy phy: qcom-qmp: add regulator_set_load to dp phy drm/msm/dp: delete vdda regulator related

[Freedreno] [PATCH v10 1/3] phy: qcom-edp: add regulator_set_load to edp phy

This patch add regulator_set_load() before enable regulator at eDP phy driver. Signed-off-by: Kuogee Hsieh --- drivers/phy/qualcomm/phy-qcom-edp.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c index ca

[Freedreno] [PATCH v10 3/3] drm/msm/dp: delete vdda regulator related functions from eDP/DP controller

Vdda regulators are related to both eDP and DP phy so that it should be managed at eDP and DP phy driver instead of controller. This patch removes vdda regulators related functions out of eDP/DP controller. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Reviewed-by: Dmitry Baryshkov ---

[Freedreno] [PATCH v10 2/3] phy: qcom-qmp: add regulator_set_load to dp phy

This patch add regulator_set_load() before enable regulator at DP phy driver. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd --- drivers/phy/qualcomm/phy-qcom-qmp.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/drivers/phy/qualcomm/phy-qcom-

Re: [Freedreno] [PATCH v10 1/3] phy: qcom-edp: add regulator_set_load to edp phy

Quoting Kuogee Hsieh (2022-05-20 13:40:55) > This patch add regulator_set_load() before enable regulator at > eDP phy driver. > > Signed-off-by: Kuogee Hsieh > --- > drivers/phy/qualcomm/phy-qcom-edp.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/drivers/phy/qualcomm/phy

[Freedreno] [PATCH v11 0/3] eDP/DP Phy vdda realted function

1) add regulator_set_load() to eDP phy 2) add regulator_set_load() to DP phy 3) remove vdda related function out of eDP/DP controller Kuogee Hsieh (3): phy: qcom-edp: add regulator_set_load to edp phy phy: qcom-qmp: add regulator_set_load to dp phy drm/msm/dp: delete vdda regulator related f

[Freedreno] [PATCH v11 3/3] drm/msm/dp: delete vdda regulator related functions from eDP/DP controller

Vdda regulators are related to both eDP and DP phy so that it should be managed at eDP and DP phy driver instead of controller. This patch removes vdda regulators related functions out of eDP/DP controller. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Reviewed-by: Dmitry Baryshkov ---

[Freedreno] [PATCH v11 2/3] phy: qcom-qmp: add regulator_set_load to dp phy

This patch add regulator_set_load() before enable regulator at DP phy driver. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd --- drivers/phy/qualcomm/phy-qcom-qmp.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/drivers/phy/qualcomm/phy-qcom

[Freedreno] [PATCH v11 1/3] phy: qcom-edp: add regulator_set_load to edp phy

This patch add regulator_set_load() before enable regulator at eDP phy driver. Signed-off-by: Kuogee Hsieh --- drivers/phy/qualcomm/phy-qcom-edp.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c index ca

Re: [Freedreno] [PATCH v3] drm/probe-helper: Make 640x480 first if no EDID

Hi, On Mon, May 16, 2022 at 3:28 AM Thomas Zimmermann wrote: > > Hi Douglas, > > I understand that you're trying to tell userspace that the modelist has > been made up, but it's not something that should be done via fragile > heuristics IMHO. > > I looked at the Chromium source code that you link