[Freedreno] [GIT PULL] drm/msm: drm-msm-fixes-2022-05-19

2022-05-19 Thread Abhinav Kumar
Hi Rob Here is the pull request for the fixes for 5.19. Just a few more changes on top of msm-fixes-staging. Mainly it has the foll fixes: - Limiting WB modes to max sspp linewidth - Fixing the supported rotations to add 180 back for IGT - Fix to handle pm_runtime_get_sync() errors to avoid un

[Freedreno] [PATCH v5 0/3] eDP/DP Phy vdda realted function

2022-05-19 Thread Kuogee Hsieh
1) add regulator_set_load() to eDP phy 2) add regulator_set_load() to DP phy 3) remove vdda related function out of eDP/DP controller Kuogee Hsieh (3): phy: qcom-edp: add regulator_set_load to edp phy phy: qcom-qmp: add regulator_set_load to dp phy drm/msm/dp: delete vdda regulator related f

[Freedreno] [PATCH v5 1/3] phy: qcom-edp: add regulator_set_load to edp phy

2022-05-19 Thread Kuogee Hsieh
This patch add regulator_set_load() before enable regulator at eDP phy driver. Signed-off-by: Kuogee Hsieh --- drivers/phy/qualcomm/phy-qcom-edp.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.

[Freedreno] [PATCH v5 2/3] phy: qcom-qmp: add regulator_set_load to dp phy

2022-05-19 Thread Kuogee Hsieh
This patch add regulator_set_load() before enable regulator at DP phy driver. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd --- drivers/phy/qualcomm/phy-qcom-qmp.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qu

[Freedreno] [PATCH v5 3/3] drm/msm/dp: delete vdda regulator related functions from eDP/DP controller

2022-05-19 Thread Kuogee Hsieh
Vdda regulators are related to both eDP and DP phy so that it should be managed at eDP and DP phy driver instead of controller. This patch removes vdda regulators related functions out of eDP/DP controller. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Reviewed-by: Dmitry Baryshkov ---

Re: [Freedreno] [PATCH v7] drm/msm/dp: Always clear mask bits to disable interrupts at dp_ctrl_reset_irq_ctrl()

2022-05-19 Thread Kuogee Hsieh
On 5/17/2022 9:21 AM, Kuogee Hsieh wrote: Is anyone has comments on this patch? dp_catalog_ctrl_reset() will software reset DP controller. But it will not reset programmable registers to default value. DP driver still have to clear mask bits to interrupt status registers to disable interrupts

Re: [Freedreno] [PATCH v5 2/3] phy: qcom-qmp: add regulator_set_load to dp phy

2022-05-19 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-05-19 10:45:38) > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c > b/drivers/phy/qualcomm/phy-qcom-qmp.c > index b144ae1..24f39ee 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c > @@ -5008,6 +5019,11 @@ static int qcom_qmp

Re: [Freedreno] [PATCH v5 1/3] phy: qcom-edp: add regulator_set_load to edp phy

2022-05-19 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-05-19 10:45:37) > diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c > b/drivers/phy/qualcomm/phy-qcom-edp.c > index cacd32f..90093cd 100644 > --- a/drivers/phy/qualcomm/phy-qcom-edp.c > +++ b/drivers/phy/qualcomm/phy-qcom-edp.c > @@ -87,14 +87,19 @@ struct qcom_edp { > >

[Freedreno] [PATCH v6 0/3] eDP/DP Phy vdda realted function

2022-05-19 Thread Kuogee Hsieh
1) add regulator_set_load() to eDP phy 2) add regulator_set_load() to DP phy 3) remove vdda related function out of eDP/DP controller Kuogee Hsieh (3): phy: qcom-edp: add regulator_set_load to edp phy phy: qcom-qmp: add regulator_set_load to dp phy drm/msm/dp: delete vdda regulator related f

[Freedreno] [PATCH v6 1/3] phy: qcom-edp: add regulator_set_load to edp phy

2022-05-19 Thread Kuogee Hsieh
This patch add regulator_set_load() before enable regulator at eDP phy driver. Signed-off-by: Kuogee Hsieh --- drivers/phy/qualcomm/phy-qcom-edp.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.

[Freedreno] [PATCH v6 2/3] phy: qcom-qmp: add regulator_set_load to dp phy

2022-05-19 Thread Kuogee Hsieh
This patch add regulator_set_load() before enable regulator at DP phy driver. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd --- drivers/phy/qualcomm/phy-qcom-qmp.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qu

[Freedreno] [PATCH v6 3/3] drm/msm/dp: delete vdda regulator related functions from eDP/DP controller

2022-05-19 Thread Kuogee Hsieh
Vdda regulators are related to both eDP and DP phy so that it should be managed at eDP and DP phy driver instead of controller. This patch removes vdda regulators related functions out of eDP/DP controller. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Reviewed-by: Dmitry Baryshkov ---

Re: [Freedreno] [PATCH v6 1/3] phy: qcom-edp: add regulator_set_load to edp phy

2022-05-19 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-05-19 16:11:40) > diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c > b/drivers/phy/qualcomm/phy-qcom-edp.c > index cacd32f..78b7306 100644 > --- a/drivers/phy/qualcomm/phy-qcom-edp.c > +++ b/drivers/phy/qualcomm/phy-qcom-edp.c > @@ -87,14 +87,19 @@ struct qcom_edp { > >

Re: [Freedreno] [PATCH v3 1/2] drm/probe-helper: Add helper for drm_helper_probe_single_connector_modes()

2022-05-19 Thread Doug Anderson
Hi, On Wed, May 11, 2022 at 3:58 PM Douglas Anderson wrote: > > The drm_helper_probe_single_connector_modes() is a bit long. Let's > break a chunk off to update and validate modes. This helps avoid one > goto and also will allow us to more easily call the helper a second > time in a future patch

Re: [Freedreno] [PATCH v3 2/2] drm/probe-helper: For DP, add 640x480 if all other modes are bad

2022-05-19 Thread Doug Anderson
Hi, On Wed, May 11, 2022 at 3:58 PM Douglas Anderson wrote: > > As per Displayport spec section 5.2.1.2 ("Video Timing Format") says > that all detachable sinks shall support 640x480 @60Hz as a fail safe > mode. > > A DP compliance test expected us to utilize the above fact when all > modes it pr

Re: [Freedreno] [PATCH v2] drm: Document the power requirements for DP AUX transfers

2022-05-19 Thread Doug Anderson
Hi, On Mon, May 9, 2022 at 4:18 PM Douglas Anderson wrote: > > When doing DP AUX transfers there are two actors that need to be > powered in order for the DP AUX transfer to work: the DP source and > the DP sink. Commit bacbab58f09d ("drm: Mention the power state > requirement on side-channel ope