Re: [Freedreno] [PATCH 3/3] drm/msm: Add a way to override processes comm/cmdline

2022-03-18 Thread Dan Carpenter
On Thu, Mar 17, 2022 at 08:03:59AM -0700, Rob Clark wrote: > > > diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c > > > index 4ec62b601adc..68f3f8ade76d 100644 > > > --- a/drivers/gpu/drm/msm/msm_gpu.c > > > +++ b/drivers/gpu/drm/msm/msm_gpu.c > > > @@ -364,14 +364,21 @@ s

Re: [Freedreno] [PATCH 3/3] drm/msm: Add a way to override processes comm/cmdline

2022-03-18 Thread Rob Clark
On Fri, Mar 18, 2022 at 12:19 AM Dan Carpenter wrote: > > On Thu, Mar 17, 2022 at 08:03:59AM -0700, Rob Clark wrote: > > > > diff --git a/drivers/gpu/drm/msm/msm_gpu.c > > > > b/drivers/gpu/drm/msm/msm_gpu.c > > > > index 4ec62b601adc..68f3f8ade76d 100644 > > > > --- a/drivers/gpu/drm/msm/msm_gpu

Re: [Freedreno] [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-18 Thread Rob Clark
On Fri, Mar 18, 2022 at 9:04 AM Andrey Grodzovsky wrote: > > > On 2022-03-17 16:35, Rob Clark wrote: > > On Thu, Mar 17, 2022 at 12:50 PM Andrey Grodzovsky > > wrote: > >> > >> On 2022-03-17 14:25, Rob Clark wrote: > >>> On Thu, Mar 17, 2022 at 11:10 AM Andrey Grodzovsky > >>> wrote: > On 2

Re: [Freedreno] [PATCH v5 6/9] drm/msm/dp: wait for hpd high before any sink interaction

2022-03-18 Thread Doug Anderson
Hi, On Thu, Mar 17, 2022 at 6:19 PM Stephen Boyd wrote: > > Quoting Sankeerth Billakanti (2022-03-16 10:35:51) > > The source device should ensure the sink is ready before > > proceeding to read the sink capability or performing any aux transactions. > > The sink will indicate its readine

Re: [Freedreno] [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-18 Thread Rob Clark
On Fri, Mar 18, 2022 at 9:27 AM Andrey Grodzovsky wrote: > > > On 2022-03-18 12:20, Rob Clark wrote: > > On Fri, Mar 18, 2022 at 9:04 AM Andrey Grodzovsky > > wrote: > >> > >> On 2022-03-17 16:35, Rob Clark wrote: > >>> On Thu, Mar 17, 2022 at 12:50 PM Andrey Grodzovsky > >>> wrote: > On 20

Re: [Freedreno] [PATCH v5 2/9] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-03-18 Thread Doug Anderson
Hi, On Wed, Mar 16, 2022 at 10:36 AM Sankeerth Billakanti wrote: > > Enable support for eDP interface via aux_bus on CRD platform. > > Signed-off-by: Sankeerth Billakanti > --- > > Changes in v5: > - Change the order of patches > - Remove the backlight nodes > - Remove the bias setting >

Re: [Freedreno] [PATCH v5 6/9] drm/msm/dp: wait for hpd high before any sink interaction

2022-03-18 Thread Stephen Boyd
Quoting Doug Anderson (2022-03-18 09:24:17) > Hi, > > On Thu, Mar 17, 2022 at 6:19 PM Stephen Boyd wrote: > > > > Quoting Sankeerth Billakanti (2022-03-16 10:35:51) > > > The source device should ensure the sink is ready before > > > proceeding to read the sink capability or performing any

Re: [Freedreno] [PATCH v5 6/9] drm/msm/dp: wait for hpd high before any sink interaction

2022-03-18 Thread Doug Anderson
Hi, On Fri, Mar 18, 2022 at 1:17 PM Stephen Boyd wrote: > > > > > + ret = dp_catalog_aux_wait_for_hpd_connect_state(aux->catalog); > > > > > > Why are we making aux transactions when hpd isn't asserted? Can we only > > > register the aux device once we know that state is "connected"? I'm >

Re: [Freedreno] [PATCH v5 6/9] drm/msm/dp: wait for hpd high before any sink interaction

2022-03-18 Thread Stephen Boyd
Quoting Doug Anderson (2022-03-18 14:58:55) > Hi, > > On Fri, Mar 18, 2022 at 1:17 PM Stephen Boyd wrote: > > > > > > > + ret = dp_catalog_aux_wait_for_hpd_connect_state(aux->catalog); > > > > > > > > Why are we making aux transactions when hpd isn't asserted? Can we only > > > > register th

Re: [Freedreno] [PATCH v5 6/9] drm/msm/dp: wait for hpd high before any sink interaction

2022-03-18 Thread Doug Anderson
Hi, On Fri, Mar 18, 2022 at 4:27 PM Stephen Boyd wrote: > > > > Pushing hpd state checking into aux > > > transactions looks like the wrong direction. Also, as I said up above I > > > am concerned that even checking the GPIO won't work and we need some way > > > to ask the bridge if HPD is assert