Re: [Freedreno] [PATCH v2 1/2] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent

2021-09-02 Thread AngeloGioacchino Del Regno
Il 30/08/21 20:24, Marijn Suijten ha scritto: All DSI PHY/PLL drivers were referencing their VCO parent clock by a global name, most of which don't exist or have been renamed. These clock drivers seem to function fine without that except the 14nm driver for the sdm6xx [1]. At the same time all

Re: [Freedreno] [PATCH v2 2/2] clk: qcom: gcc-sdm660: Remove transient global "xo" clock

2021-09-02 Thread AngeloGioacchino Del Regno
Il 30/08/21 20:24, Marijn Suijten ha scritto: The DSI PHY/PLL was relying on a global "xo" clock to be found, but the real clock is named "xo_board" in the DT. The standard nowadays is to never use global clock names anymore but require the firmware (DT) to provide every clock binding explicitly

Re: [Freedreno] [PATCH v2 2/2] clk: qcom: gcc-sdm660: Remove transient global "xo" clock

2021-09-02 Thread Marijn Suijten
On 2021-09-01 20:46:34, Stephen Boyd wrote: > Quoting Marijn Suijten (2021-09-01 01:57:15) > > On 2021-08-31 22:35:56, Stephen Boyd wrote: > > > Quoting Marijn Suijten (2021-08-30 11:24:45) > > > > The DSI PHY/PLL was relying on a global "xo" clock to be found, but the > > > > real clock is named "

[Freedreno] [PATCH 2/2] drm/msm/mdp5: Add configuration for MDP v1.16

2021-09-02 Thread Sireesh Kodali
From: Vladimir Lypak MDP version v1.16 is almost identical to v1.15 with most significant difference being presence of second DSI interface. MDP v1.16 is found on SoCs such as MSM8x53, SDM450, SDM632 (All with Adreno 506). Signed-off-by: Vladimir Lypak Signed-off-by: Sireesh Kodali --- driver

[Freedreno] [PATCH 1/2] drm/msm/dsi: Add phy configuration for MSM8953

2021-09-02 Thread Sireesh Kodali
From: Vladimir Lypak Add phy configuration for 14nm dsi phy found on MSM8953 SoC. Only difference from existing configurations are io_start addresses. Signed-off-by: Vladimir Lypak Signed-off-by: Sireesh Kodali --- .../bindings/display/msm/dsi-phy-14nm.yaml| 1 + drivers/gpu/drm/msm/dsi/

Re: [Freedreno] [PATCH] drm/msm: remove unneeded variable

2021-09-02 Thread Lyude Paul
Reviewed-by: Lyude Paul Do you need me to push this? On Tue, 2021-08-31 at 04:51 -0700, cgel@gmail.com wrote: > From: Chi Minghao > > Fix the following coccicheck REVIEW: > ./drivers/gpu/drm/msm/edp/edp_ctrl.c:1245:5-8 Unneeded variable > > Reported-by: Zeal Robot > Signed-off-by: Chi Mi

Re: [Freedreno] [PATCH v2 2/2] clk: qcom: gcc-sdm660: Remove transient global "xo" clock

2021-09-02 Thread Stephen Boyd
Quoting Marijn Suijten (2021-09-02 06:05:34) > On 2021-09-01 20:46:34, Stephen Boyd wrote: > > Quoting Marijn Suijten (2021-09-01 01:57:15) > > > On 2021-08-31 22:35:56, Stephen Boyd wrote: > > > > Quoting Marijn Suijten (2021-08-30 11:24:45) > > > > > The DSI PHY/PLL was relying on a global "xo" c

Re: [Freedreno] [PATCH 1/2] drm/msm/dsi: Add phy configuration for MSM8953

2021-09-02 Thread Dmitry Baryshkov
On 02/09/2021 18:59, Sireesh Kodali wrote: From: Vladimir Lypak Add phy configuration for 14nm dsi phy found on MSM8953 SoC. Only difference from existing configurations are io_start addresses. Signed-off-by: Vladimir Lypak Signed-off-by: Sireesh Kodali --- .../bindings/display/msm/dsi-phy

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu1: Add DMA2, DMA3 clock control to enum

2021-09-02 Thread Dmitry Baryshkov
On 01/09/2021 21:11, AngeloGioacchino Del Regno wrote: The enum dpu_clk_ctrl_type misses DPU_CLK_CTRL_DMA{2,3} even though this driver does actually handle both, if present: add the two in preparation for adding support for SoCs having them. Signed-off-by: AngeloGioacchino Del Regno Reviewed

Re: [Freedreno] [PATCH 2/3] drm/msm/dpu1: Add MSM8998 to hw catalog

2021-09-02 Thread Dmitry Baryshkov
On 01/09/2021 21:11, AngeloGioacchino Del Regno wrote: Bringup functionality for MSM8998 in the DPU, driver which is mostly the same as SDM845 (just a few variations). Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c