Re: [Freedreno] [v8 1/6] drm/panel: add basic DP AUX backlight support

2021-07-12 Thread Thomas Zimmermann
Am 26.06.21 um 18:51 schrieb Rajeev Nandan: Some panels support backlight control over DP AUX channel using VESA's standard backlight control interface. Using new DRM eDP backlight helpers, add support to create and register a backlight for those panels in drm_panel to simplify the panel driver

Re: [Freedreno] [v8 1/6] drm/panel: add basic DP AUX backlight support

2021-07-12 Thread Thomas Zimmermann
Hi Am 12.07.21 um 11:41 schrieb Thomas Zimmermann: Am 26.06.21 um 18:51 schrieb Rajeev Nandan: Some panels support backlight control over DP AUX channel using VESA's standard backlight control interface. Using new DRM eDP backlight helpers, add support to create and register a backlight for t

Re: [Freedreno] [v8 1/6] drm/panel: add basic DP AUX backlight support

2021-07-12 Thread Doug Anderson
Hi, On Mon, Jul 12, 2021 at 2:41 AM Thomas Zimmermann wrote: > > > + ret = drm_dp_dpcd_read(aux, DP_EDP_DPCD_REV, edp_dpcd, > > +EDP_DISPLAY_CTL_CAP_SIZE); > > This creates a cyclic dependency between drm_kms_helper-ko and drm.ko. > drm_panel.c is in the latter, wh

Re: [Freedreno] [v8 1/6] drm/panel: add basic DP AUX backlight support

2021-07-12 Thread Doug Anderson
Hi, On Mon, Jul 12, 2021 at 6:39 AM Doug Anderson wrote: > > Hi, > > On Mon, Jul 12, 2021 at 2:41 AM Thomas Zimmermann wrote: > > > > > + ret = drm_dp_dpcd_read(aux, DP_EDP_DPCD_REV, edp_dpcd, > > > +EDP_DISPLAY_CTL_CAP_SIZE); > > > > This creates a cyclic depende

[Freedreno] [PATCH v4 14/18] drm/msm: Don't break exclusive fence ordering

2021-07-12 Thread Daniel Vetter
There's only one exclusive slot, and we must not break the ordering. Adding a new exclusive fence drops all previous fences from the dma_resv. To avoid violating the signalling order we err on the side of over-synchronizing by waiting for the existing fences, even if userspace asked us to ignore t

Re: [Freedreno] [PATCH v3 1/7] drm/msm/dsi: rename dual DSI to bonded DSI

2021-07-12 Thread abhinavk
On 2021-07-10 15:19, Dmitry Baryshkov wrote: We are preparing to support two independent DSI hosts in the DSI/DPU code. To remove possible confusion (as both configurations can be referenced as dual DSI) let's rename old "dual DSI" (two DSI hosts driving single device, with clocks being locked) t

Re: [Freedreno] [PATCH v3 2/7] drm/msm/dsi: add three helper functions

2021-07-12 Thread abhinavk
On 2021-07-10 15:20, Dmitry Baryshkov wrote: Add three helper functions to be used by display drivers for setting up encoders. Signed-off-by: Dmitry Baryshkov I think there is a kbot error in this patch, with that fixed Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi.c |

Re: [Freedreno] [PATCH v3 3/7] drm/msm/dpu: support setting up two independent DSI connectors

2021-07-12 Thread abhinavk
On 2021-07-10 15:20, Dmitry Baryshkov wrote: Move setting up encoders from set_encoder_mode to _dpu_kms_initialize_dsi() / _dpu_kms_initialize_displayport(). This allows us to support not only "single DSI" and "bonded DSI" but also "two independent DSI" configurations. In future this would also