[Freedreno] [v4 0/4] drm: Support basic DPCD backlight in panel-simple and add a new panel ATNA33XC20

2021-05-25 Thread Rajeev Nandan
This series adds the support for the eDP panel that needs the backlight controlling over the DP AUX channel using DPCD registers of the panel as per the VESA's standard. This series also adds support for the Samsung eDP AMOLED panel that needs DP AUX to control the backlight, and introduces new de

[Freedreno] [v4 3/4] dt-bindings: display: simple: Add Samsung ATNA33XC20

2021-05-25 Thread Rajeev Nandan
Add Samsung 13.3" FHD eDP AMOLED panel. Signed-off-by: Rajeev Nandan --- Changes in v4: - New Documentation/devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentati

[Freedreno] [v4 2/4] drm/panel-simple: Support for delays between GPIO & regulator

2021-05-25 Thread Rajeev Nandan
Some panels datasheets may specify a delay between the enable GPIO and the regulator. Support this in panel-simple. Signed-off-by: Rajeev Nandan --- Changes in v4: - New drivers/gpu/drm/panel/panel-simple.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/gp

[Freedreno] [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

2021-05-25 Thread Rajeev Nandan
Add basic support of panel backlight control over eDP aux channel using VESA's standard backlight control interface. Signed-off-by: Rajeev Nandan --- This patch depends on [1] (drm/panel: panel-simple: Stash DP AUX bus; allow using it for DDC) Changes in v4: - New [1] https://lore.kernel.or

[Freedreno] [v4 4/4] drm/panel-simple: Add Samsung ATNA33XC20

2021-05-25 Thread Rajeev Nandan
Add Samsung 13.3" FHD eDP AMOLED panel. Signed-off-by: Rajeev Nandan --- Changes in v4: - New drivers/gpu/drm/panel/panel-simple.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.

Re: [Freedreno] [v3 1/2] dt-bindings: backlight: add DisplayPort aux backlight

2021-05-25 Thread rajeevny
Hi, On 18-05-2021 01:51, Doug Anderson wrote: Hi, On Tue, May 11, 2021 at 4:17 PM Doug Anderson wrote: Hi, On Tue, May 11, 2021 at 11:12 AM wrote: > > On 01-05-2021 03:08, Doug Anderson wrote: > > Hi, > > > > On Fri, Apr 30, 2021 at 8:10 AM wrote: > >> > >> On 30-04-2021 02:33, Doug Ande

[Freedreno] [PATCH] drm/msm/disp/dpu1/dpu_encoder: Drop unnecessary NULL checks after container_of

2021-05-25 Thread Guenter Roeck
The result of container_of() operations is never NULL unless the embedded element is the first element of the structure. This is not the case here. The NULL checks on the result of container_of() are therefore unnecessary and misleading. Remove them. This change was made automatically with the fol

Re: [Freedreno] [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

2021-05-25 Thread kernel test robot
Hi Rajeev, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [also build test ERROR on next-20210525] [cannot apply to robh/for-next drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.13-rc3

[Freedreno] [PATCH 1/7] drm/msm/mdp5: use drm atomic helpers to handle base drm plane state

2021-05-25 Thread Dmitry Baryshkov
Use generic helpers code to manage drm_plane_state part of mdp5_plane state instead of manually coding all the details. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/d

[Freedreno] [PATCH 0/7] drm/msm/mdp5: add properties and bandwidth management

2021-05-25 Thread Dmitry Baryshkov
Update MDP5 display driver to support current implementation of alpha/blend mode/zpos properties. On top of that port bandwidth management from DPU display driver. The following changes since commit 8dbde399044b0f5acf704ab5f8116bd8b1dfcf95: drm/msm/dp: handle irq_hpd with sink_count = 0 correct

[Freedreno] [PATCH 2/7] drm/msm/mdp5: use drm_plane_state for storing alpha value

2021-05-25 Thread Dmitry Baryshkov
Use drm_plane_state's 'alpha' field rather than adding extra 'alpha' field to mdp5_plane_state. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 4 ++-- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.h | 1 - drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 3 +-- 3 files c

[Freedreno] [PATCH 3/7] drm/msm/mdp5: use drm_plane_state for pixel blend mode

2021-05-25 Thread Dmitry Baryshkov
Use drm_plane_state's 'pixel_blend_mode' field rather than using 'premultiplied' field to mdp5_plane_state. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 6 -- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.h | 1 - drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 5

[Freedreno] [PATCH 4/7] drm/msm/mdp5: add support for alpha/blend_mode properties

2021-05-25 Thread Dmitry Baryshkov
Hook alpha and pixel blend mode support to be exported as proper DRM plane properties. This allows using this functionality from the userspace. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/

[Freedreno] [PATCH 6/7] drm/msm/mdp5: add perf blocks for holding fudge factors

2021-05-25 Thread Dmitry Baryshkov
From: James Willcox Prior downstream kernels had "fudge factors" in devicetree which would be applied to things like interconnect bandwidth calculations. Bring some of those values back here. Signed-off-by: James Willcox [DB: changed _ff to _inefficiency, fixed patch description] Signed-off-by:

[Freedreno] [PATCH 7/7] drm/msm/mdp5: provide dynamic bandwidth management

2021-05-25 Thread Dmitry Baryshkov
Instead of using static bandwidth setup, manage bandwidth dynamically, depending on the amount of allocated planes, their format and resolution. Co-developed-with: James Willcox Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 44 drivers/gpu/drm/msm/di

[Freedreno] [PATCH 5/7] drm/msm/mdp5: switch to standard zpos property

2021-05-25 Thread Dmitry Baryshkov
Instead of implemeting zpos property on our own, use standard zpos property support. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 2 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.h | 3 - drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 114 ++---

[Freedreno] [PATCH] drm/msm/dp: remove the repeated declaration

2021-05-25 Thread Shaokun Zhang
Function 'dp_catalog_audio_enable' is declared twice, remove the repeated declaration. Cc: Rob Clark Cc: Abhinav Kumar Signed-off-by: Shaokun Zhang --- drivers/gpu/drm/msm/dp/dp_catalog.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.h b/drivers/gpu/drm/

Re: [Freedreno] [PATCH] drm/msm/dp: remove the repeated declaration

2021-05-25 Thread Bjorn Andersson
On Tue 25 May 07:22 CDT 2021, Shaokun Zhang wrote: > Function 'dp_catalog_audio_enable' is declared twice, remove the > repeated declaration. > > Cc: Rob Clark > Cc: Abhinav Kumar Reviewed-by: Bjorn Andersson > Signed-off-by: Shaokun Zhang > --- > drivers/gpu/drm/msm/dp/dp_catalog.h | 1 -

Re: [Freedreno] [PATCH] drm/msm/disp/dpu1/dpu_encoder: Drop unnecessary NULL checks after container_of

2021-05-25 Thread Bjorn Andersson
On Tue 25 May 06:29 CDT 2021, Guenter Roeck wrote: > The result of container_of() operations is never NULL unless the embedded > element is the first element of the structure. This is not the case here. > The NULL checks on the result of container_of() are therefore unnecessary > and misleading. R

Re: [Freedreno] [PATCH 1/2] iommu/arm-smmu-qcom: Skip the TTBR1 quirk for db820c.

2021-05-25 Thread Bjorn Andersson
On Tue 30 Mar 10:31 CDT 2021, Will Deacon wrote: > On Tue, Mar 30, 2021 at 08:03:36AM -0700, Rob Clark wrote: > > On Tue, Mar 30, 2021 at 2:34 AM Will Deacon wrote: > > > > > > On Mon, Mar 29, 2021 at 09:02:50PM -0700, Rob Clark wrote: > > > > On Mon, Mar 29, 2021 at 7:47 AM Will Deacon wrote: >

Re: [Freedreno] [PATCH 7/7] drm/msm/mdp5: provide dynamic bandwidth management

2021-05-25 Thread kernel test robot
Hi Dmitry, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.13-rc3 next-20210525] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

Re: [Freedreno] [v4 2/4] drm/panel-simple: Support for delays between GPIO & regulator

2021-05-25 Thread Doug Anderson
Hi, On Tue, May 25, 2021 at 12:31 AM Rajeev Nandan wrote: > > Some panels datasheets may specify a delay between the enable GPIO and > the regulator. Support this in panel-simple. > > Signed-off-by: Rajeev Nandan > --- > > Changes in v4: > - New > > drivers/gpu/drm/panel/panel-simple.c | 23 +++

Re: [Freedreno] [v4 4/4] drm/panel-simple: Add Samsung ATNA33XC20

2021-05-25 Thread Doug Anderson
Hi, On Tue, May 25, 2021 at 12:31 AM Rajeev Nandan wrote: > > Add Samsung 13.3" FHD eDP AMOLED panel. > > Signed-off-by: Rajeev Nandan > --- > > Changes in v4: > - New > > drivers/gpu/drm/panel/panel-simple.c | 34 ++ > 1 file changed, 34 insertions(+) > > diff -

Re: [Freedreno] [v4 3/4] dt-bindings: display: simple: Add Samsung ATNA33XC20

2021-05-25 Thread Doug Anderson
Hi, On Tue, May 25, 2021 at 12:31 AM Rajeev Nandan wrote: > > Add Samsung 13.3" FHD eDP AMOLED panel. > > Signed-off-by: Rajeev Nandan > --- > > Changes in v4: > - New > > Documentation/devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [Freedreno] [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

2021-05-25 Thread Doug Anderson
Hi, On Tue, May 25, 2021 at 12:31 AM Rajeev Nandan wrote: > > @@ -171,6 +172,19 @@ struct panel_desc { > > /** @connector_type: LVDS, eDP, DSI, DPI, etc. */ > int connector_type; > + > + /** > +* @uses_dpcd_backlight: Panel supports eDP dpcd backlight control. > +

Re: [Freedreno] [PATCH] drm/msm/dp: Drop unnecessary NULL checks after container_of

2021-05-25 Thread abhinavk
On 2021-05-24 20:20, Guenter Roeck wrote: The result of container_of() operations is never NULL unless the embedded element is the first element of the structure. This is not the case here. The NULL check on the result of container_of() is therefore unnecessary and misleading. Remove it. This

Re: [Freedreno] [PATCH] drm/msm/dp: remove the repeated declaration

2021-05-25 Thread abhinavk
On 2021-05-25 05:22, Shaokun Zhang wrote: Function 'dp_catalog_audio_enable' is declared twice, remove the repeated declaration. Cc: Rob Clark Cc: Abhinav Kumar Signed-off-by: Shaokun Zhang Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_catalog.h | 1 - 1 file changed, 1 deletio

Re: [Freedreno] [PATCH] drm/msm: remove unneeded variable ret

2021-05-25 Thread Dmitry Baryshkov
On 07/04/2021 16:06, Bernard Zhao wrote: This patch fix coccicheck warning: drivers/gpu/drm/msm/dp/dp_link.c:848:5-8: Unneeded variable: "ret". Return "0" on line 880 Also remove unneeded function return value check. Signed-off-by: Bernard Zhao Reviewed-by: Dmitry Baryshkov --- drivers

Re: [Freedreno] [PATCH] drm/msm/disp/dpu1/dpu_encoder: Drop unnecessary NULL checks after container_of

2021-05-25 Thread Dmitry Baryshkov
On 25/05/2021 14:29, Guenter Roeck wrote: The result of container_of() operations is never NULL unless the embedded element is the first element of the structure. This is not the case here. The NULL checks on the result of container_of() are therefore unnecessary and misleading. Remove them. Thi

Re: [Freedreno] [PATCH v2 4/6] drm/msm/dpu: replace IRQ lookup with the data in hw catalog

2021-05-25 Thread Dmitry Baryshkov
On 25/05/2021 00:57, abhin...@codeaurora.org wrote: On 2021-05-16 13:29, Dmitry Baryshkov wrote: The IRQ table in the dpu_hw_interrupts.h is big, ugly, and hard to maintain. There are only few interrupts used from that table. Newer generations use different IRQ locations. Move this data to hw ca

Re: [Freedreno] [RFC PATCH 02/13] dt-bindings: msm/dsi: Document Display Stream Compression (DSC) parameters

2021-05-25 Thread Vinod Koul
On 24-05-21, 10:08, Bjorn Andersson wrote: > On Mon 24 May 02:30 CDT 2021, Vinod Koul wrote: > > > On 21-05-21, 09:42, Bjorn Andersson wrote: > > > On Fri 21 May 07:49 CDT 2021, Vinod Koul wrote: > > > > > > > DSC enables streams to be compressed before we send to panel. This > > > > requires DSC

Re: [Freedreno] [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support

2021-05-25 Thread Vinod Koul
Hello Jeff, On 21-05-21, 08:09, Jeffrey Hugo wrote: > On Fri, May 21, 2021 at 6:50 AM Vinod Koul wrote: > > > > Display Stream Compression (DSC) compresses the display stream in host which > > is later decoded by panel. This series enables this for Qualcomm msm driver. > > This was tested on Goog