Re: [Freedreno] [Mesa-dev] [XDC 2020] Virtual conference + Call for Proposals extended 2 weeks more

2020-07-13 Thread Samuel Iglesias Gonsálvez
On 7/3/20 4:41 PM, Samuel Iglesias Gonsálvez wrote: > Hi, > > In the last meeting, X.Org Foundation board has decided that XDC 2020 > will be a virtual conference, given the uncertain COVID-19 situation in > Europe by September, including the possibility of a second wave, > outbreaks and travel res

Re: [Freedreno] [v1] drm/msm/dpu: enumerate second cursor pipe for external interface

2020-07-13 Thread kalyan_t
On 2020-07-10 22:19, Rob Clark wrote: On Thu, Jun 25, 2020 at 5:46 AM Kalyan Thota wrote: Setup an RGB HW pipe as cursor which can be used on secondary interface. For SC7180 2 HW pipes are enumerated as cursors 1 - primary interface 2 - secondary interface Signed-off-by: Kalyan Thota --- d

[Freedreno] [PATCH v5 0/6] Add support for GPU DDR BW scaling

2020-07-13 Thread Akhil P Oommen
This series adds support for GPU DDR bandwidth scaling and is based on the bindings from Georgi [1]. This is mostly a rebase of Sharat's patches [2] on the tip of msm-next branch. Changes from v4: - Squashed a patch to another one to fix Jonathan's comment - Add back the pm_runtime_get_if_in_use()

[Freedreno] [PATCH v5 1/6] dt-bindings: drm/msm/gpu: Document gpu opp table

2020-07-13 Thread Akhil P Oommen
From: Sharat Masetty Update documentation to list the gpu opp table bindings including the newly added "opp-peak-kBps" needed for GPU-DDR bandwidth scaling. Signed-off-by: Sharat Masetty Acked-by: Rob Herring Signed-off-by: Akhil P Oommen --- .../devicetree/bindings/display/msm/gpu.txt

[Freedreno] [PATCH v5 4/6] arm64: dts: qcom: SDM845: Enable GPU DDR bw scaling

2020-07-13 Thread Akhil P Oommen
From: Sharat Masetty This patch adds the interconnects property for the gpu node and the opp-peak-kBps property to the opps of the gpu opp table. This should help enable DDR bandwidth scaling dynamically and proportionally to the GPU frequency. Signed-off-by: Sharat Masetty Signed-off-by: Akhil

[Freedreno] [PATCH v5 6/6] arm64: dts: qcom: sc7180: Add opp-peak-kBps to GPU opp

2020-07-13 Thread Akhil P Oommen
From: Sharat Masetty Add opp-peak-kBps bindings to the GPU opp table, listing the peak GPU -> DDR bandwidth requirement for each opp level. This will be used to scale the DDR bandwidth along with the GPU frequency dynamically. Signed-off-by: Sharat Masetty Reviewed-by: Matthias Kaehlcke Signed

[Freedreno] [PATCH v5 2/6] drm: msm: a6xx: send opp instead of a frequency

2020-07-13 Thread Akhil P Oommen
From: Sharat Masetty This patch changes the plumbing to send the devfreq recommended opp rather than the frequency. Also consolidate and rearrange the code in a6xx to set the GPU frequency and the icc vote in preparation for the upcoming changes for GPU->DDR scaling votes. Signed-off-by: Sharat

[Freedreno] [PATCH v5 5/6] arm64: dts: qcom: sc7180: Add interconnects property for GPU

2020-07-13 Thread Akhil P Oommen
From: Sharat Masetty This patch adds the interconnects property to the GPU node. This enables the GPU->DDR path bandwidth voting. Signed-off-by: Sharat Masetty Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm

[Freedreno] [PATCH v5 3/6] drm: msm: a6xx: use dev_pm_opp_set_bw to scale DDR

2020-07-13 Thread Akhil P Oommen
From: Sharat Masetty This patches replaces the previously used static DDR vote and uses dev_pm_opp_set_bw() to scale GPU->DDR bandwidth along with scaling GPU frequency. Also since the icc path voting is handled completely in the opp driver, remove the icc_path handle and its usage in the drm dri

Re: [Freedreno] [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting

2020-07-13 Thread Rob Herring
On Fri, Jul 10, 2020 at 5:02 PM Douglas Anderson wrote: > > I found that if I ever had a little mistake in my kernel config, > or device tree, or graphics driver that my system would sit in a loop > at bootup trying again and again and again. An example log was: Why do we care about optimizing t

Re: [Freedreno] [v1] drm/msm/dpu: enumerate second cursor pipe for external interface

2020-07-13 Thread Rob Clark
On Mon, Jul 13, 2020 at 3:18 AM wrote: > > On 2020-07-10 22:19, Rob Clark wrote: > > On Thu, Jun 25, 2020 at 5:46 AM Kalyan Thota > > wrote: > >> > >> Setup an RGB HW pipe as cursor which can be used on > >> secondary interface. > >> > >> For SC7180 2 HW pipes are enumerated as cursors > >> 1 - p

Re: [Freedreno] [v5] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings

2020-07-13 Thread Rob Herring
On Fri, 10 Jul 2020 19:27:49 +0530, Krishna Manikandan wrote: > MSM Mobile Display Subsytem (MDSS) encapsulates sub-blocks > like DPU display controller, DSI etc. Add YAML schema > for the device tree bindings for the same. > > Signed-off-by: Krishna Manikandan > > Changes in v2: > - Chang

Re: [Freedreno] [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting

2020-07-13 Thread Jeffrey Hugo
On Mon, Jul 13, 2020 at 8:11 AM Rob Herring wrote: > > On Fri, Jul 10, 2020 at 5:02 PM Douglas Anderson > wrote: > > > > I found that if I ever had a little mistake in my kernel config, > > or device tree, or graphics driver that my system would sit in a loop > > at bootup trying again and again

Re: [Freedreno] [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting

2020-07-13 Thread Doug Anderson
Hi, On Mon, Jul 13, 2020 at 7:11 AM Rob Herring wrote: > > On Fri, Jul 10, 2020 at 5:02 PM Douglas Anderson > wrote: > > > > I found that if I ever had a little mistake in my kernel config, > > or device tree, or graphics driver that my system would sit in a loop > > at bootup trying again and

Re: [Freedreno] [PATCH v9 4/7] iommu/arm-smmu: Add a pointer to the attached device to smmu_domain

2020-07-13 Thread Will Deacon
On Fri, Jun 26, 2020 at 02:00:38PM -0600, Jordan Crouse wrote: > Add a link to the pointer to the struct device that is attached to a > domain. This makes it easy to get the pointer if it is needed in the > implementation specific code. > > Signed-off-by: Jordan Crouse > --- > > drivers/iommu/a

Re: [Freedreno] [PATCH] iommu/arm-smmu: Add a init_context_bank implementation hook

2020-07-13 Thread Will Deacon
On Thu, Jun 11, 2020 at 04:36:56PM -0600, Jordan Crouse wrote: > Add a new implementation hook to allow the implementation specific code > to tweek the context bank configuration just before it gets written. > The first user will be the Adreno GPU implementation to turn on > SCTLR.HUPCF to ensure t

Re: [Freedreno] [RFC PATCH] interconnect: qcom: add functions to query addr/cmds for a path

2020-07-13 Thread Georgi Djakov
On 7/1/20 07:25, Jonathan Marek wrote: > The a6xx GMU can vote for ddr and cnoc bandwidth, but it needs to be able > to query the interconnect driver for bcm addresses and commands. It's not very clear to me how the GMU firmware would be dealing with this? Does anyone have an idea whether the GMU

Re: [Freedreno] [RFC PATCH] interconnect: qcom: add functions to query addr/cmds for a path

2020-07-13 Thread Jonathan Marek
On 7/13/20 11:24 AM, Georgi Djakov wrote: On 7/1/20 07:25, Jonathan Marek wrote: The a6xx GMU can vote for ddr and cnoc bandwidth, but it needs to be able to query the interconnect driver for bcm addresses and commands. It's not very clear to me how the GMU firmware would be dealing with this?

Re: [Freedreno] [v1] drm/msm/dpu: add support for clk and bw scaling for display

2020-07-13 Thread kalyan_t
On 2020-07-10 22:38, Rob Clark wrote: On Thu, Jun 18, 2020 at 7:09 AM Kalyan Thota wrote: This change adds support to scale src clk and bandwidth as per composition requirements. Interconnect registration for bw has been moved to mdp device node from mdss to facilitate the scaling. Changes i

Re: [Freedreno] [v5] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings

2020-07-13 Thread Rob Herring
On Fri, Jul 10, 2020 at 07:27:49PM +0530, Krishna Manikandan wrote: > MSM Mobile Display Subsytem (MDSS) encapsulates sub-blocks > like DPU display controller, DSI etc. Add YAML schema > for the device tree bindings for the same. > > Signed-off-by: Krishna Manikandan > > Changes in v2: > -

Re: [Freedreno] [PATCH] iommu/arm-smmu: Add a init_context_bank implementation hook

2020-07-13 Thread Jordan Crouse
On Mon, Jul 13, 2020 at 04:11:23PM +0100, Will Deacon wrote: > On Thu, Jun 11, 2020 at 04:36:56PM -0600, Jordan Crouse wrote: > > Add a new implementation hook to allow the implementation specific code > > to tweek the context bank configuration just before it gets written. > > The first user will

Re: [Freedreno] [v1] drm/msm/dpu: add support for clk and bw scaling for display

2020-07-13 Thread Rob Clark
On Mon, Jul 13, 2020 at 8:59 AM wrote: > > On 2020-07-10 22:38, Rob Clark wrote: > > On Thu, Jun 18, 2020 at 7:09 AM Kalyan Thota > > wrote: > >> > >> This change adds support to scale src clk and bandwidth as > >> per composition requirements. > >> > >> Interconnect registration for bw has been

Re: [Freedreno] [PATCH v9 4/7] iommu/arm-smmu: Add a pointer to the attached device to smmu_domain

2020-07-13 Thread Jordan Crouse
On Mon, Jul 13, 2020 at 04:09:02PM +0100, Will Deacon wrote: > On Fri, Jun 26, 2020 at 02:00:38PM -0600, Jordan Crouse wrote: > > Add a link to the pointer to the struct device that is attached to a > > domain. This makes it easy to get the pointer if it is needed in the > > implementation specific

Re: [Freedreno] [RFC PATCH] interconnect: qcom: add functions to query addr/cmds for a path

2020-07-13 Thread Jordan Crouse
On Mon, Jul 13, 2020 at 06:24:26PM +0300, Georgi Djakov wrote: > On 7/1/20 07:25, Jonathan Marek wrote: > > The a6xx GMU can vote for ddr and cnoc bandwidth, but it needs to be able > > to query the interconnect driver for bcm addresses and commands. > > It's not very clear to me how the GMU firmw

Re: [Freedreno] [PATCH v2 1/6] iommu/arm-smmu: Add auxiliary domain support for arm-smmuv2

2020-07-13 Thread Jordan Crouse
On Tue, Jul 07, 2020 at 08:09:41AM -0700, Rob Clark wrote: > On Tue, Jul 7, 2020 at 5:34 AM Robin Murphy wrote: > > > > On 2020-06-26 21:04, Jordan Crouse wrote: > > > Support auxiliary domains for arm-smmu-v2 to initialize and support > > > multiple pagetables for a single SMMU context bank. Sinc

Re: [Freedreno] [PATCH] iommu/arm-smmu: Add a init_context_bank implementation hook

2020-07-13 Thread Will Deacon
On Mon, Jul 13, 2020 at 11:00:32AM -0600, Jordan Crouse wrote: > On Mon, Jul 13, 2020 at 04:11:23PM +0100, Will Deacon wrote: > > On Thu, Jun 11, 2020 at 04:36:56PM -0600, Jordan Crouse wrote: > > > Add a new implementation hook to allow the implementation specific code > > > to tweek the context b

Re: [Freedreno] [PATCH] iommu/arm-smmu: Add a init_context_bank implementation hook

2020-07-13 Thread Jordan Crouse
On Mon, Jul 13, 2020 at 08:03:32PM +0100, Will Deacon wrote: > On Mon, Jul 13, 2020 at 11:00:32AM -0600, Jordan Crouse wrote: > > On Mon, Jul 13, 2020 at 04:11:23PM +0100, Will Deacon wrote: > > > On Thu, Jun 11, 2020 at 04:36:56PM -0600, Jordan Crouse wrote: > > > > Add a new implementation hook t

Re: [Freedreno] [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting

2020-07-13 Thread Rob Herring
On Mon, Jul 13, 2020 at 9:08 AM Doug Anderson wrote: > > Hi, > > On Mon, Jul 13, 2020 at 7:11 AM Rob Herring wrote: > > > > On Fri, Jul 10, 2020 at 5:02 PM Douglas Anderson > > wrote: > > > > > > I found that if I ever had a little mistake in my kernel config, > > > or device tree, or graphics

Re: [Freedreno] [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting

2020-07-13 Thread Rob Clark
On Mon, Jul 13, 2020 at 1:25 PM Rob Herring wrote: > > On Mon, Jul 13, 2020 at 9:08 AM Doug Anderson wrote: > > > > Hi, > > > > On Mon, Jul 13, 2020 at 7:11 AM Rob Herring wrote: > > > > > > On Fri, Jul 10, 2020 at 5:02 PM Douglas Anderson > > > wrote: > > > > > > > > I found that if I ever ha

[Freedreno] [PATCH v4 2/3] drm/msm: reset devfreq freq_table/max_state before devfreq_add_device

2020-07-13 Thread Jonathan Marek
These never get set back to 0 when probing fails, so an attempt to probe again results in broken behavior. Fix the problem by setting thse to zero before they are used. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/msm_gpu.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers

[Freedreno] [PATCH v4 0/3] drm/msm: handle for EPROBE_DEFER for of_icc_get

2020-07-13 Thread Jonathan Marek
Check for errors instead of silently not using icc if the msm driver probes before the interconnect driver. Allow ENODATA for ocmem path, as it is optional and this error is returned when "gfx-mem" path is provided but not "ocmem". Because msm_gpu_cleanup assumes msm_gpu_init has been called, the

[Freedreno] [PATCH v4 1/3] drm/msm: fix unbalanced pm_runtime_enable in adreno_gpu_{init, cleanup}

2020-07-13 Thread Jonathan Marek
adreno_gpu_init calls pm_runtime_enable, so adreno_gpu_cleanup needs to call pm_runtime_disable. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/

[Freedreno] [PATCH v4 3/3] drm/msm: handle for EPROBE_DEFER for of_icc_get

2020-07-13 Thread Jonathan Marek
Check for errors instead of silently not using icc if the msm driver probes before the interconnect driver. Allow ENODATA for ocmem path, as it is optional and this error is returned when "gfx-mem" path is provided but not "ocmem". Because msm_gpu_cleanup assumes msm_gpu_init has been called, the

Re: [Freedreno] [PATCH v4 1/3] drm/msm: fix unbalanced pm_runtime_enable in adreno_gpu_{init, cleanup}

2020-07-13 Thread Jordan Crouse
On Mon, Jul 13, 2020 at 06:53:40PM -0400, Jonathan Marek wrote: > adreno_gpu_init calls pm_runtime_enable, so adreno_gpu_cleanup needs to > call pm_runtime_disable. Reviewed-by: Jordan Crouse > Signed-off-by: Jonathan Marek > --- > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 3 +++ > 1 file chan

Re: [Freedreno] [PATCH v4 2/3] drm/msm: reset devfreq freq_table/max_state before devfreq_add_device

2020-07-13 Thread Jordan Crouse
On Mon, Jul 13, 2020 at 06:53:41PM -0400, Jonathan Marek wrote: > These never get set back to 0 when probing fails, so an attempt to probe > again results in broken behavior. Fix the problem by setting thse to zero > before they are used. Reviewed-by: Jordan Crouse > Signed-off-by: Jonathan Mare

Re: [Freedreno] [PATCH v4 3/3] drm/msm: handle for EPROBE_DEFER for of_icc_get

2020-07-13 Thread Jordan Crouse
On Mon, Jul 13, 2020 at 06:53:42PM -0400, Jonathan Marek wrote: > Check for errors instead of silently not using icc if the msm driver > probes before the interconnect driver. > > Allow ENODATA for ocmem path, as it is optional and this error > is returned when "gfx-mem" path is provided but not "

Re: [Freedreno] [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting

2020-07-13 Thread Doug Anderson
Hi, On Mon, Jul 13, 2020 at 1:25 PM Rob Herring wrote: > > On Mon, Jul 13, 2020 at 9:08 AM Doug Anderson wrote: > > > > Hi, > > > > On Mon, Jul 13, 2020 at 7:11 AM Rob Herring wrote: > > > > > > On Fri, Jul 10, 2020 at 5:02 PM Douglas Anderson > > > wrote: > > > > > > > > I found that if I ev

Re: [Freedreno] [v1] drm/msm/dpu: add support for clk and bw scaling for display

2020-07-13 Thread Matthias Kaehlcke
On Thu, Jun 18, 2020 at 07:38:41PM +0530, Kalyan Thota wrote: > This change adds support to scale src clk and bandwidth as > per composition requirements. > > Interconnect registration for bw has been moved to mdp > device node from mdss to facilitate the scaling. > > Changes in v1: > - Address

Re: [Freedreno] [PATCH] iommu/arm-smmu: Add a init_context_bank implementation hook

2020-07-13 Thread Sai Prakash Ranjan
On 2020-07-14 00:43, Jordan Crouse wrote: On Mon, Jul 13, 2020 at 08:03:32PM +0100, Will Deacon wrote: On Mon, Jul 13, 2020 at 11:00:32AM -0600, Jordan Crouse wrote: > On Mon, Jul 13, 2020 at 04:11:23PM +0100, Will Deacon wrote: > > On Thu, Jun 11, 2020 at 04:36:56PM -0600, Jordan Crouse wrote: