Re: [PATCH v6 2/7] drm/msm/hdmi: program HDMI timings during atomic_pre_enable

2025-02-07 Thread Dmitry Baryshkov
On Fri, Feb 07, 2025 at 12:11:55PM -0800, Abhinav Kumar wrote: > > > On 2/6/2025 5:19 PM, Dmitry Baryshkov wrote: > > On Thu, Feb 06, 2025 at 12:41:30PM -0800, Abhinav Kumar wrote: > > > > > > > > > On 2/3/2025 4:59 PM, Dmitry Baryshkov wrote: > > > > On Mon, Feb 03, 2025 at 11:34:00AM -0800, A

Re: [PATCH v6 2/7] drm/msm/hdmi: program HDMI timings during atomic_pre_enable

2025-02-07 Thread Abhinav Kumar
On 2/6/2025 5:19 PM, Dmitry Baryshkov wrote: On Thu, Feb 06, 2025 at 12:41:30PM -0800, Abhinav Kumar wrote: On 2/3/2025 4:59 PM, Dmitry Baryshkov wrote: On Mon, Feb 03, 2025 at 11:34:00AM -0800, Abhinav Kumar wrote: On 1/24/2025 1:47 PM, Dmitry Baryshkov wrote: The mode_set callback is

Re: [PATCH v6 2/7] drm/msm/hdmi: program HDMI timings during atomic_pre_enable

2025-02-06 Thread Dmitry Baryshkov
On Thu, Feb 06, 2025 at 12:41:30PM -0800, Abhinav Kumar wrote: > > > On 2/3/2025 4:59 PM, Dmitry Baryshkov wrote: > > On Mon, Feb 03, 2025 at 11:34:00AM -0800, Abhinav Kumar wrote: > > > > > > > > > On 1/24/2025 1:47 PM, Dmitry Baryshkov wrote: > > > > The mode_set callback is deprecated, it do

Re: [PATCH v6 2/7] drm/msm/hdmi: program HDMI timings during atomic_pre_enable

2025-02-06 Thread Abhinav Kumar
On 2/3/2025 4:59 PM, Dmitry Baryshkov wrote: On Mon, Feb 03, 2025 at 11:34:00AM -0800, Abhinav Kumar wrote: On 1/24/2025 1:47 PM, Dmitry Baryshkov wrote: The mode_set callback is deprecated, it doesn't get the drm_bridge_state, just mode-related argumetns. Also Abhinav pointed out that HDM

Re: [PATCH v6 2/7] drm/msm/hdmi: program HDMI timings during atomic_pre_enable

2025-02-03 Thread Dmitry Baryshkov
On Mon, Feb 03, 2025 at 11:34:00AM -0800, Abhinav Kumar wrote: > > > On 1/24/2025 1:47 PM, Dmitry Baryshkov wrote: > > The mode_set callback is deprecated, it doesn't get the > > drm_bridge_state, just mode-related argumetns. Also Abhinav pointed out > > that HDMI timings should be programmed aft

Re: [PATCH v6 2/7] drm/msm/hdmi: program HDMI timings during atomic_pre_enable

2025-02-03 Thread Abhinav Kumar
On 1/24/2025 1:47 PM, Dmitry Baryshkov wrote: The mode_set callback is deprecated, it doesn't get the drm_bridge_state, just mode-related argumetns. Also Abhinav pointed out that HDMI timings should be programmed after setting up HDMI PHY and PLL. Rework the code to program HDMI timings at the

Re: [PATCH v6 2/7] drm/msm/hdmi: program HDMI timings during atomic_pre_enable

2025-01-26 Thread Maxime Ripard
On Fri, Jan 24, 2025 at 11:47:42PM +0200, Dmitry Baryshkov wrote: > The mode_set callback is deprecated, it doesn't get the > drm_bridge_state, just mode-related argumetns. Also Abhinav pointed out > that HDMI timings should be programmed after setting up HDMI PHY and > PLL. Rework the code to prog

[PATCH v6 2/7] drm/msm/hdmi: program HDMI timings during atomic_pre_enable

2025-01-24 Thread Dmitry Baryshkov
The mode_set callback is deprecated, it doesn't get the drm_bridge_state, just mode-related argumetns. Also Abhinav pointed out that HDMI timings should be programmed after setting up HDMI PHY and PLL. Rework the code to program HDMI timings at the end of atomic_pre_enable(). Signed-off-by: Dmitry