Re: [PATCH v3 1/3] iommu/arm-smmu: Fix spurious interrupts with stall-on-fault

2025-01-29 Thread Rob Clark
On Tue, Jan 28, 2025 at 7:34 PM Connor Abbott wrote: > > On Tue, Jan 28, 2025 at 10:25 PM Rob Clark wrote: > > > > On Tue, Jan 28, 2025 at 6:31 PM Connor Abbott wrote: > > > > > > On Tue, Jan 28, 2025 at 9:21 PM Rob Clark wrote: > > > > > > > > On Tue, Jan 28, 2025 at 2:15 PM Connor Abbott >

Re: [PATCH v3 1/3] iommu/arm-smmu: Fix spurious interrupts with stall-on-fault

2025-01-28 Thread Connor Abbott
On Tue, Jan 28, 2025 at 10:25 PM Rob Clark wrote: > > On Tue, Jan 28, 2025 at 6:31 PM Connor Abbott wrote: > > > > On Tue, Jan 28, 2025 at 9:21 PM Rob Clark wrote: > > > > > > On Tue, Jan 28, 2025 at 2:15 PM Connor Abbott wrote: > > > > > > > > On Tue, Jan 28, 2025 at 5:10 PM Rob Clark wrote:

Re: [PATCH v3 1/3] iommu/arm-smmu: Fix spurious interrupts with stall-on-fault

2025-01-28 Thread Rob Clark
On Tue, Jan 28, 2025 at 6:31 PM Connor Abbott wrote: > > On Tue, Jan 28, 2025 at 9:21 PM Rob Clark wrote: > > > > On Tue, Jan 28, 2025 at 2:15 PM Connor Abbott wrote: > > > > > > On Tue, Jan 28, 2025 at 5:10 PM Rob Clark wrote: > > > > > > > > On Tue, Jan 28, 2025 at 3:08 AM Prakash Gupta > >

Re: [PATCH v3 1/3] iommu/arm-smmu: Fix spurious interrupts with stall-on-fault

2025-01-28 Thread Connor Abbott
On Tue, Jan 28, 2025 at 9:21 PM Rob Clark wrote: > > On Tue, Jan 28, 2025 at 2:15 PM Connor Abbott wrote: > > > > On Tue, Jan 28, 2025 at 5:10 PM Rob Clark wrote: > > > > > > On Tue, Jan 28, 2025 at 3:08 AM Prakash Gupta > > > wrote: > > > > > > > > On Thu, Jan 23, 2025 at 03:14:16PM -0500, Co

Re: [PATCH v3 1/3] iommu/arm-smmu: Fix spurious interrupts with stall-on-fault

2025-01-28 Thread Rob Clark
On Tue, Jan 28, 2025 at 2:15 PM Connor Abbott wrote: > > On Tue, Jan 28, 2025 at 5:10 PM Rob Clark wrote: > > > > On Tue, Jan 28, 2025 at 3:08 AM Prakash Gupta > > wrote: > > > > > > On Thu, Jan 23, 2025 at 03:14:16PM -0500, Connor Abbott wrote: > > > > On Thu, Jan 23, 2025 at 2:26 PM Prakash G

Re: [PATCH v3 1/3] iommu/arm-smmu: Fix spurious interrupts with stall-on-fault

2025-01-28 Thread Connor Abbott
On Tue, Jan 28, 2025 at 5:10 PM Rob Clark wrote: > > On Tue, Jan 28, 2025 at 3:08 AM Prakash Gupta wrote: > > > > On Thu, Jan 23, 2025 at 03:14:16PM -0500, Connor Abbott wrote: > > > On Thu, Jan 23, 2025 at 2:26 PM Prakash Gupta > > > wrote: > > > > > > > > On Thu, Jan 23, 2025 at 09:00:17AM -0

Re: [PATCH v3 1/3] iommu/arm-smmu: Fix spurious interrupts with stall-on-fault

2025-01-28 Thread Rob Clark
On Tue, Jan 28, 2025 at 3:08 AM Prakash Gupta wrote: > > On Thu, Jan 23, 2025 at 03:14:16PM -0500, Connor Abbott wrote: > > On Thu, Jan 23, 2025 at 2:26 PM Prakash Gupta > > wrote: > > > > > > On Thu, Jan 23, 2025 at 09:00:17AM -0500, Connor Abbott wrote: > > > > On Thu, Jan 23, 2025 at 6:10 AM

Re: [PATCH v3 1/3] iommu/arm-smmu: Fix spurious interrupts with stall-on-fault

2025-01-28 Thread Prakash Gupta
On Thu, Jan 23, 2025 at 03:14:16PM -0500, Connor Abbott wrote: > On Thu, Jan 23, 2025 at 2:26 PM Prakash Gupta wrote: > > > > On Thu, Jan 23, 2025 at 09:00:17AM -0500, Connor Abbott wrote: > > > On Thu, Jan 23, 2025 at 6:10 AM Prakash Gupta > > > wrote: > > > > > > > > On Wed, Jan 22, 2025 at 03

Re: [PATCH v3 1/3] iommu/arm-smmu: Fix spurious interrupts with stall-on-fault

2025-01-23 Thread Connor Abbott
On Thu, Jan 23, 2025 at 2:26 PM Prakash Gupta wrote: > > On Thu, Jan 23, 2025 at 09:00:17AM -0500, Connor Abbott wrote: > > On Thu, Jan 23, 2025 at 6:10 AM Prakash Gupta > > wrote: > > > > > > On Wed, Jan 22, 2025 at 03:00:58PM -0500, Connor Abbott wrote: > > > > > > > + /* > > > > + *

Re: [PATCH v3 1/3] iommu/arm-smmu: Fix spurious interrupts with stall-on-fault

2025-01-23 Thread Connor Abbott
On Thu, Jan 23, 2025 at 2:26 PM Prakash Gupta wrote: > > On Thu, Jan 23, 2025 at 09:00:17AM -0500, Connor Abbott wrote: > > On Thu, Jan 23, 2025 at 6:10 AM Prakash Gupta > > wrote: > > > > > > On Wed, Jan 22, 2025 at 03:00:58PM -0500, Connor Abbott wrote: > > > > > > > + /* > > > > + *

Re: [PATCH v3 1/3] iommu/arm-smmu: Fix spurious interrupts with stall-on-fault

2025-01-23 Thread Prakash Gupta
On Thu, Jan 23, 2025 at 09:00:17AM -0500, Connor Abbott wrote: > On Thu, Jan 23, 2025 at 6:10 AM Prakash Gupta wrote: > > > > On Wed, Jan 22, 2025 at 03:00:58PM -0500, Connor Abbott wrote: > > > > > + /* > > > + * On some implementations FSR.SS asserts a context fault > > > + * inter

Re: [PATCH v3 1/3] iommu/arm-smmu: Fix spurious interrupts with stall-on-fault

2025-01-23 Thread Connor Abbott
On Thu, Jan 23, 2025 at 12:35 PM Prakash Gupta wrote: > > On Thu, Jan 23, 2025 at 11:51:27AM +, Robin Murphy wrote: > > On 2025-01-23 11:10 am, Prakash Gupta wrote: > > > On Wed, Jan 22, 2025 at 03:00:58PM -0500, Connor Abbott wrote: > > > > + /* > > > > + * The SMMUv2 architecture specificat

Re: [PATCH v3 1/3] iommu/arm-smmu: Fix spurious interrupts with stall-on-fault

2025-01-23 Thread Prakash Gupta
On Thu, Jan 23, 2025 at 11:51:27AM +, Robin Murphy wrote: > On 2025-01-23 11:10 am, Prakash Gupta wrote: > > On Wed, Jan 22, 2025 at 03:00:58PM -0500, Connor Abbott wrote: > > > + /* > > > + * The SMMUv2 architecture specification says that if stall-on-fault is > > > + * enabled the correct s

Re: [PATCH v3 1/3] iommu/arm-smmu: Fix spurious interrupts with stall-on-fault

2025-01-23 Thread Connor Abbott
On Thu, Jan 23, 2025 at 6:10 AM Prakash Gupta wrote: > > On Wed, Jan 22, 2025 at 03:00:58PM -0500, Connor Abbott wrote: > > > @@ -125,12 +125,25 @@ static void qcom_adreno_smmu_resume_translation(const > > void *cookie, bool termina > > struct arm_smmu_domain *smmu_domain = (void *)cookie;

Re: [PATCH v3 1/3] iommu/arm-smmu: Fix spurious interrupts with stall-on-fault

2025-01-23 Thread Robin Murphy
On 2025-01-23 11:10 am, Prakash Gupta wrote: On Wed, Jan 22, 2025 at 03:00:58PM -0500, Connor Abbott wrote: @@ -125,12 +125,25 @@ static void qcom_adreno_smmu_resume_translation(const void *cookie, bool termina struct arm_smmu_domain *smmu_domain = (void *)cookie; struct arm_

Re: [PATCH v3 1/3] iommu/arm-smmu: Fix spurious interrupts with stall-on-fault

2025-01-23 Thread Prakash Gupta
On Wed, Jan 22, 2025 at 03:00:58PM -0500, Connor Abbott wrote: > @@ -125,12 +125,25 @@ static void qcom_adreno_smmu_resume_translation(const > void *cookie, bool termina > struct arm_smmu_domain *smmu_domain = (void *)cookie; > struct arm_smmu_cfg *cfg = &smmu_domain->cfg; > st

[PATCH v3 1/3] iommu/arm-smmu: Fix spurious interrupts with stall-on-fault

2025-01-22 Thread Connor Abbott
On some SMMUv2 implementations, including MMU-500, SMMU_CBn_FSR.SS asserts an interrupt. The only way to clear that bit is to resume the transaction by writing SMMU_CBn_RESUME, but typically resuming the transaction requires complex operations (copying in pages, etc.) that can't be done in IRQ cont