Re: [PATCH v2 03/11] drm/msm: adreno: move features bits in a separate variable

2024-11-21 Thread Dmitry Baryshkov
On Thu, Nov 21, 2024 at 11:48:28AM -0800, Rob Clark wrote: > On Thu, Nov 21, 2024 at 10:44 AM Dmitry Baryshkov > wrote: > > > > On Wed, Nov 20, 2024 at 10:54:24AM -0800, Rob Clark wrote: > > > On Wed, Nov 20, 2024 at 3:18 AM Dmitry Baryshkov > > > wrote: > > > > > > > > On Tue, Nov 19, 2024 at 06

Re: [PATCH v2 03/11] drm/msm: adreno: move features bits in a separate variable

2024-11-21 Thread Rob Clark
On Thu, Nov 21, 2024 at 10:44 AM Dmitry Baryshkov wrote: > > On Wed, Nov 20, 2024 at 10:54:24AM -0800, Rob Clark wrote: > > On Wed, Nov 20, 2024 at 3:18 AM Dmitry Baryshkov > > wrote: > > > > > > On Tue, Nov 19, 2024 at 06:56:38PM +0100, Neil Armstrong wrote: > > > > Now the features defines have

Re: [PATCH v2 03/11] drm/msm: adreno: move features bits in a separate variable

2024-11-21 Thread Dmitry Baryshkov
On Wed, Nov 20, 2024 at 10:54:24AM -0800, Rob Clark wrote: > On Wed, Nov 20, 2024 at 3:18 AM Dmitry Baryshkov > wrote: > > > > On Tue, Nov 19, 2024 at 06:56:38PM +0100, Neil Armstrong wrote: > > > Now the features defines have the right name, introduce a features > > > bitfield and move the featur

Re: [PATCH v2 03/11] drm/msm: adreno: move features bits in a separate variable

2024-11-20 Thread Rob Clark
On Wed, Nov 20, 2024 at 3:18 AM Dmitry Baryshkov wrote: > > On Tue, Nov 19, 2024 at 06:56:38PM +0100, Neil Armstrong wrote: > > Now the features defines have the right name, introduce a features > > bitfield and move the features defines in it, fixing all code checking > > for them. > > > > No fun

Re: [PATCH v2 03/11] drm/msm: adreno: move features bits in a separate variable

2024-11-20 Thread Dmitry Baryshkov
On Tue, Nov 19, 2024 at 06:56:38PM +0100, Neil Armstrong wrote: > Now the features defines have the right name, introduce a features > bitfield and move the features defines in it, fixing all code checking > for them. > > No functional changes intended. I think it might be better to squahs this p

[PATCH v2 03/11] drm/msm: adreno: move features bits in a separate variable

2024-11-19 Thread Neil Armstrong
Now the features defines have the right name, introduce a features bitfield and move the features defines in it, fixing all code checking for them. No functional changes intended. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 34 +++--- d