[PATCH drm-next] drm/msm/dp: Fix potential division by zero issue

2024-11-20 Thread Dheeraj Reddy Jonnalagadda
The variable pixel_div can remain zero due to an invalid rate input, leading to a potential division by zero issue. This patch fixes it and the function now logs an error and returns early. Additionally, this patch resolves trailing whitespace issues detected by checkpatch.pl in the same file. Si

Re: [PATCH drm-next] drm/msm/dp: Fix potential division by zero issue

2024-11-20 Thread Dheeraj Reddy Jonnalagadda
On Wed, Nov 20, 2024 at 01:02:32PM +0200, Dmitry Baryshkov wrote: > On Wed, Nov 20, 2024 at 10:34:51AM +0530, Dheeraj Reddy Jonnalagadda wrote: > > The variable pixel_div can remain zero due to an invalid rate input, > > No, it can not. Rate is set by the driver, which knowns which rates are > sup

Re: [PATCH drm-next] drm/msm/dp: Fix potential division by zero issue

2024-11-20 Thread Dmitry Baryshkov
On Wed, Nov 20, 2024 at 05:24:20PM +0530, Dheeraj Reddy Jonnalagadda wrote: > On Wed, Nov 20, 2024 at 01:02:32PM +0200, Dmitry Baryshkov wrote: > > On Wed, Nov 20, 2024 at 10:34:51AM +0530, Dheeraj Reddy Jonnalagadda wrote: > > > The variable pixel_div can remain zero due to an invalid rate input,

Re: [PATCH drm-next] drm/msm/dp: Fix potential division by zero issue

2024-11-20 Thread Dmitry Baryshkov
On Wed, Nov 20, 2024 at 10:34:51AM +0530, Dheeraj Reddy Jonnalagadda wrote: > The variable pixel_div can remain zero due to an invalid rate input, No, it can not. Rate is set by the driver, which knowns which rates are supported. > leading to a potential division by zero issue. This patch fixes