Re: [PATCH] Revert "iommu/io-pgtable-arm: Optimise non-coherent unmap"

2024-09-09 Thread Will Deacon
On Fri, Sep 06, 2024 at 04:25:19PM +0100, Robin Murphy wrote: > On 06/09/2024 11:56 am, Will Deacon wrote: > > On Thu, Sep 05, 2024 at 05:27:28PM +0100, Robin Murphy wrote: > > > On 05/09/2024 4:53 pm, Will Deacon wrote: > > > > On Thu, Sep 05, 2024 at 05:49:56AM -0700, Rob Clark wrote: > > > > > F

Re: [PATCH] Revert "iommu/io-pgtable-arm: Optimise non-coherent unmap"

2024-09-06 Thread Robin Murphy
On 06/09/2024 11:56 am, Will Deacon wrote: On Thu, Sep 05, 2024 at 05:27:28PM +0100, Robin Murphy wrote: On 05/09/2024 4:53 pm, Will Deacon wrote: On Thu, Sep 05, 2024 at 05:49:56AM -0700, Rob Clark wrote: From: Rob Clark This reverts commit 85b715a334583488ad7fbd3001fe6fd617b7d4c0. It was

Re: [PATCH] Revert "iommu/io-pgtable-arm: Optimise non-coherent unmap"

2024-09-06 Thread Rob Clark
On Fri, Sep 6, 2024 at 5:24 AM Robin Murphy wrote: > > On 2024-09-05 6:10 pm, Rob Clark wrote: > > On Thu, Sep 5, 2024 at 10:00 AM Rob Clark wrote: > >> > >> On Thu, Sep 5, 2024 at 9:27 AM Robin Murphy wrote: > >>> > >>> On 05/09/2024 4:53 pm, Will Deacon wrote: > Hi Rob, > > On T

Re: [PATCH] Revert "iommu/io-pgtable-arm: Optimise non-coherent unmap"

2024-09-06 Thread Robin Murphy
On 2024-09-05 6:10 pm, Rob Clark wrote: On Thu, Sep 5, 2024 at 10:00 AM Rob Clark wrote: On Thu, Sep 5, 2024 at 9:27 AM Robin Murphy wrote: On 05/09/2024 4:53 pm, Will Deacon wrote: Hi Rob, On Thu, Sep 05, 2024 at 05:49:56AM -0700, Rob Clark wrote: From: Rob Clark This reverts commit 8

Re: [PATCH] Revert "iommu/io-pgtable-arm: Optimise non-coherent unmap"

2024-09-06 Thread Will Deacon
On Thu, Sep 05, 2024 at 05:27:28PM +0100, Robin Murphy wrote: > On 05/09/2024 4:53 pm, Will Deacon wrote: > > On Thu, Sep 05, 2024 at 05:49:56AM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > This reverts commit 85b715a334583488ad7fbd3001fe6fd617b7d4c0. > > > > > > It was causing gpu

Re: [PATCH] Revert "iommu/io-pgtable-arm: Optimise non-coherent unmap"

2024-09-05 Thread Rob Clark
On Thu, Sep 5, 2024 at 10:00 AM Rob Clark wrote: > > On Thu, Sep 5, 2024 at 9:27 AM Robin Murphy wrote: > > > > On 05/09/2024 4:53 pm, Will Deacon wrote: > > > Hi Rob, > > > > > > On Thu, Sep 05, 2024 at 05:49:56AM -0700, Rob Clark wrote: > > >> From: Rob Clark > > >> > > >> This reverts commit

Re: [PATCH] Revert "iommu/io-pgtable-arm: Optimise non-coherent unmap"

2024-09-05 Thread Rob Clark
On Thu, Sep 5, 2024 at 9:27 AM Robin Murphy wrote: > > On 05/09/2024 4:53 pm, Will Deacon wrote: > > Hi Rob, > > > > On Thu, Sep 05, 2024 at 05:49:56AM -0700, Rob Clark wrote: > >> From: Rob Clark > >> > >> This reverts commit 85b715a334583488ad7fbd3001fe6fd617b7d4c0. > >> > >> It was causing gpu

Re: [PATCH] Revert "iommu/io-pgtable-arm: Optimise non-coherent unmap"

2024-09-05 Thread Robin Murphy
On 05/09/2024 4:53 pm, Will Deacon wrote: Hi Rob, On Thu, Sep 05, 2024 at 05:49:56AM -0700, Rob Clark wrote: From: Rob Clark This reverts commit 85b715a334583488ad7fbd3001fe6fd617b7d4c0. It was causing gpu smmu faults on x1e80100. I _think_ what is causing this is the change in ordering of

Re: [PATCH] Revert "iommu/io-pgtable-arm: Optimise non-coherent unmap"

2024-09-05 Thread Robin Murphy
On 05/09/2024 2:57 pm, Rob Clark wrote: On Thu, Sep 5, 2024 at 6:24 AM Robin Murphy wrote: On 05/09/2024 1:49 pm, Rob Clark wrote: From: Rob Clark This reverts commit 85b715a334583488ad7fbd3001fe6fd617b7d4c0. It was causing gpu smmu faults on x1e80100. I _think_ what is causing this is th

Re: [PATCH] Revert "iommu/io-pgtable-arm: Optimise non-coherent unmap"

2024-09-05 Thread Will Deacon
Hi Rob, On Thu, Sep 05, 2024 at 05:49:56AM -0700, Rob Clark wrote: > From: Rob Clark > > This reverts commit 85b715a334583488ad7fbd3001fe6fd617b7d4c0. > > It was causing gpu smmu faults on x1e80100. > > I _think_ what is causing this is the change in ordering of > __arm_lpae_clear_pte() (dma_s

Re: [PATCH] Revert "iommu/io-pgtable-arm: Optimise non-coherent unmap"

2024-09-05 Thread Rob Clark
On Thu, Sep 5, 2024 at 6:24 AM Robin Murphy wrote: > > On 05/09/2024 1:49 pm, Rob Clark wrote: > > From: Rob Clark > > > > This reverts commit 85b715a334583488ad7fbd3001fe6fd617b7d4c0. > > > > It was causing gpu smmu faults on x1e80100. > > > > I _think_ what is causing this is the change in orde

Re: [PATCH] Revert "iommu/io-pgtable-arm: Optimise non-coherent unmap"

2024-09-05 Thread Robin Murphy
On 05/09/2024 2:24 pm, Robin Murphy wrote: On 05/09/2024 1:49 pm, Rob Clark wrote: From: Rob Clark This reverts commit 85b715a334583488ad7fbd3001fe6fd617b7d4c0. It was causing gpu smmu faults on x1e80100. I _think_ what is causing this is the change in ordering of __arm_lpae_clear_pte() (dma

Re: [PATCH] Revert "iommu/io-pgtable-arm: Optimise non-coherent unmap"

2024-09-05 Thread Robin Murphy
On 05/09/2024 1:49 pm, Rob Clark wrote: From: Rob Clark This reverts commit 85b715a334583488ad7fbd3001fe6fd617b7d4c0. It was causing gpu smmu faults on x1e80100. I _think_ what is causing this is the change in ordering of __arm_lpae_clear_pte() (dma_sync_single_for_device() on the pgtable mem

[PATCH] Revert "iommu/io-pgtable-arm: Optimise non-coherent unmap"

2024-09-05 Thread Rob Clark
From: Rob Clark This reverts commit 85b715a334583488ad7fbd3001fe6fd617b7d4c0. It was causing gpu smmu faults on x1e80100. I _think_ what is causing this is the change in ordering of __arm_lpae_clear_pte() (dma_sync_single_for_device() on the pgtable memory) and io_pgtable_tlb_flush_walk(). I'm