Re: [Freedreno] [v8 1/6] drm/panel: add basic DP AUX backlight support

2021-07-12 Thread Doug Anderson
Hi, On Mon, Jul 12, 2021 at 6:39 AM Doug Anderson wrote: > > Hi, > > On Mon, Jul 12, 2021 at 2:41 AM Thomas Zimmermann wrote: > > > > > + ret = drm_dp_dpcd_read(aux, DP_EDP_DPCD_REV, edp_dpcd, > > > +EDP_DISPLAY_CTL_CAP_SIZE); > > > > This creates a cyclic depende

Re: [Freedreno] [v8 1/6] drm/panel: add basic DP AUX backlight support

2021-07-12 Thread Doug Anderson
Hi, On Mon, Jul 12, 2021 at 2:41 AM Thomas Zimmermann wrote: > > > + ret = drm_dp_dpcd_read(aux, DP_EDP_DPCD_REV, edp_dpcd, > > +EDP_DISPLAY_CTL_CAP_SIZE); > > This creates a cyclic dependency between drm_kms_helper-ko and drm.ko. > drm_panel.c is in the latter, wh

Re: [Freedreno] [v8 1/6] drm/panel: add basic DP AUX backlight support

2021-07-12 Thread Thomas Zimmermann
Hi Am 12.07.21 um 11:41 schrieb Thomas Zimmermann: Am 26.06.21 um 18:51 schrieb Rajeev Nandan: Some panels support backlight control over DP AUX channel using VESA's standard backlight control interface. Using new DRM eDP backlight helpers, add support to create and register a backlight for t

Re: [Freedreno] [v8 1/6] drm/panel: add basic DP AUX backlight support

2021-07-12 Thread Thomas Zimmermann
Am 26.06.21 um 18:51 schrieb Rajeev Nandan: Some panels support backlight control over DP AUX channel using VESA's standard backlight control interface. Using new DRM eDP backlight helpers, add support to create and register a backlight for those panels in drm_panel to simplify the panel driver

[Freedreno] [v8 1/6] drm/panel: add basic DP AUX backlight support

2021-06-26 Thread Rajeev Nandan
Some panels support backlight control over DP AUX channel using VESA's standard backlight control interface. Using new DRM eDP backlight helpers, add support to create and register a backlight for those panels in drm_panel to simplify the panel drivers. The panel driver with access to "struct drm_