Re: [Freedreno] [v7 1/5] drm/panel: add basic DP AUX backlight support

2021-06-22 Thread rajeevny
Hi, On 23-06-2021 00:03, Doug Anderson wrote: Hi, On Mon, Jun 21, 2021 at 11:38 AM Sam Ravnborg wrote: > > I cannot see why you need the extra check on ->enabled? > > Would it be sufficient to check backlight_is_blank() only? > > This extra check on bl->enabled flag is added to avoid enablin

Re: [Freedreno] [v7 1/5] drm/panel: add basic DP AUX backlight support

2021-06-22 Thread Doug Anderson
Hi, On Mon, Jun 21, 2021 at 11:38 AM Sam Ravnborg wrote: > > > > I cannot see why you need the extra check on ->enabled? > > > Would it be sufficient to check backlight_is_blank() only? > > > > This extra check on bl->enabled flag is added to avoid enabling/disabling > > backlight again if it is

Re: [Freedreno] [v7 1/5] drm/panel: add basic DP AUX backlight support

2021-06-21 Thread Sam Ravnborg
Hi Rajeev, On Mon, Jun 21, 2021 at 02:08:17PM +0530, rajee...@codeaurora.org wrote: > Hi Sam, > > On 20-06-2021 15:01, Sam Ravnborg wrote: > > Hi Rajeev > > > > On Sat, Jun 19, 2021 at 04:10:26PM +0530, Rajeev Nandan wrote: > > > Some panels support backlight control over DP AUX channel using >

Re: [Freedreno] [v7 1/5] drm/panel: add basic DP AUX backlight support

2021-06-21 Thread rajeevny
Hi Sam, On 20-06-2021 15:01, Sam Ravnborg wrote: Hi Rajeev On Sat, Jun 19, 2021 at 04:10:26PM +0530, Rajeev Nandan wrote: Some panels support backlight control over DP AUX channel using VESA's standard backlight control interface. Using new DRM eDP backlight helpers, add support to create and

Re: [Freedreno] [v7 1/5] drm/panel: add basic DP AUX backlight support

2021-06-20 Thread Sam Ravnborg
Hi Rajeev On Sat, Jun 19, 2021 at 04:10:26PM +0530, Rajeev Nandan wrote: > Some panels support backlight control over DP AUX channel using > VESA's standard backlight control interface. > Using new DRM eDP backlight helpers, add support to create and > register a backlight for those panels in drm_

[Freedreno] [v7 1/5] drm/panel: add basic DP AUX backlight support

2021-06-19 Thread Rajeev Nandan
Some panels support backlight control over DP AUX channel using VESA's standard backlight control interface. Using new DRM eDP backlight helpers, add support to create and register a backlight for those panels in drm_panel to simplify the panel drivers. The panel driver with access to "struct drm_