Re: [Freedreno] [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

2021-06-08 Thread Doug Anderson
Lyude, On Tue, Jun 1, 2021 at 3:20 PM Lyude Paul wrote: > > oh-looks like my patches just got reviewed, so hopefully I should get a chance > to get a look at this in the next day or two :) I'm going to assume that means that you don't need extra eyes on your backlight patches. If you do, please

Re: [Freedreno] [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

2021-06-01 Thread rajeevny
On 02-06-2021 03:50, Lyude Paul wrote: oh-looks like my patches just got reviewed, so hopefully I should get a chance to get a look at this in the next day or two :) Hi Lyude, That's great! I have updated v5 [1] of this series addressing Doug's review comments on v4 [2].  Please review the

Re: [Freedreno] [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

2021-06-01 Thread Lyude Paul
oh-looks like my patches just got reviewed, so hopefully I should get a chance to get a look at this in the next day or two :) On Tue, 2021-05-25 at 13:00 +0530, Rajeev Nandan wrote: > Add basic support of panel backlight control over eDP aux channel > using VESA's standard backlight control inter

Re: [Freedreno] [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

2021-06-01 Thread Lyude Paul
Sorry-I've been waiting to review this, but the DPCD backlight support helper series is -still- blocked on getting reviews upstream :\ On Tue, 2021-05-25 at 13:00 +0530, Rajeev Nandan wrote: > Add basic support of panel backlight control over eDP aux channel > using VESA's standard backlight contr

Re: [Freedreno] [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

2021-05-27 Thread Doug Anderson
Hi, On Thu, May 27, 2021 at 5:21 AM wrote: > > >> @@ -171,6 +172,19 @@ struct panel_desc { > >> > >> /** @connector_type: LVDS, eDP, DSI, DPI, etc. */ > >> int connector_type; > >> + > >> + /** > >> +* @uses_dpcd_backlight: Panel supports eDP dpcd backlight > >> cont

Re: [Freedreno] [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

2021-05-27 Thread rajeevny
Hi, On 25-05-2021 22:48, Doug Anderson wrote: Hi, On Tue, May 25, 2021 at 12:31 AM Rajeev Nandan wrote: @@ -171,6 +172,19 @@ struct panel_desc { /** @connector_type: LVDS, eDP, DSI, DPI, etc. */ int connector_type; + + /** +* @uses_dpcd_backlight: Panel suppor

Re: [Freedreno] [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

2021-05-25 Thread Doug Anderson
Hi, On Tue, May 25, 2021 at 12:31 AM Rajeev Nandan wrote: > > @@ -171,6 +172,19 @@ struct panel_desc { > > /** @connector_type: LVDS, eDP, DSI, DPI, etc. */ > int connector_type; > + > + /** > +* @uses_dpcd_backlight: Panel supports eDP dpcd backlight control. > +

Re: [Freedreno] [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

2021-05-25 Thread kernel test robot
Hi Rajeev, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [also build test ERROR on next-20210525] [cannot apply to robh/for-next drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.13-rc3]

[Freedreno] [v4 1/4] drm/panel-simple: Add basic DPCD backlight support

2021-05-25 Thread Rajeev Nandan
Add basic support of panel backlight control over eDP aux channel using VESA's standard backlight control interface. Signed-off-by: Rajeev Nandan --- This patch depends on [1] (drm/panel: panel-simple: Stash DP AUX bus; allow using it for DDC) Changes in v4: - New [1] https://lore.kernel.or