Re: [Freedreno] [patch v2] drm/msm/dsi: free first element on error

2017-02-27 Thread Rob Clark
On Mon, Feb 27, 2017 at 5:25 AM, Daniel Vetter wrote: > On Mon, Feb 27, 2017 at 11:18 AM, Jani Nikula > wrote: >> On Sun, 26 Feb 2017, Daniel Vetter wrote: >>> On Thu, Feb 16, 2017 at 02:27:08PM +0200, Jani Nikula wrote: On Thu, 16 Feb 2017, Rob Clark wrote: > On Thu, Feb 16, 2017 at

Re: [Freedreno] [patch v2] drm/msm/dsi: free first element on error

2017-02-27 Thread Daniel Vetter
On Mon, Feb 27, 2017 at 11:18 AM, Jani Nikula wrote: > On Sun, 26 Feb 2017, Daniel Vetter wrote: >> On Thu, Feb 16, 2017 at 02:27:08PM +0200, Jani Nikula wrote: >>> On Thu, 16 Feb 2017, Rob Clark wrote: >>> > On Thu, Feb 16, 2017 at 7:00 AM, Dan Carpenter >>> > wrote: >>> >> We're off by one h

Re: [Freedreno] [patch v2] drm/msm/dsi: free first element on error

2017-02-27 Thread Jani Nikula
On Sun, 26 Feb 2017, Daniel Vetter wrote: > On Thu, Feb 16, 2017 at 02:27:08PM +0200, Jani Nikula wrote: >> On Thu, 16 Feb 2017, Rob Clark wrote: >> > On Thu, Feb 16, 2017 at 7:00 AM, Dan Carpenter >> > wrote: >> >> We're off by one here. We free something that wasn't allocated and we >> >> do

Re: [Freedreno] [patch v2] drm/msm/dsi: free first element on error

2017-02-26 Thread Daniel Vetter
On Thu, Feb 16, 2017 at 02:27:08PM +0200, Jani Nikula wrote: > On Thu, 16 Feb 2017, Rob Clark wrote: > > On Thu, Feb 16, 2017 at 7:00 AM, Dan Carpenter > > wrote: > >> We're off by one here. We free something that wasn't allocated and we > >> don't free msm_host->bus_clks[]. > >> > >> Fixes: 6e

Re: [Freedreno] [patch v2] drm/msm/dsi: free first element on error

2017-02-16 Thread Jani Nikula
On Thu, 16 Feb 2017, Rob Clark wrote: > On Thu, Feb 16, 2017 at 7:00 AM, Dan Carpenter > wrote: >> We're off by one here. We free something that wasn't allocated and we >> don't free msm_host->bus_clks[]. >> >> Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list") >> Signed-off-by:

Re: [Freedreno] [patch v2] drm/msm/dsi: free first element on error

2017-02-16 Thread Rob Clark
On Thu, Feb 16, 2017 at 7:00 AM, Dan Carpenter wrote: > We're off by one here. We free something that wasn't allocated and we > don't free msm_host->bus_clks[]. > > Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list") > Signed-off-by: Dan Carpenter Thanks Reviewed-by: Rob Clark

[Freedreno] [patch v2] drm/msm/dsi: free first element on error

2017-02-16 Thread Dan Carpenter
We're off by one here. We free something that wasn't allocated and we don't free msm_host->bus_clks[]. Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list") Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 1fc07