Re: [Freedreno] [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver

2022-01-14 Thread Stephen Boyd
Quoting Yong Wu (2022-01-14 23:39:52) > On Fri, 2022-01-14 at 15:30 -0600, Stephen Boyd wrote: > > > > This sounds more correct to me. I'm not an expert on runtime PM > > though > > as I always have to read the code to remember how it works. if the > > device isn't ready for runtime PM until the co

Re: [Freedreno] [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver

2022-01-14 Thread Yong Wu
On Fri, 2022-01-14 at 15:30 -0600, Stephen Boyd wrote: > Quoting Yong Wu (2022-01-14 01:06:31) > > On Wed, 2022-01-12 at 20:25 -0800, Stephen Boyd wrote: > > > > > > > > [2.654526] [ cut here ] > > > > [2.68] refcount_t: addition on 0; use-after-free. > > > > >

Re: [Freedreno] [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver

2022-01-14 Thread Stephen Boyd
Quoting Yong Wu (2022-01-14 01:06:31) > On Wed, 2022-01-12 at 20:25 -0800, Stephen Boyd wrote: > > > > > > [2.654526] [ cut here ] > > > [2.68] refcount_t: addition on 0; use-after-free. > > > > > > After this patch, the aggregate_driver flow looks ok. But our >

Re: [Freedreno] [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver

2022-01-14 Thread Yong Wu
On Wed, 2022-01-12 at 20:25 -0800, Stephen Boyd wrote: > > > > [2.654526] [ cut here ] > > [2.68] refcount_t: addition on 0; use-after-free. > > > > After this patch, the aggregate_driver flow looks ok. But our > > driver > > still aborts like this: > > > > [

Re: [Freedreno] [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver

2022-01-12 Thread Stephen Boyd
Quoting Yong Wu (2022-01-12 01:09:19) > On Tue, 2022-01-11 at 16:27 -0800, Stephen Boyd wrote: > > ---8<--- > > diff --git a/drivers/base/component.c b/drivers/base/component.c > > index 64ad7478c67a..97f253a41bdf 100644 > > --- a/drivers/base/component.c > > +++ b/drivers/base/component.c > > @@ -

Re: [Freedreno] [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver

2022-01-12 Thread Yong Wu
On Tue, 2022-01-11 at 16:27 -0800, Stephen Boyd wrote: > Quoting Yong Wu (2022-01-11 04:22:23) > > Hi Stephen, > > > > Thanks for helping update here. > > > > On Thu, 2022-01-06 at 13:45 -0800, Stephen Boyd wrote: > > > Use an aggregate driver instead of component ops so that we can > > > get > >

Re: [Freedreno] [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver

2022-01-11 Thread Stephen Boyd
Quoting Yong Wu (2022-01-11 04:22:23) > Hi Stephen, > > Thanks for helping update here. > > On Thu, 2022-01-06 at 13:45 -0800, Stephen Boyd wrote: > > Use an aggregate driver instead of component ops so that we can get > > proper driver probe ordering of the aggregate device with respect to > > all

Re: [Freedreno] [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver

2022-01-11 Thread Yong Wu
Hi Stephen, Thanks for helping update here. On Thu, 2022-01-06 at 13:45 -0800, Stephen Boyd wrote: > Use an aggregate driver instead of component ops so that we can get > proper driver probe ordering of the aggregate device with respect to > all > the component devices that make up the aggregate

[Freedreno] [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Yong Wu Cc: Joerg Roedel Cc: Will Deacon Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob