Re: [Freedreno] [PATCH v3] drm/msm/dpu: always program DSC active bits

2023-04-20 Thread Dmitry Baryshkov
On 20/04/2023 19:40, Abhinav Kumar wrote: Hi Dmitry / Marijn On 4/20/2023 7:03 AM, Dmitry Baryshkov wrote: On 15/04/2023 02:02, Marijn Suijten wrote: On 2023-04-14 09:46:17, Kuogee Hsieh wrote: In current code, the dsc active bits are set only if the cfg->dsc is set. This is the old sentenc

Re: [Freedreno] [PATCH v3] drm/msm/dpu: always program DSC active bits

2023-04-20 Thread Abhinav Kumar
Hi Dmitry / Marijn On 4/20/2023 7:03 AM, Dmitry Baryshkov wrote: On 15/04/2023 02:02, Marijn Suijten wrote: On 2023-04-14 09:46:17, Kuogee Hsieh wrote: In current code, the dsc active bits are set only if the cfg->dsc is set. This is the old sentence from v1 again, did you accidentally send

Re: [Freedreno] [PATCH v3] drm/msm/dpu: always program DSC active bits

2023-04-20 Thread Dmitry Baryshkov
On 15/04/2023 02:02, Marijn Suijten wrote: On 2023-04-14 09:46:17, Kuogee Hsieh wrote: In current code, the dsc active bits are set only if the cfg->dsc is set. This is the old sentence from v1 again, did you accidentally send the wrong patch as the improvements from v2 are missing? However,

Re: [Freedreno] [PATCH v3] drm/msm/dpu: always program DSC active bits

2023-04-14 Thread Marijn Suijten
On 2023-04-14 09:46:17, Kuogee Hsieh wrote: > In current code, the dsc active bits are set only if the cfg->dsc is set. This is the old sentence from v1 again, did you accidentally send the wrong patch as the improvements from v2 are missing? > However, for displays which are hot-pluggable, there

Re: [Freedreno] [PATCH v3] drm/msm/dpu: always program DSC active bits

2023-04-14 Thread Dmitry Baryshkov
On Fri, 14 Apr 2023 at 19:46, Kuogee Hsieh wrote: > > In current code, the dsc active bits are set only if the cfg->dsc is set. > However, for displays which are hot-pluggable, there can be a use-case > of disconnecting a DSC supported sink and connecting a non-DSC sink. > > For those cases we nee

[Freedreno] [PATCH v3] drm/msm/dpu: always program DSC active bits

2023-04-14 Thread Kuogee Hsieh
In current code, the dsc active bits are set only if the cfg->dsc is set. However, for displays which are hot-pluggable, there can be a use-case of disconnecting a DSC supported sink and connecting a non-DSC sink. For those cases we need to clear DSC active bits during teardown. As discuss at [1]