Re: [Freedreno] [PATCH v2 1/4] drm/msm/dp: Add basic PSR support for eDP

2022-06-21 Thread Sankeerth Billakanti
Hi Bjorn, >> Add support for basic panel self refresh (PSR) feature for eDP. >> Add a new interface to set PSR state in the sink from DPU. >> Program the eDP controller to issue PSR enter and exit SDP to the >> sink. >> >> Signed-off-by: Sankeerth Billakanti >> >> Changes in v2: >> - Use dp bri

Re: [Freedreno] [PATCH v2 1/4] drm/msm/dp: Add basic PSR support for eDP

2022-06-21 Thread Sankeerth Billakanti
Hi Dmitry, >On Mon, 21 Feb 2022 at 17:52, Vinod Polimera >wrote: >> >> Add support for basic panel self refresh (PSR) feature for eDP. >> Add a new interface to set PSR state in the sink from DPU. >> Program the eDP controller to issue PSR enter and exit SDP to the >> sink. >> >> Signed-off-by: S

Re: [Freedreno] [PATCH v2 1/4] drm/msm/dp: Add basic PSR support for eDP

2022-02-22 Thread Dmitry Baryshkov
On 23/02/2022 00:32, Doug Anderson wrote: Hi, On Tue, Feb 22, 2022 at 1:23 PM Dmitry Baryshkov wrote: On 22/02/2022 22:25, Doug Anderson wrote: Hi, On Mon, Feb 21, 2022 at 7:12 PM Dmitry Baryshkov wrote: +static int dp_link_psr_status(struct dp_link_private *link) +{ + u8 status[2

Re: [Freedreno] [PATCH v2 1/4] drm/msm/dp: Add basic PSR support for eDP

2022-02-22 Thread Doug Anderson
Hi, On Tue, Feb 22, 2022 at 1:23 PM Dmitry Baryshkov wrote: > > On 22/02/2022 22:25, Doug Anderson wrote: > > Hi, > > > > On Mon, Feb 21, 2022 at 7:12 PM Dmitry Baryshkov > > wrote: > >> > >>> +static int dp_link_psr_status(struct dp_link_private *link) > >>> +{ > >>> + u8 status[2]; > >>>

Re: [Freedreno] [PATCH v2 1/4] drm/msm/dp: Add basic PSR support for eDP

2022-02-22 Thread Dmitry Baryshkov
On 22/02/2022 22:25, Doug Anderson wrote: Hi, On Mon, Feb 21, 2022 at 7:12 PM Dmitry Baryshkov wrote: +static int dp_link_psr_status(struct dp_link_private *link) +{ + u8 status[2]; + + drm_dp_dpcd_read(link->aux, DP_PSR_ERROR_STATUS, status, 2); + + if (status[0] & DP_PSR_

Re: [Freedreno] [PATCH v2 1/4] drm/msm/dp: Add basic PSR support for eDP

2022-02-22 Thread Bjorn Andersson
On Mon 21 Feb 06:51 PST 2022, Vinod Polimera wrote: > Add support for basic panel self refresh (PSR) feature for eDP. > Add a new interface to set PSR state in the sink from DPU. > Program the eDP controller to issue PSR enter and exit SDP to > the sink. > > Signed-off-by: Sankeerth Billakanti >

Re: [Freedreno] [PATCH v2 1/4] drm/msm/dp: Add basic PSR support for eDP

2022-02-22 Thread Doug Anderson
Hi, On Mon, Feb 21, 2022 at 7:12 PM Dmitry Baryshkov wrote: > > > +static int dp_link_psr_status(struct dp_link_private *link) > > +{ > > + u8 status[2]; > > + > > + drm_dp_dpcd_read(link->aux, DP_PSR_ERROR_STATUS, status, 2); > > + > > + if (status[0] & DP_PSR_LINK_CRC_ERROR) >

Re: [Freedreno] [PATCH v2 1/4] drm/msm/dp: Add basic PSR support for eDP

2022-02-21 Thread Dmitry Baryshkov
On Mon, 21 Feb 2022 at 17:52, Vinod Polimera wrote: > > Add support for basic panel self refresh (PSR) feature for eDP. > Add a new interface to set PSR state in the sink from DPU. > Program the eDP controller to issue PSR enter and exit SDP to > the sink. > > Signed-off-by: Sankeerth Billakanti

[Freedreno] [PATCH v2 1/4] drm/msm/dp: Add basic PSR support for eDP

2022-02-21 Thread Vinod Polimera
Add support for basic panel self refresh (PSR) feature for eDP. Add a new interface to set PSR state in the sink from DPU. Program the eDP controller to issue PSR enter and exit SDP to the sink. Signed-off-by: Sankeerth Billakanti Changes in v2: - Use dp bridge to set psr entry/exit instead of