Re: [Freedreno] [PATCH 13/14] drm/msm: Drop struct_mutex in shrinker path

2020-10-06 Thread Daniel Vetter
On Mon, Oct 05, 2020 at 08:40:12PM -0700, Rob Clark wrote: > On Mon, Oct 5, 2020 at 5:44 PM Hillf Danton wrote: > > > > > > On Mon, 5 Oct 2020 18:17:01 Kristian H. Kristensen wrote: > > > On Mon, Oct 5, 2020 at 4:02 PM Daniel Vetter wrote: > > > > > > > > On Mon, Oct 05, 2020 at 05:24:19PM +0800,

Re: [Freedreno] [PATCH 13/14] drm/msm: Drop struct_mutex in shrinker path

2020-10-06 Thread Hillf Danton
On Mon, 5 Oct 2020 20:40:12 Rob Clark wrote: > On Mon, Oct 5, 2020 at 5:44 PM Hillf Danton wrote: > > On Mon, 5 Oct 2020 18:17:01 Kristian H. Kristensen wrote: > > > On Mon, Oct 5, 2020 at 4:02 PM Daniel Vetter wrote: > > > > > > > > On Mon, Oct 05, 2020 at 05:24:19PM +0800, Hillf Danton wrote

Re: [Freedreno] [PATCH 13/14] drm/msm: Drop struct_mutex in shrinker path

2020-10-05 Thread Rob Clark
On Mon, Oct 5, 2020 at 5:44 PM Hillf Danton wrote: > > > On Mon, 5 Oct 2020 18:17:01 Kristian H. Kristensen wrote: > > On Mon, Oct 5, 2020 at 4:02 PM Daniel Vetter wrote: > > > > > > On Mon, Oct 05, 2020 at 05:24:19PM +0800, Hillf Danton wrote: > > > > > > > > On Sun, 4 Oct 2020 12:21:45 > > > >

Re: [Freedreno] [PATCH 13/14] drm/msm: Drop struct_mutex in shrinker path

2020-10-05 Thread Hillf Danton
On Mon, 5 Oct 2020 18:17:01 Kristian H. Kristensen wrote: > On Mon, Oct 5, 2020 at 4:02 PM Daniel Vetter wrote: > > > > On Mon, Oct 05, 2020 at 05:24:19PM +0800, Hillf Danton wrote: > > > > > > On Sun, 4 Oct 2020 12:21:45 > > > > From: Rob Clark > > > > > > > > Now that the inactive_list is pr

Re: [Freedreno] [PATCH 13/14] drm/msm: Drop struct_mutex in shrinker path

2020-10-05 Thread Daniel Vetter
On Mon, Oct 5, 2020 at 6:49 PM Rob Clark wrote: > > On Mon, Oct 5, 2020 at 7:02 AM Daniel Vetter wrote: > > > > On Mon, Oct 05, 2020 at 05:24:19PM +0800, Hillf Danton wrote: > > > > > > On Sun, 4 Oct 2020 12:21:45 > > > > From: Rob Clark > > > > > > > > Now that the inactive_list is protected b

Re: [Freedreno] [PATCH 13/14] drm/msm: Drop struct_mutex in shrinker path

2020-10-05 Thread Rob Clark
On Mon, Oct 5, 2020 at 7:02 AM Daniel Vetter wrote: > > On Mon, Oct 05, 2020 at 05:24:19PM +0800, Hillf Danton wrote: > > > > On Sun, 4 Oct 2020 12:21:45 > > > From: Rob Clark > > > > > > Now that the inactive_list is protected by mm_lock, and everything > > > else on per-obj basis is protected

Re: [Freedreno] [PATCH 13/14] drm/msm: Drop struct_mutex in shrinker path

2020-10-05 Thread Kristian Høgsberg
On Mon, Oct 5, 2020 at 4:02 PM Daniel Vetter wrote: > > On Mon, Oct 05, 2020 at 05:24:19PM +0800, Hillf Danton wrote: > > > > On Sun, 4 Oct 2020 12:21:45 > > > From: Rob Clark > > > > > > Now that the inactive_list is protected by mm_lock, and everything > > > else on per-obj basis is protected

Re: [Freedreno] [PATCH 13/14] drm/msm: Drop struct_mutex in shrinker path

2020-10-05 Thread Hillf Danton
On Sun, 4 Oct 2020 12:21:45 > From: Rob Clark > > Now that the inactive_list is protected by mm_lock, and everything > else on per-obj basis is protected by obj->lock, we no longer depend > on struct_mutex. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_gem.c | 1 - >

Re: [Freedreno] [PATCH 13/14] drm/msm: Drop struct_mutex in shrinker path

2020-10-05 Thread Daniel Vetter
On Mon, Oct 05, 2020 at 05:24:19PM +0800, Hillf Danton wrote: > > On Sun, 4 Oct 2020 12:21:45 > > From: Rob Clark > > > > Now that the inactive_list is protected by mm_lock, and everything > > else on per-obj basis is protected by obj->lock, we no longer depend > > on struct_mutex. > > > > Sig

[Freedreno] [PATCH 13/14] drm/msm: Drop struct_mutex in shrinker path

2020-10-04 Thread Rob Clark
From: Rob Clark Now that the inactive_list is protected by mm_lock, and everything else on per-obj basis is protected by obj->lock, we no longer depend on struct_mutex. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 1 - drivers/gpu/drm/msm/msm_gem_shrinker.c | 54 -