Re: [Freedreno] [PATCH 1/5] drm/msm: remove unused icc_path/ocmem_icc_path

2021-05-13 Thread Rob Clark
I suppose it could be helpful to reference the commit that removed the icc_get() calls but forgot to remove the (now) disused icc_put() calls.. BR, -R On Thu, May 13, 2021 at 1:02 PM Jonathan Marek wrote: > > There isn't much to explain, these fields just aren't used anymore > (except for the ic

Re: [Freedreno] [PATCH 1/5] drm/msm: remove unused icc_path/ocmem_icc_path

2021-05-13 Thread Jonathan Marek
There isn't much to explain, these fields just aren't used anymore (except for the icc_put() calls which this patch removes). a3xx is using devm_of_icc_get() and only sets the bandwidth once on init. On 5/13/21 7:37 AM, Alexey Minnekhanov wrote: 13.05.2021 03:37, Jonathan Marek: These aren't

Re: [Freedreno] [PATCH 1/5] drm/msm: remove unused icc_path/ocmem_icc_path

2021-05-13 Thread Alexey Minnekhanov
13.05.2021 03:37, Jonathan Marek: These aren't used by anything anymore. Hi, I feel like this needs a bit more explanation, otherwise it looks like just removing support for older hardware. Where and how msm8974's ocmem and icc is handled, and how it should work? -- Regards, Alexey Minnekh

[Freedreno] [PATCH 1/5] drm/msm: remove unused icc_path/ocmem_icc_path

2021-05-12 Thread Jonathan Marek
These aren't used by anything anymore. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 3 --- drivers/gpu/drm/msm/msm_gpu.h | 9 - 2 files changed, 12 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/ad