Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Drop unused members from HW structs

2023-04-20 Thread Dmitry Baryshkov
On 21/04/2023 00:39, Marijn Suijten wrote: On 2023-04-20 08:46:46, Abhinav Kumar wrote: On 4/20/2023 7:33 AM, Dmitry Baryshkov wrote: On 18/04/2023 02:14, Marijn Suijten wrote: Some of these members were initialized while never read, while others were not even assigned any value at all.  Dro

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Drop unused members from HW structs

2023-04-20 Thread Marijn Suijten
On 2023-04-20 08:46:46, Abhinav Kumar wrote: > > > On 4/20/2023 7:33 AM, Dmitry Baryshkov wrote: > > On 18/04/2023 02:14, Marijn Suijten wrote: > >> Some of these members were initialized while never read, while others > >> were not even assigned any value at all.  Drop them to save some space, >

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Drop unused members from HW structs

2023-04-20 Thread Abhinav Kumar
On 4/20/2023 7:33 AM, Dmitry Baryshkov wrote: On 18/04/2023 02:14, Marijn Suijten wrote: Some of these members were initialized while never read, while others were not even assigned any value at all.  Drop them to save some space, and above all confusion when looking at these members. Fixes:

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Drop unused members from HW structs

2023-04-20 Thread Dmitry Baryshkov
On 18/04/2023 02:14, Marijn Suijten wrote: Some of these members were initialized while never read, while others were not even assigned any value at all. Drop them to save some space, and above all confusion when looking at these members. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Drop unused members from HW structs

2023-04-18 Thread Marijn Suijten
On 2023-04-17 18:54:18, Abhinav Kumar wrote: > > On 4/17/2023 4:14 PM, Marijn Suijten wrote: > > Some of these members were initialized while never read, while others > > were not even assigned any value at all. Drop them to save some space, > > and above all confusion when looking at these membe

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Drop unused members from HW structs

2023-04-17 Thread Abhinav Kumar
On 4/17/2023 4:14 PM, Marijn Suijten wrote: Some of these members were initialized while never read, while others were not even assigned any value at all. Drop them to save some space, and above all confusion when looking at these members. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU suppor

[Freedreno] [PATCH 1/3] drm/msm/dpu: Drop unused members from HW structs

2023-04-17 Thread Marijn Suijten
Some of these members were initialized while never read, while others were not even assigned any value at all. Drop them to save some space, and above all confusion when looking at these members. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Fixes: 84a33d0fd921 ("drm/msm/dpu: add dpu_hw