Re: [Freedreno] [PATCH 04/25] drm/msm/dpu: move SSPP debugfs creation to dpu_kms.c

2022-05-03 Thread Abhinav Kumar
On 5/3/2022 3:11 PM, Dmitry Baryshkov wrote: On 04/05/2022 00:34, Abhinav Kumar wrote: On 2/9/2022 9:24 AM, Dmitry Baryshkov wrote: As SSPP blocks are now visible through dpu_kms->rm.sspp_blocks, move SSPP debugfs creation from dpu_plane to dpu_kms. Change is fine by itself, but is it r

Re: [Freedreno] [PATCH 04/25] drm/msm/dpu: move SSPP debugfs creation to dpu_kms.c

2022-05-03 Thread Dmitry Baryshkov
On 04/05/2022 00:34, Abhinav Kumar wrote: On 2/9/2022 9:24 AM, Dmitry Baryshkov wrote: As SSPP blocks are now visible through dpu_kms->rm.sspp_blocks, move SSPP debugfs creation from dpu_plane to dpu_kms. Change is fine by itself, but is it really needed? Wouldnt it be better to keep dpu_de

Re: [Freedreno] [PATCH 04/25] drm/msm/dpu: move SSPP debugfs creation to dpu_kms.c

2022-05-03 Thread Abhinav Kumar
On 2/9/2022 9:24 AM, Dmitry Baryshkov wrote: As SSPP blocks are now visible through dpu_kms->rm.sspp_blocks, move SSPP debugfs creation from dpu_plane to dpu_kms. Change is fine by itself, but is it really needed? Wouldnt it be better to keep dpu_debugfs_sspp_init in dpu_plane.c? Signed-o

[Freedreno] [PATCH 04/25] drm/msm/dpu: move SSPP debugfs creation to dpu_kms.c

2022-02-09 Thread Dmitry Baryshkov
As SSPP blocks are now visible through dpu_kms->rm.sspp_blocks, move SSPP debugfs creation from dpu_plane to dpu_kms. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 19 +++ drivers/gpu/drm/msm/