Re: [Freedreno] [PATCH 02/12] drm/msm/adreno: Remove redundant gmem size param

2023-07-13 Thread Akhil P Oommen
On Fri, Jul 07, 2023 at 01:22:56AM +0200, Konrad Dybcio wrote: > > On 6.07.2023 23:10, Rob Clark wrote: > > From: Rob Clark > > > > Even in the ocmem case, the allocated ocmem buffer size should match the > > requested size. > > > > Signed-off-by: Rob Clark > > --- > [...] > > > + > > + WAR

Re: [Freedreno] [PATCH 02/12] drm/msm/adreno: Remove redundant gmem size param

2023-07-06 Thread Dmitry Baryshkov
On 07/07/2023 00:10, Rob Clark wrote: From: Rob Clark Even in the ocmem case, the allocated ocmem buffer size should match the requested size. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +- drivers/gpu/drm

Re: [Freedreno] [PATCH 02/12] drm/msm/adreno: Remove redundant gmem size param

2023-07-06 Thread Konrad Dybcio
On 6.07.2023 23:10, Rob Clark wrote: > From: Rob Clark > > Even in the ocmem case, the allocated ocmem buffer size should match the > requested size. > > Signed-off-by: Rob Clark > --- [...] > + > + WARN_ON(ocmem_hdl->len != adreno_gpu->info->gmem); I believe this should be an error condit

[Freedreno] [PATCH 02/12] drm/msm/adreno: Remove redundant gmem size param

2023-07-06 Thread Rob Clark
From: Rob Clark Even in the ocmem case, the allocated ocmem buffer size should match the requested size. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers