Re: [Freedreno] [PATCH] drm: msm: Add 680 gpu to the adreno gpu list

2021-07-29 Thread Rob Clark
On Thu, Jul 29, 2021 at 8:53 PM Akhil P Oommen wrote: > > On 7/30/2021 5:38 AM, Rob Clark wrote: > > On Sat, Jul 24, 2021 at 8:21 PM Bjorn Andersson > > wrote: > >> > >> This patch adds a Adreno 680 entry to the gpulist. > > > > Looks reasonable, but I wonder if we should just go ahead and add >

Re: [Freedreno] [PATCH] drm: msm: Add 680 gpu to the adreno gpu list

2021-07-29 Thread Akhil P Oommen
On 7/30/2021 5:38 AM, Rob Clark wrote: On Sat, Jul 24, 2021 at 8:21 PM Bjorn Andersson wrote: This patch adds a Adreno 680 entry to the gpulist. Looks reasonable, but I wonder if we should just go ahead and add adreno_is_a640_family() in a similar vein to adreno_is_a650_familiy()/adreno_is_a

Re: [Freedreno] [PATCH] drm: msm: Add 680 gpu to the adreno gpu list

2021-07-29 Thread Rob Clark
On Sat, Jul 24, 2021 at 8:21 PM Bjorn Andersson wrote: > > This patch adds a Adreno 680 entry to the gpulist. Looks reasonable, but I wonder if we should just go ahead and add adreno_is_a640_family() in a similar vein to adreno_is_a650_familiy()/adreno_is_a660_family().. I think most of the 'if (

[Freedreno] [PATCH] drm: msm: Add 680 gpu to the adreno gpu list

2021-07-24 Thread Bjorn Andersson
This patch adds a Adreno 680 entry to the gpulist. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 5 +++-- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 12 +++- drivers/gpu/drm/msm/adreno/a6xx_hfi.c | 2 +- drivers/gpu/drm/msm/adreno/adreno_device.