Re: [Freedreno] [PATCH] drm/probe_helper: sort out poll_running vs poll_enabled

2023-01-13 Thread Jani Nikula
On Fri, 13 Jan 2023, Dmitry Baryshkov wrote: > On Fri, 13 Jan 2023 at 09:12, Laurentiu Palcu > wrote: >> >> Hi Dmitry, >> >> On Thu, Jan 12, 2023 at 05:42:47PM +0200, Dmitry Baryshkov wrote: >> > There are two flags attemting to guard connector polling: >> > poll_enabled and poll_running. While p

Re: [Freedreno] [PATCH] drm/probe_helper: sort out poll_running vs poll_enabled

2023-01-12 Thread Dmitry Baryshkov
On Fri, 13 Jan 2023 at 09:12, Laurentiu Palcu wrote: > > Hi Dmitry, > > On Thu, Jan 12, 2023 at 05:42:47PM +0200, Dmitry Baryshkov wrote: > > There are two flags attemting to guard connector polling: > > poll_enabled and poll_running. While poll_enabled semantics is clearly > > defined and fully a

Re: [Freedreno] [PATCH] drm/probe_helper: sort out poll_running vs poll_enabled

2023-01-12 Thread Laurentiu Palcu
Hi Dmitry, On Thu, Jan 12, 2023 at 05:42:47PM +0200, Dmitry Baryshkov wrote: > There are two flags attemting to guard connector polling: > poll_enabled and poll_running. While poll_enabled semantics is clearly > defined and fully adhered (mark that drm_kms_helper_poll_init() was > called and not f

Re: [Freedreno] [PATCH] drm/probe_helper: sort out poll_running vs poll_enabled

2023-01-12 Thread Chen-Yu Tsai
On Thu, Jan 12, 2023 at 11:42 PM Dmitry Baryshkov wrote: > > There are two flags attemting to guard connector polling: > poll_enabled and poll_running. While poll_enabled semantics is clearly > defined and fully adhered (mark that drm_kms_helper_poll_init() was > called and not finalized by the _f

Re: [Freedreno] [PATCH] drm/probe_helper: sort out poll_running vs poll_enabled

2023-01-12 Thread Marek Szyprowski
On 12.01.2023 16:42, Dmitry Baryshkov wrote: > There are two flags attemting to guard connector polling: > poll_enabled and poll_running. While poll_enabled semantics is clearly > defined and fully adhered (mark that drm_kms_helper_poll_init() was > called and not finalized by the _fini() call), th

[Freedreno] [PATCH] drm/probe_helper: sort out poll_running vs poll_enabled

2023-01-12 Thread Dmitry Baryshkov
There are two flags attemting to guard connector polling: poll_enabled and poll_running. While poll_enabled semantics is clearly defined and fully adhered (mark that drm_kms_helper_poll_init() was called and not finalized by the _fini() call), the poll_running flag doesn't have such clearliness. T