Re: [Freedreno] [PATCH] drm/msm: Fix MSM_INFO_GET_IOVA with carveout

2021-01-08 Thread Iskren Chernev
On 1/8/21 12:36 AM, Rob Clark wrote: > On Thu, Jan 7, 2021 at 9:20 AM Rob Clark wrote: >> >> On Sat, Jan 2, 2021 at 12:26 PM Iskren Chernev >> wrote: >>> >>> The msm_gem_get_iova should be guarded with gpu != NULL and not aspace >>> != NULL, because aspace is NULL when using vram carveout. >>

Re: [Freedreno] [PATCH] drm/msm: Fix MSM_INFO_GET_IOVA with carveout

2021-01-07 Thread Rob Clark
On Thu, Jan 7, 2021 at 9:20 AM Rob Clark wrote: > > On Sat, Jan 2, 2021 at 12:26 PM Iskren Chernev > wrote: > > > > The msm_gem_get_iova should be guarded with gpu != NULL and not aspace > > != NULL, because aspace is NULL when using vram carveout. > > > > Fixes: 933415e24bd0d ("drm/msm: Add sup

Re: [Freedreno] [PATCH] drm/msm: Fix MSM_INFO_GET_IOVA with carveout

2021-01-07 Thread Rob Clark
On Sat, Jan 2, 2021 at 12:26 PM Iskren Chernev wrote: > > The msm_gem_get_iova should be guarded with gpu != NULL and not aspace > != NULL, because aspace is NULL when using vram carveout. > > Fixes: 933415e24bd0d ("drm/msm: Add support for private address space > instances") > > Signed-off-by: I

Re: [Freedreno] [PATCH] drm/msm: Fix MSM_INFO_GET_IOVA with carveout

2021-01-03 Thread Alexey Minnekhanov
I've tested all recent GPU bring-up patches on msm8974pro samsung-klte (a330v2) and with this patch everything is OK. But without this we're getting the following in dmesg while running kmscube (which is rendering nothing except black screen): [ 94.969272] msm fd90.mdss: [drm:hangcheck_h

Re: [Freedreno] [PATCH] drm/msm: Fix MSM_INFO_GET_IOVA with carveout

2021-01-03 Thread Konrad Dybcio
Kind reminder that MSM8974, 8994, 8992 and friends are held back by the lack of IOMMU support upstream. There has been an attempt back in 2014(!) [1], but it was either overlooked or forgotten about ever since. I'd be more than happy to see someone look into this, as I have some other bits (almo

[Freedreno] [PATCH] drm/msm: Fix MSM_INFO_GET_IOVA with carveout

2021-01-02 Thread Iskren Chernev
The msm_gem_get_iova should be guarded with gpu != NULL and not aspace != NULL, because aspace is NULL when using vram carveout. Fixes: 933415e24bd0d ("drm/msm: Add support for private address space instances") Signed-off-by: Iskren Chernev --- drivers/gpu/drm/msm/msm_drv.c | 3 ++- 1 file cha