Re: [Freedreno] [PATCH v3 3/3] drm/komeda: Fix IS_ERR() vs NULL check in komeda_component_get_avail_scaler()

If you're going to update the other patches to use IS_ERR_OR_NULL() please do so here too. You can keep my R-b for that change. Thanks for taking time to review the patch. I have update the patch set and add this change to v5. On 2023/7/21 18:24, Liviu Dudau wrote: Hi Gaosheng, On Fri, Jul 1

Re: [Freedreno] [PATCH v2 3/3] drm/komeda: Fix IS_ERR() vs NULL check in komeda_component_get_avail_scaler()

Thanks for taking time to review this patch. Maybe we can submit another separate patch to fix ERR_CAST(st), because I'm not sure which commit should be used as a fixes-tag. Also, Maybe we should fix ERR_CAST(st) in komeda_pipeline_get_state_and_set_crtc() and komeda_component_get_state_and_set

Re: [Freedreno] [PATCH 3/5] drm/msm: Fix IS_ERR_OR_NULL() vs NULL check in msm_icc_get()

NAK. This path should be returned if it is NON-NULL, otherwise we defer to of_icc_get() on the parent device. See the code-comment below. Thanks for taking time to review this patch, how do you think of the following changes: diff --git a/drivers/gpu/drm/msm/msm_io_utils.c b/drivers/gpu/drm