[Freedreno] [PATCH linux-next] drm/msm/dsi: Remove the unneeded result variable

2022-08-26 Thread cgel . zte
From: ye xingchen Return the value msm_dsi_phy_enable() directly instead of storing it in another redundant variable. Reported-by: Zeal Robot Signed-off-by: ye xingchen --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gp

[Freedreno] [PATCH] drm/msm/hdmi: fix error check return value of irq_of_parse_and_map()

2022-04-25 Thread cgel . zte
From: Lv Ruyi The irq_of_parse_and_map() function returns 0 on failure, and does not return a negative value anyhow, so never enter this conditional branch. Fixes: f6a8eaca0ea1 ("drm/msm/mdp5: use irqdomains") Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- drivers/gpu/drm/msm/hdmi/hdmi.c

[Freedreno] [PATCH] drm/msm/dpu: fix error check return value of irq_of_parse_and_map()

2022-04-25 Thread cgel . zte
From: Lv Ruyi The irq_of_parse_and_map() function returns 0 on failure, and does not return a negative value anyhow, so never enter this conditional branch. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- drivers/gpu/drm/msm/disp/dpu1

[Freedreno] [PATCH v2] drm/msm/dp: fix error check return value of irq_of_parse_and_map()

2022-04-23 Thread cgel . zte
From: Lv Ruyi The irq_of_parse_and_map() function returns 0 on failure, and does not return an negative value. Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets") Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- v2: don't print rc, and return -EINVAL rather th

[Freedreno] [PATCH v2] drm: msm: fix error check return value of irq_of_parse_and_map()

2022-04-23 Thread cgel . zte
From: Lv Ruyi The irq_of_parse_and_map() function returns 0 on failure, and does not return an negative value. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- v2: don't print irq, and return ERR_PTR(-EINVAL) --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 6 +++--- 1 file changed, 3 inserti

[Freedreno] [PATCH] drm: msm: fix error check return value of irq_of_parse_and_map()

2022-04-22 Thread cgel . zte
From: Lv Ruyi The irq_of_parse_and_map() function returns 0 on failure, and does not return an negative value. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/di

[Freedreno] [PATCH] drm/msm/dp: fix error check return value of irq_of_parse_and_map()

2022-04-22 Thread cgel . zte
From: Lv Ruyi The irq_of_parse_and_map() function returns 0 on failure, and does not return an negative value. Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets") Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- 1

[Freedreno] [PATCH] drm: msm: add null pointer check

2022-03-29 Thread cgel . zte
From: Lv Ruyi kzalloc is a memory allocation function which can return NULL when some internal memory errors happen. Add null pointer check to avoid dereferencing null pointer. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 2 ++ 1 file

[Freedreno] [PATCH] drm/msm: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-12-21 Thread cgel . zte
From: Changcheng Deng Fix the following coccicheck warning: ./drivers/gpu/drm/msm/msm_debugfs.c: 132: 0-23: WARNING: shrink_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for debugfs files. Reported-by: Zeal Robot Signed-of

[Freedreno] [PATCH] drm/msm/dp: remove unneeded variable

2021-12-15 Thread cgel . zte
From: Changcheng Deng Remove unneeded variable used to store return value. Reported-by: Zeal Robot Signed-off-by: Changcheng Deng --- drivers/gpu/drm/msm/dp/dp_display.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/dr

[Freedreno] [PATCH linux-next] drm/msm/dp: remove unneeded variable

2021-11-10 Thread cgel . zte
From: Changcheng Deng Fix the following coccicheck review: ./drivers/gpu/drm/msm/dp/dp_debug.c: Unneeded variable Remove unneeded variable used to store return value. Reported-by: Zeal Robot Signed-off-by: Changcheng Deng --- drivers/gpu/drm/msm/dp/dp_debug.c | 3 +-- 1 file changed, 1 inser

[Freedreno] [PATCH] drm/msm: remove unneeded variable

2021-08-31 Thread cgel . zte
From: Chi Minghao Fix the following coccicheck REVIEW: ./drivers/gpu/drm/msm/edp/edp_ctrl.c:1245:5-8 Unneeded variable Reported-by: Zeal Robot Signed-off-by: Chi Minghao --- drivers/gpu/drm/msm/edp/edp_ctrl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/d