Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-19 Thread Sui Jingfeng
Hi, On 2025/1/20 04:14, Laurent Pinchart wrote: On Mon, Jan 20, 2025 at 12:26:30AM +0800, Sui Jingfeng wrote: On 2025/1/19 23:22, Tomi Valkeinen wrote: On 19/01/2025 16:59, Sui Jingfeng wrote: But userspace must be able to continue allocating YUV buffers through CREATE_DUMB. I think

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-19 Thread Sui Jingfeng
Hi, On 2025/1/16 18:17, Geert Uytterhoeven wrote: On Thu, Jan 16, 2025 at 11:03 AM Tomi Valkeinen wrote: On 16/01/2025 10:09, Thomas Zimmermann wrote: Am 15.01.25 um 15:20 schrieb Tomi Valkeinen: [...] My point is that we have the current UAPI, and we have userspace using it, but we don't ha

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-19 Thread Sui Jingfeng
Hi, On 2025/1/19 23:22, Tomi Valkeinen wrote: On 19/01/2025 16:59, Sui Jingfeng wrote: But userspace must be able to continue allocating YUV buffers through CREATE_DUMB. I think, allocating YUV buffers through CREATE_DUMB interface is just an *abuse* and *misuse* of this API for now. Take

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-19 Thread Sui Jingfeng
Hi, On 2025/1/19 20:18, Tomi Valkeinen wrote: Hi, On 19/01/2025 13:29, Sui Jingfeng wrote: Hi, On 2025/1/16 18:35, Dmitry Baryshkov wrote: On Thu, Jan 16, 2025 at 11:17:50AM +0100, Geert Uytterhoeven wrote: On Thu, Jan 16, 2025 at 11:03 AM Tomi Valkeinen wrote: On 16/01/2025 10:09

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-19 Thread Sui Jingfeng
Hi, On 2025/1/16 18:35, Dmitry Baryshkov wrote: On Thu, Jan 16, 2025 at 11:17:50AM +0100, Geert Uytterhoeven wrote: On Thu, Jan 16, 2025 at 11:03 AM Tomi Valkeinen wrote: On 16/01/2025 10:09, Thomas Zimmermann wrote: Am 15.01.25 um 15:20 schrieb Tomi Valkeinen: [...] My point is that we hav

Re: [PATCH v2 11/25] drm/loongson: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-14 Thread Sui Jingfeng
Hi, On 2025/1/9 22:57, Thomas Zimmermann wrote: Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch according to hardware requirements. Signed-off-by: Thomas Zimmermann Cc: Sui Jingfeng Cc: Sui Jingfeng Reviewed-by: Sui Jingfeng

Re: [PATCH] drm/msm: Check return value of of_dma_configure()

2024-12-01 Thread Sui Jingfeng
Hi, On 2024/11/30 22:51, Markus Elfring wrote: Because the of_dma_configure() will returns '-EPROBE_DEFER' if the probe return? … Stop pretending that it will always suceess, quit if it fail. succeed?

[PATCH] drm/msm: Check return value of of_dma_configure()

2024-11-04 Thread Sui Jingfeng
Because the of_dma_configure() will returns '-EPROBE_DEFER' if the probe procedure of the specific platform IOMMU driver is not finished yet. It can also return other error code for various reasons. Stop pretending that it will always suceess, quit if it fail. Signed-off-by: Su

Re: [v4,08/13] drm/msm/dpu: add support for virtual planes

2024-03-14 Thread Sui Jingfeng
Hi, On 2024/3/14 08:02, Dmitry Baryshkov wrote: [...] +/** + * dpu_rm_reserve_sspp - Reserve the required SSPP for the provided CRTC + * @rm: DPU Resource Manager handle + * @global_state: private global state + * @crtc: DRM CRTC handle + * @reqs: SSPP required features + */ +struct dpu_

Re: [10/13] drm/fbdev-generic: Fix locking with drm_client_buffer_vmap_local()

2024-03-11 Thread Sui Jingfeng
urned iosys_map is another copy of the original backup, we can play with this local variable at will, there no need to duplicate another time again. I have modified and tested with fbdev generic, no problem. With this trivial issue resolved. For fbdev-generic: Acked-by: Sui Jingfeng

Re: [09/13] drm/gem: Acquire reservation lock in drm_gem_{pin/unpin}()

2024-03-11 Thread Sui Jingfeng
Signed-off-by: Thomas Zimmermann Reviewed-by: Zack Rusin Tested with drm/loongson, play with a few days. Switch to virtual terminal, then switch back is fine. not found problems yet. So, Tested-by: Sui Jingfeng

Re: [Freedreno] [PATCH v6 0/6] drm: simplify support for transparent DRM bridges

2023-11-22 Thread Sui Jingfeng
Hi, On 2023/11/4 07:03, Dmitry Baryshkov wrote: Supporting DP/USB-C can result in a chain of several transparent bridges (PHY, redrivers, mux, etc). All attempts to implement DP support in a different way resulted either in series of hacks or in device tree not reflecting the actual hardware de

Re: [Freedreno] [v6,1/6] drm/bridge: add transparent bridge helper

2023-11-22 Thread Sui Jingfeng
Hi, On 2023/11/4 07:03, Dmitry Baryshkov wrote: Define a helper for creating simple transparent bridges which serve the only purpose of linking devices into the bridge chain up to the last bridge representing the connector. As far as I can tell, traditionally, transparent display bridges are

Re: [Freedreno] [2/2] drm: Remove struct drm_driver.gem_prime_mmap

2023-06-17 Thread Sui Jingfeng
Hi, On 2023/6/14 13:34, Thomas Zimmermann wrote: Hi Am 14.06.23 um 04:06 schrieb Sui Jingfeng: On 2023/6/14 01:27, Sui Jingfeng wrote: Wow, so many drivers get nuked! On 2023/6/13 22:51, Thomas Zimmermann wrote: All drivers initialize this field with drm_gem_prime_mmap(). Call the

Re: [Freedreno] [2/2] drm: Remove struct drm_driver.gem_prime_mmap

2023-06-17 Thread Sui Jingfeng
On 2023/6/14 01:27, Sui Jingfeng wrote: Wow, so many drivers get nuked! On 2023/6/13 22:51, Thomas Zimmermann wrote: All drivers initialize this field with drm_gem_prime_mmap(). Call the function directly and remove the field. Simplifies the code and resolves a long-standing TODO item

Re: [Freedreno] [2/2] drm: Remove struct drm_driver.gem_prime_mmap

2023-06-17 Thread Sui Jingfeng
Wow, so many drivers get nuked! On 2023/6/13 22:51, Thomas Zimmermann wrote: All drivers initialize this field with drm_gem_prime_mmap(). Call the function directly and remove the field. Simplifies the code and resolves a long-standing TODO item. Signed-off-by: Thomas Zimmermann Reviewed-by: A

Re: [Freedreno] [v2, 11/12] drm/fbdev-generic: Implement dedicated fbdev I/O helpers

2023-05-16 Thread Sui Jingfeng
Hi, Thomas After apply your patch set, the kernel with arch/loongarch/configs/loongson3_defconfig can not finish compile anymore.  gcc complains:   AR  drivers/gpu/built-in.a   AR  drivers/built-in.a   AR  built-in.a   AR  vmlinux.a   LD  vmlinux.o   OBJCOPY modules.buil

Re: [Freedreno] [v2,1/8] drm/msm: Include

2023-04-03 Thread Sui Jingfeng
Reviewed-by:  Sui Jingfeng On 2023/4/3 20:45, Thomas Zimmermann wrote: Include to get the declaration of devm_ioremap() on sparc64. No functional changes. Signed-off-by: Thomas Zimmermann Reported-by: kernel test robot Link: https://lore.kernel.org/oe-kbuild-all/202303301856.zsmpwzjj