Assign DSI clock source parents to DSI PHY clocks.
Signed-off-by: Rajeev Nandan
Cc: Dmitry Baryshkov
---
This change is needed after the refactor done by the patch [2]
(drm/msm/dsi: stop setting clock parents manually) of series [1],
to fix the DSI pixel clock set rate error
in v5:
- Fixed missing printk arg
Rajeev Nandan (3):
dt-bindings: msm/dsi: Add 10nm dsi phy tuning properties
drm/msm/dsi: Add dsi phy tuning configuration support
drm/msm/dsi: Add 10nm dsi phy tuning configuration support
.../bindings/display/msm/dsi-phy-10nm.yaml | 36 +++
dr
clock and data lanes have a calibration circuitry feature. The drive
strength tuning can be done by adjusting rescode offset for hstop/hsbot,
and the drive level tuning can be done by adjusting the LDO output level
for the HSTX drive.
Signed-off-by: Rajeev Nandan
---
Changes in v2:
- More details
.
Signed-off-by: Rajeev Nandan
---
Changes in v2:
- Split into generic code and 10nm-specific part (Dmitry Baryshkov)
- Fix the backward compatibility (Dmitry Baryshkov)
Changes in v3:
- Address comments for phy tuning data structure (Dmitry Baryshkov)
- Make changes as per updated dt-bindings
Add support for MSM DSI PHY tuning configuration. Current design is
to support drive strength and drive level/amplitude tuning for
10nm PHY version, but this can be extended to other PHY versions.
Signed-off-by: Rajeev Nandan
Reviewed-by: Dmitry Baryshkov
---
Changes in v2:
- New.
- Split
Add support for MSM DSI PHY tuning configuration. Current design is
to support drive strength and drive level/amplitude tuning for
10nm PHY version, but this can be extended to other PHY versions.
Signed-off-by: Rajeev Nandan
Reviewed-by: Dmitry Baryshkov
---
Changes in v2:
- New.
- Split
clock and data lanes have a calibration circuitry feature. The drive
strength tuning can be done by adjusting rescode offset for hstop/hsbot,
and the drive level tuning can be done by adjusting the LDO output level
for the HSTX drive.
Signed-off-by: Rajeev Nandan
---
Changes in v2:
- More details
.
Signed-off-by: Rajeev Nandan
---
Changes in v2:
- Split into generic code and 10nm-specific part (Dmitry Baryshkov)
- Fix the backward compatibility (Dmitry Baryshkov)
Changes in v3:
- Address comments for phy tuning data structure (Dmitry Baryshkov)
- Make changes as per updated dt-bindings
(Dmitry Baryshkov)
- s/ops.tuning_cfg_init/ops.parse_dt_properties (Dmitry Baryshkov)
Changes in v4:
- Fixed dt_binding_check error (Rob Herring's bot)
- Return error in case of out of range values (Dmitry Baryshkov)
- Return error if dt property is present but parsing is failing
Rajeev Nand
Add support for MSM DSI PHY tuning configuration. Current design is
to support drive strength and drive level/amplitude tuning for
10nm PHY version, but this can be extended to other PHY versions.
Signed-off-by: Rajeev Nandan
---
Changes in v2:
- New.
- Split into generic code and 10nm
.
Signed-off-by: Rajeev Nandan
---
Changes in v2:
- Split into generic code and 10nm-specific part (Dmitry Baryshkov)
- Fix the backward compatibility (Dmitry Baryshkov)
Changes in v3:
- Address comments for phy tuning data structure (Dmitry Baryshkov)
- Make changes as per updated dt-bindings
clock and data lanes have a calibration circuitry feature. The drive
strength tuning can be done by adjusting rescode offset for hstop/hsbot,
and the drive level tuning can be done by adjusting the LDO output level
for the HSTX drive.
Signed-off-by: Rajeev Nandan
---
Changes in v2:
- More details
(Dmitry Baryshkov)
- s/ops.tuning_cfg_init/ops.parse_dt_properties (Dmitry Baryshkov)
Rajeev Nandan (3):
dt-bindings: msm/dsi: Add 10nm dsi phy tuning properties
drm/msm/dsi: Add dsi phy tuning configuration support
drm/msm/dsi: Add 10nm dsi phy tuning configuration support
.../bindings
Hi Dmitry,
>
> On Wed, 12 Jan 2022 at 19:09, Rajeev Nandan
> wrote:
> >
> > Hi Dmitry,
> >
> > > >
> > > > + if (phy->cfg->ops.tuning_cfg_init)
> > > > + phy->cfg->ops.tuning_cfg_init(phy);
> >
Hi Dmitry, Rob,
Thanks for the review.
>
> On Mon, Jan 10, 2022 at 05:06:03PM +0300, Dmitry Baryshkov wrote:
> > On Mon, 10 Jan 2022 at 15:56, Rajeev Nandan
> wrote:
> > >
> > > In most cases, the default values of DSI PHY tuning registers should
> > >
Hi Dmitry,
> >
> > + if (phy->cfg->ops.tuning_cfg_init)
> > + phy->cfg->ops.tuning_cfg_init(phy);
>
> Please rename to parse_dt_properties() or something like that.
Sure. I didn't understand your comment in v1 to use config_dt() hook. I think,
now I understood.
This function
comments (Stephen Boyd, Dmitry Baryshkov)
- Split into generic code and 10nm-specific part (Dmitry Baryshkov)
- Fix the backward compatibility (Dmitry Baryshkov)
Rajeev Nandan (3):
dt-bindings: msm/dsi: Add 10nm dsi phy tuning properties
drm/msm/dsi: Add dsi phy tuning configuration support
Add support for MSM DSI PHY tuning configuration. Current design is
to support drive strength and drive level/amplitude tuning for
10nm PHY version, but this can be extended to other PHY versions.
Signed-off-by: Rajeev Nandan
---
Changes in v2:
- New.
- Split into generic code and 10nm
.
Signed-off-by: Rajeev Nandan
---
Changes in v2:
- Split into generic code and 10nm-specific part (Dmitry Baryshkov)
- Fix the backward compatibility (Dmitry Baryshkov)
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 51 ++
1 file changed, 45 insertions(+), 6 deletions
clock and data lanes have a calibration circuitry feature. The drive
strength tuning can be done by adjusting rescode offset for hstop/hsbot,
and the drive level tuning can be done by adjusting the LDO output level
for the HSTX drive.
Signed-off-by: Rajeev Nandan
---
Changes in v2:
- More details
s if needed.
Signed-off-by: Rajeev Nandan
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 55 ++
drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 23 +
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 31 +
3 files changed, 103 insertions(+), 6 delet
Add 10nm dsi phy tuning properties for phy drive strength and
phy drive level adjustemnt.
Signed-off-by: Rajeev Nandan
---
.../devicetree/bindings/display/msm/dsi-phy-10nm.yaml | 19 +++
1 file changed, 19 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/msm
CTRL
register.
Add DSI PHY tuning support for 10nm PHY. This can be extended to other
DSI PHY versions if needed. Number of registers to configure the PHY
tuning per lane can be different for different versions of the DSI PHY.
I tried to make it generic so that it can be extended to other versions.
Ra
Do not give a warning for the eDP panels if the "bus_format" is
not specified, since most eDP panels can support more than one
bus formats and this can be auto-detected.
Also, update the check to include bpc=10 for the eDP panel.
Signed-off-by: Rajeev Nandan
---
Changes in v8:
- New
o the case when drm_panel_of_backlight() is used.
Currently, we are not supporting one feature where the source
device can combine the backlight brightness levels set through
DP AUX and the BL_PWM_DIM eDP connector pin. Since it's not
required for the basic backlight controls, it can be added later.
S
If there is no backlight specified in the device tree and the panel
has access to the DP AUX channel then create a DP AUX backlight if
supported by the panel.
Signed-off-by: Rajeev Nandan
Reviewed-by: Douglas Anderson
---
(no changes since v5)
This patch depends on the previous patch (2/5) of
Some panels datasheets may specify a delay between the enable GPIO and
the regulator. Support this in panel-simple.
Signed-off-by: Rajeev Nandan
Reviewed-by: Douglas Anderson
---
(no changes since v6)
Changes in v4:
- New
Changes in v5:
- Update description (Douglas)
- Warn if
//lore.kernel.org/dri-devel/1619416756-3533-1-git-send-email-rajee...@codeaurora.org/
Rajeev Nandan (6):
drm/panel: add basic DP AUX backlight support
drm/panel-simple: Support DP AUX backlight
drm/panel-simple: Support for delays between GPIO & regulator
drm/panel-simple: Update validati
Add Samsung 13.3" FHD eDP AMOLED panel.
Signed-off-by: Rajeev Nandan
Reviewed-by: Douglas Anderson
---
(No changes since v7)
Changes in v4:
- New
Changes in v5:
- Remove "uses_dpcd_backlight" property, not required now. (Douglas)
Changes in v7:
- Update disable_t
Add Samsung 13.3" FHD eDP AMOLED panel.
Signed-off-by: Rajeev Nandan
Reviewed-by: Douglas Anderson
Acked-by: Rob Herring
---
(no changes since v4)
Changes in v4:
- New
Documentation/devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --
The SC7280 SoC uses the 7nm (V4.1) DSI PHY driver with
different enable|disable regulator loads.
Signed-off-by: Rajeev Nandan
Reviewed-by: Dmitry Baryshkov
---
Changes in v2:
- Fixed clang warning for max_pll_rate as per [1] (Dmitry Baryshkov)
- Fixed num_dsi_phy and io_start (Dmitry Baryshkov
Add support for v2.5.0 DSI block in the SC7280 SoC.
Signed-off-by: Rajeev Nandan
Reviewed-by: Dmitry Baryshkov
---
(no changes since v1)
drivers/gpu/drm/msm/dsi/dsi_cfg.c | 20
drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 +
2 files changed, 21 insertions(+)
diff --git a
The SC7280 SoC uses the 7nm (V4.1) DSI PHY driver.
Signed-off-by: Rajeev Nandan
---
Changes in v2:
- New
This patch depends on [1] (dt-bindings: msm: dsi: add missing 7nm bindings)
[1]
https://lore.kernel.org/linux-arm-msm/20210617144349.28448-2-jonat...@marek.ca/
Documentation/devicetree
ernel.org/linux-arm-msm/20210617144349.28448-2-jonat...@marek.ca/
[2]
https://lore.kernel.org/linux-arm-msm/20210514213032.575161-1-a...@kernel.org/
Rajeev Nandan (3):
dt-bindings: msm/dsi: Add sc7280 7nm dsi phy
drm/msm/dsi: Add PHY configuration for SC7280
drm/msm/dsi: Add DSI
If there is no backlight specified in the device tree and the panel
has access to the DP AUX channel then create a DP AUX backlight if
supported by the panel.
Signed-off-by: Rajeev Nandan
Reviewed-by: Douglas Anderson
---
(no changes since v5)
This patch depends on the previous patch (2/5) of
Add Samsung 13.3" FHD eDP AMOLED panel.
Signed-off-by: Rajeev Nandan
Reviewed-by: Douglas Anderson
---
Changes in v4:
- New
Changes in v5:
- Remove "uses_dpcd_backlight" property, not required now. (Douglas)
Changes in v7:
- Update disable_to_power_off and power_to_enable d
Add Samsung 13.3" FHD eDP AMOLED panel.
Signed-off-by: Rajeev Nandan
Reviewed-by: Douglas Anderson
Acked-by: Rob Herring
---
(no changes since v4)
Changes in v4:
- New
Documentation/devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --
diand...@chromium.org/
[2] https://lore.kernel.org/dri-devel/20210514181504.565252-1-ly...@redhat.com/
[3]
https://lore.kernel.org/dri-devel/1619416756-3533-1-git-send-email-rajee...@codeaurora.org/
Rajeev Nandan (5):
drm/panel: add basic DP AUX backlight support
drm/panel-simple: Support D
Some panels datasheets may specify a delay between the enable GPIO and
the regulator. Support this in panel-simple.
Signed-off-by: Rajeev Nandan
Reviewed-by: Douglas Anderson
---
(no changes since v6)
Changes in v4:
- New
Changes in v5:
- Update description (Douglas)
- Warn if
o the case when drm_panel_of_backlight() is used.
Currently, we are not supporting one feature where the source
device can combine the backlight brightness levels set through
DP AUX and the BL_PWM_DIM eDP connector pin. Since it's not
required for the basic backlight controls, it can be added later.
S
If there is no backlight specified in the device tree and the panel
has access to the DP AUX channel then create a DP AUX backlight if
supported by the panel.
Signed-off-by: Rajeev Nandan
Reviewed-by: Douglas Anderson
---
(no changes since v5)
This patch depends on the previous patch (2/5) of
o the case when drm_panel_of_backlight() is used.
Currently, we are not supporting one feature where the source
device can combine the backlight brightness levels set through
DP AUX and the BL_PWM_DIM eDP connector pin. Since it's not
required for the basic backlight controls, it can be added later.
S
Some panels datasheets may specify a delay between the enable GPIO and
the regulator. Support this in panel-simple.
Signed-off-by: Rajeev Nandan
Reviewed-by: Douglas Anderson
---
Changes in v4:
- New
Changes in v5:
- Update description (Douglas)
- Warn if "power_to_enabl
Add Samsung 13.3" FHD eDP AMOLED panel.
Signed-off-by: Rajeev Nandan
Reviewed-by: Douglas Anderson
---
(no changes since v5)
Changes in v4:
- New
Changes in v5:
- Remove "uses_dpcd_backlight" property, not required now. (Douglas)
drivers/gpu/drm/panel/pane
Add Samsung 13.3" FHD eDP AMOLED panel.
Signed-off-by: Rajeev Nandan
Reviewed-by: Douglas Anderson
Acked-by: Rob Herring
---
(no changes since v4)
Changes in v4:
- New
Documentation/devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --
6756-3533-1-git-send-email-rajee...@codeaurora.org/
Rajeev Nandan (5):
drm/panel: add basic DP AUX backlight support
drm/panel-simple: Support DP AUX backlight
drm/panel-simple: Support for delays between GPIO & regulator
dt-bindings: display: simple: Add Samsung ATNA33XC20
drm/panel-
Add support for v2.5.0 DSI block in the SC7280 SoC.
Signed-off-by: Rajeev Nandan
---
drivers/gpu/drm/msm/dsi/dsi_cfg.c | 20
drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 +
2 files changed, 21 insertions(+)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c
b/drivers/gpu/drm/msm
The SC7280 SoC uses the 7nm (V4.1) DSI PHY driver with
different enable|disable regulator loads.
Signed-off-by: Rajeev Nandan
---
drivers/gpu/drm/msm/Kconfig | 6 +++---
drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 ++
drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 1 +
drivers
Add YAML schema for the device tree bindings for MSM 7nm DSI PHY driver.
Cc: Jonathan Marek
Signed-off-by: Rajeev Nandan
---
.../bindings/display/msm/dsi-phy-7nm.yaml | 68 ++
1 file changed, 68 insertions(+)
create mode 100644
Documentation/devicetree/bindings
Changes in this series add support for MSM display DSI CTRL & PHY drivers
for the SC7280 SoC, which has DSI controller v2.5.0 and DSI PHY v4.1.
This series also updates the missing bindings (yaml) for the 7nm DSI PHY
driver on "msm-next" branch.
Rajeev Nandan (3):
dt-bindings
l.org/dri-devel/20210525000159.3384921-1-diand...@chromium.org/
[2] https://lore.kernel.org/dri-devel/20210514181504.565252-1-ly...@redhat.com/
[3]
https://lore.kernel.org/dri-devel/1619416756-3533-1-git-send-email-rajee...@codeaurora.org/
Rajeev Nandan (5):
drm/panel: add basic DP AUX backlight support
d
o the case when drm_panel_of_backlight() is used.
Currently, we are not supporting one feature where the source
device can combine the backlight brightness levels set through
DP AUX and the BL_PWM_DIM eDP connector pin. Since it's not
required for the basic backlight controls, it can be added later.
S
Some panels datasheets may specify a delay between the enable GPIO and
the regulator. Support this in panel-simple.
Signed-off-by: Rajeev Nandan
---
Changes in v4:
- New
Changes in v5:
- Update description (Douglas)
- Warn if "power_to_enable" or "disable_to_power_off" is
Add Samsung 13.3" FHD eDP AMOLED panel.
Signed-off-by: Rajeev Nandan
Reviewed-by: Douglas Anderson
---
Changes in v4:
- New
Changes in v5:
- Remove "uses_dpcd_backlight" property, not required now. (Douglas)
drivers/gpu/drm/panel/panel-simple.c | 33 ++
Add Samsung 13.3" FHD eDP AMOLED panel.
Signed-off-by: Rajeev Nandan
Reviewed-by: Douglas Anderson
---
(no changes since v4)
Changes in v4:
- New
Documentation/devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devic
If there is no backlight specified in the device tree and the panel
has access to the DP AUX channel then create a DP AUX backlight if
supported by the panel.
Signed-off-by: Rajeev Nandan
---
This patch depends on [1] (drm/panel: panel-simple: Stash DP AUX bus;
allow using it for DDC) and the
Some panels datasheets may specify a delay between the enable GPIO and
the regulator. Support this in panel-simple.
Signed-off-by: Rajeev Nandan
---
Changes in v4:
- New
drivers/gpu/drm/panel/panel-simple.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/drivers
Add basic support of panel backlight control over eDP aux channel
using VESA's standard backlight control interface.
Signed-off-by: Rajeev Nandan
---
This patch depends on [1] (drm/panel: panel-simple: Stash DP AUX bus;
allow using it for DDC)
Changes in v4:
- New
[1]
Add Samsung 13.3" FHD eDP AMOLED panel.
Signed-off-by: Rajeev Nandan
---
Changes in v4:
- New
drivers/gpu/drm/panel/panel-simple.c | 34 ++
1 file changed, 34 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c
b/drivers/gpu/drm/panel/
Add Samsung 13.3" FHD eDP AMOLED panel.
Signed-off-by: Rajeev Nandan
---
Changes in v4:
- New
Documentation/devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.ya
regulator.
[1]
https://lore.kernel.org/dri-devel/20210525000159.3384921-1-diand...@chromium.org/
[2] https://lore.kernel.org/dri-devel/20210514181504.565252-1-ly...@redhat.com/
[3]
https://lore.kernel.org/dri-devel/1619416756-3533-1-git-send-email-rajee...@codeaurora.org/
Rajeev Nandan (4):
drm/pa
ned-off-by: Rajeev Nandan
---
drivers/video/backlight/Kconfig| 7 +
drivers/video/backlight/Makefile | 1 +
drivers/video/backlight/dp_aux_backlight.c | 245 +
3 files changed, 253 insertions(+)
create mode 100644 drivers/video/backlight/dp_aux_b
Add bindings for DisplayPort aux backlight driver.
Changes in v2:
- New
Signed-off-by: Rajeev Nandan
---
.../bindings/leds/backlight/dp-aux-backlight.yaml | 49 ++
1 file changed, 49 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds/backlight/dp-aux
- Add missing ';' to fix module compilation (kernel test bot)
[1]
https://lore.kernel.org/dri-devel/20210416223950.3586967-1-diand...@chromium.org/
Rajeev Nandan (2):
dt-bindings: backlight: add DisplayPort aux backlight
backlight: Add DisplayPort aux backlight driver
.../bindings
Add backlight driver for the panels supporting backlight control
using DPCD registers on the DisplayPort aux channel.
Changes in v2:
- New (most of the code reused from drm_dp_aux_backlight.c of v1)
Signed-off-by: Rajeev Nandan
---
drivers/video/backlight/Kconfig| 7 +
drivers
Add bindings for DisplayPort aux backlight driver.
Changes in v2:
- New
Signed-off-by: Rajeev Nandan
---
.../bindings/leds/backlight/dp-aux-backlight.yaml | 49 ++
1 file changed, 49 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds/backlight/dp-aux
https://lore.kernel.org/dri-devel/20210416223950.3586967-1-diand...@chromium.org/
Rajeev Nandan (2):
dt-bindings: backlight: add DisplayPort aux backlight
backlight: Add DisplayPort aux backlight driver
.../bindings/leds/backlight/dp-aux-backlight.yaml | 49 +
drivers/video/backlight/Kc
.
Rajeev Nandan (3):
drm/dp: Add DisplayPort aux backlight control support
dt-bindings: drm/bridge: ti-sn65dsi86: Document use-aux-backlight
drm/bridge: ti-sn65dsi86: Add DisplayPort aux backlight support
.../bindings/display/bridge/ti,sn65dsi86.yaml | 8 +
drivers/gpu/drm/Kconfig
Add panel backlight control using DPCD registers on the DisplayPort aux
channel.
Signed-off-by: Rajeev Nandan
---
drivers/gpu/drm/Kconfig| 8 ++
drivers/gpu/drm/Makefile | 1 +
drivers/gpu/drm/drm_dp_aux_backlight.c | 191
Add support to control the backlight of the eDP panel connected to
the ti-sn65dsi86 bridge through aux channel.
Signed-off-by: Rajeev Nandan
---
drivers/gpu/drm/bridge/Kconfig| 1 +
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 26 ++
2 files changed, 27 insertions
If the panel connected to the bridge supports backlight control
using DPCD registers on the DisplayPort aux channel, setting
"use-aux-backlight" property in the bridge node will enable the
registration of a DP aux backlight device from the bridge driver.
Signed-off-by: Raj
71 matches
Mail list logo
