Re: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used

2024-03-26 Thread Miguel Ojeda
On Tue, Mar 26, 2024 at 8:56 PM Abhinav Kumar wrote: > > Alright, in that case, Miguel can you please repost this with the Fixes > tags and in a patch form. Done at https://lore.kernel.org/lkml/20240326212324.185832-1-oj...@kernel.org/ Thanks all! Cheers, Miguel

[PATCH] drm/msm: fix the `CRASHDUMP_READ` target of `a6xx_get_shader_block()`

2024-03-26 Thread Miguel Ojeda
.com/ [2] Link: https://lore.kernel.org/lkml/20240307093727.1978126-1-colin.i.k...@gmail.com/ [3] Signed-off-by: Miguel Ojeda --- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/dri

Re: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used

2024-03-26 Thread Miguel Ojeda
On Tue, Mar 26, 2024 at 7:31 PM Abhinav Kumar wrote: > > This should be fixed with https://patchwork.freedesktop.org/patch/581853/. Ah, so in that case the `CRASHDUMP_READ` target should really be constant, unlike in other cases in that file? > We can pickup that one with a Fixes tag applied. T

drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used

2024-03-26 Thread Miguel Ojeda
Hi, In today's next, I got: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used [-Werror,-Wunused-but-set-variable] `out` seems to be there since commit 64d6255650d4 ("drm/msm: More fully implement devcoredump for a7xx"). Untested diff below assuming `d

Re: [Freedreno] [PATCH v2] dt-bindings: display: Drop unneeded quotes

2023-03-21 Thread Miguel Ojeda
On Tue, Mar 21, 2023 at 12:38 AM Rob Herring wrote: > > .../bindings/auxdisplay/holtek,ht16k33.yaml | 2 +- Acked-by: Miguel Ojeda Cheers, Miguel