Re: [RFC PATCH v3 01/23] drm: Don't treat 0 as -1 in drm_fixp2int_ceil

2023-12-08 Thread Melissa Wen
On 12/06, Melissa Wen wrote: > On 11/08, Harry Wentland wrote: > > Unit testing this in VKMS shows that passing 0 into > > this function returns -1, which is highly counter- > > intuitive. Fix it by checking whether the input is > > >= 0 instead of > 0. > >

Re: [Freedreno] [PATCH v2 16/21] drm/vgem: Introduce GEM object functions

2020-09-17 Thread Melissa Wen
l to convert. > > Signed-off-by: Thomas Zimmermann Thanks here again. This drv file is little tumultuous to me. I mean, I took a while to sort functions in my head. However, finally, I got it, and the change looks good. Reviewed-by: Melissa Wen > --- > drivers/gpu/

Re: [Freedreno] [PATCH v2 18/21] drm/vkms: Introduce GEM object functions

2020-09-17 Thread Melissa Wen
e. Reviewed-by: Melissa Wen > --- > drivers/gpu/drm/vkms/vkms_drv.c | 8 > drivers/gpu/drm/vkms/vkms_gem.c | 13 + > 2 files changed, 13 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c &