Re: [PATCH] drm/msm/gpu: Check the status of registration to PM QoS

2024-10-18 Thread Lukasz Luba
On 10/18/24 13:02, Dmitry Baryshkov wrote: On Fri, Oct 18, 2024 at 12:18:11PM +0100, Lukasz Luba wrote: There is a need to check the returned value of the registration function. Why? The question can be: why this driver doesn't check errors from frameworks during the registration?

[PATCH] drm/msm/gpu: Check the status of registration to PM QoS

2024-10-18 Thread Lukasz Luba
There is a need to check the returned value of the registration function. In case of returned error, print that and stop the init process. Fixes: 7c0ffcd40b16 ("drm/msm/gpu: Respect PM QoS constraints") Signed-off-by: Lukasz Luba --- drivers/gpu/drm/msm/msm_gpu_devfreq.c | 9 +++

Re: [Freedreno] [PATCH] devfreq: Register devfreq as a cooling device

2021-03-04 Thread Lukasz Luba
On 3/4/21 4:53 PM, Daniel Lezcano wrote: Hi Lukasz, thanks for commenting this patch, On 04/03/2021 14:47, Lukasz Luba wrote: Hi Daniel, On 3/4/21 12:50 PM, Daniel Lezcano wrote: Currently the default behavior is to manually having the devfreq backend to register themselves as a devfreq

Re: [Freedreno] [PATCH] devfreq: Register devfreq as a cooling device

2021-03-04 Thread Lukasz Luba
Hi Daniel, On 3/4/21 12:50 PM, Daniel Lezcano wrote: Currently the default behavior is to manually having the devfreq backend to register themselves as a devfreq cooling device. There are no so many and actually it makes more sense to register the devfreq device when adding it. Consequently, e