Re: [Freedreno] [PATCH v2 0/3] drm/msm/gpu: Devfreq fixes+tuning

2023-01-13 Thread Chia-I Wu
Series is Reviewed-by: Chia-I Wu On Tue, Jan 10, 2023 at 3:14 PM Rob Clark wrote: > > From: Rob Clark > > Rob Clark (3): > drm/msm/gpu: Add devfreq tuning debugfs > drm/msm/gpu: Bypass PM QoS constraint for idle clamp > drm/msm/gpu: Add default devfreq thresholds

Re: [Freedreno] [PATCH] drm/msm: Enable clamp_to_idle for 7c3

2022-11-15 Thread Chia-I Wu
adreno/a6xx_gpu.c | 14 +++--- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > Reviewed-by: Douglas Anderson Reviewed-by: Chia-I Wu

Re: [Freedreno] [PATCH v3 2/2] drm/msm: Hangcheck progress detection

2022-11-09 Thread Chia-I Wu
u; > int id; > @@ -64,6 +69,25 @@ struct msm_ringbuffer { > uint64_t memptrs_iova; > struct msm_fence_context *fctx; > > + /** > +* hangcheck_progress_retries: > +* > +* The number of extra hangcheck duration cycles that we have given > +

Re: [Freedreno] [PATCH 0/3] drm/msm/a6xx: devcore dump fixes

2022-10-13 Thread Chia-I Wu
On Thu, Oct 13, 2022 at 3:55 PM Rob Clark wrote: > > From: Rob Clark > > First patch fixes a recently introduced memory corruption, the remaining > two are cleanups. Series is Reviewed-by: Chia-I Wu > Rob Clark (3): > drm/msm/a6xx: Fix kvzalloc vs state_kcalloc usage &

Re: [Freedreno] [PATCH] drm/msm/gem: Unpin objects slightly later

2022-09-29 Thread Chia-I Wu
e shrinker to evict an > obj queued up in gpu scheduler.) > > Fixes: f371bcc0c2ac ("drm/msm/gem: Unpin buffers earlier") > Fixes: 025d27239a2f ("drm/msm/gem: Evict active GEM objects when necessary") > Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/19 >

Re: [Freedreno] [PATCH v2] drm/msm/adreno: Allow larger address space size

2022-06-11 Thread Chia-I Wu
s. > > Also, add a modparam override for debugging and igt. > > v2: Send the right version of the patch (ie. the one that actually > compiles) > > Signed-off-by: Rob Clark Reviewed-by: Chia-I Wu

Re: [Freedreno] [PATCH v2] drm/msm: add trace_dma_fence_emit to msm_gpu_submit

2022-04-27 Thread Chia-I Wu
On Wed, Apr 27, 2022 at 9:07 AM Rob Clark wrote: > > On Tue, Apr 26, 2022 at 11:20 PM Christian König > wrote: > > > > Am 26.04.22 um 20:50 schrieb Chia-I Wu: > > > On Tue, Apr 26, 2022 at 11:02 AM Christian König > > > wrote: > > >> Am

Re: [Freedreno] [PATCH v2] drm/msm: add trace_dma_fence_emit to msm_gpu_submit

2022-04-26 Thread Chia-I Wu
On Tue, Apr 26, 2022 at 11:02 AM Christian König wrote: > > Am 26.04.22 um 19:40 schrieb Chia-I Wu: > > [SNIP] > >>>> Well I just send a patch to completely remove the trace point. > >>>> > >>>> As I said it absolutely doesn't ma

Re: [Freedreno] [PATCH v2] drm/msm: add trace_dma_fence_emit to msm_gpu_submit

2022-04-26 Thread Chia-I Wu
König > >>> wrote: > >>>> Am 26.04.22 um 18:32 schrieb Chia-I Wu: > >>>>> On Tue, Apr 12, 2022 at 2:26 PM Chia-I Wu wrote: > >>>>>> In practice, trace_dma_fence_init called from dma_fence_init is good > >>>

Re: [Freedreno] [PATCH v2] drm/msm: add trace_dma_fence_emit to msm_gpu_submit

2022-04-26 Thread Chia-I Wu
On Tue, Apr 12, 2022 at 2:26 PM Chia-I Wu wrote: > > In practice, trace_dma_fence_init called from dma_fence_init is good > enough and almost no driver calls trace_dma_fence_emit. But drm_sched > and virtio both have cases where trace_dma_fence_init and > trace_dma_fence_emit ca

Re: [Freedreno] [PATCH 3/3] drm/msm: return the average load over the polling period

2022-04-15 Thread Chia-I Wu
On Fri, Apr 15, 2022 at 5:33 PM Chia-I Wu wrote: > > simple_ondemand interacts poorly with clamp_to_idle. It only looks at > the load since the last get_dev_status call, while it should really look > at the load over polling_ms. When clamp_to_idle true, it almost always > p

[Freedreno] [PATCH 3/3] drm/msm: return the average load over the polling period

2022-04-15 Thread Chia-I Wu
msm_devfreq_idle/msm_devfreq_active. This logic could potentially be moved into devfreq core. Fixes: 7c0ffcd40b16 ("drm/msm/gpu: Respect PM QoS constraints") Signed-off-by: Chia-I Wu Cc: Rob Clark --- drivers/gpu/drm/msm/msm_gpu.h | 3 ++ drivers/gpu/drm/msm/msm_gpu_devf

[Freedreno] [PATCH 2/3] drm/msm: simplify gpu_busy callback

2022-04-15 Thread Chia-I Wu
Move tracking and busy time calculation to msm_devfreq_get_dev_status. Signed-off-by: Chia-I Wu Cc: Rob Clark --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 19 ++-- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 15 + drivers/gpu/drm/msm/msm_gpu.h | 9 +++- drivers

[Freedreno] [PATCH 1/3] drm/msm: remove explicit devfreq status reset

2022-04-15 Thread Chia-I Wu
It is redundant since commit 7c0ffcd40b16 ("drm/msm/gpu: Respect PM QoS constraints") because dev_pm_qos_update_request triggers get_dev_status. Signed-off-by: Chia-I Wu Cc: Rob Clark --- drivers/gpu/drm/msm/msm_gpu_devfreq.c | 7 --- 1 file changed, 7 deletions(-) diff --git

[Freedreno] [PATCH v2] drm/msm: add trace_dma_fence_emit to msm_gpu_submit

2022-04-12 Thread Chia-I Wu
correct trace_dma_fence_emit when visualizing fence timelines. v2: improve commit message (Dmitry) Signed-off-by: Chia-I Wu Cc: Rob Clark Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_gpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers

Re: [Freedreno] [PATCH] drm/msm: add trace_dma_fence_emit to msm_gpu_submit

2022-04-09 Thread Chia-I Wu
On Sat, Apr 9, 2022 at 7:33 AM Christian König wrote: > > Am 08.04.22 um 23:12 schrieb Chia-I Wu: > > In practice, trace_dma_fence_init is good enough and almost no driver > > calls trace_dma_fence_emit. But this is still more correct in theory. > > Well, the reason wh

[Freedreno] [PATCH] drm/msm: add trace_dma_fence_emit to msm_gpu_submit

2022-04-08 Thread Chia-I Wu
In practice, trace_dma_fence_init is good enough and almost no driver calls trace_dma_fence_emit. But this is still more correct in theory. Signed-off-by: Chia-I Wu Cc: Rob Clark --- drivers/gpu/drm/msm/msm_gpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm

Re: [Freedreno] [PATCH] drm/msm/gpu: fix bo size for msm_rbmemptrs

2018-12-20 Thread Chia-I Wu
Ah, thanks. I was on drm-next branch. I will switch to msm-next. On Thu, Dec 20, 2018 at 11:47 AM Jordan Crouse wrote: > On Thu, Dec 20, 2018 at 10:47:02AM -0800, Chia-I Wu wrote: > > memptrs_bo is used to store msm_rbmemptrs. Size it correctly. > > > > Signed-off-by:

[Freedreno] [PATCH] drm/msm/gpu: fix bo size for msm_rbmemptrs

2018-12-20 Thread Chia-I Wu
memptrs_bo is used to store msm_rbmemptrs. Size it correctly. Signed-off-by: Chia-I Wu --- drivers/gpu/drm/msm/msm_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index 11aac8337066..d23049eb29c4 100644

[Freedreno] [PATCH] drm/msm/a6xx: add a6xx_gpu_state_get

2018-12-20 Thread Chia-I Wu
It gets the generic states from the adreno core. This also adds a missing NULL check in msm_gpu_open. Signed-off-by: Chia-I Wu --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 44 +++ drivers/gpu/drm/msm/msm_debugfs.c | 2 +- 2 files changed, 45 insertions(+), 1

[Freedreno] [PATCH] drm/msm/gpu: fix bo size for msm_rbmemptrs

2018-12-19 Thread Chia-I Wu
memptrs_bo is used to store msm_rbmemptrs. Size it correctly. Signed-off-by: Chia-I Wu --- drivers/gpu/drm/msm/msm_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index 11aac8337066..d23049eb29c4 100644