Re: [PATCH] Revert "drm/msm/dpu: drop dpu_encoder_phys_ops.atomic_mode_set"

2024-05-14 Thread Caleb Connolly
gnment for CMD DSI panels. Fixes: d13f638c9b88 ("drm/msm/dpu: drop dpu_encoder_phys_ops.atomic_mode_set") Signed-off-by: Dmitry Baryshkov Hi Dmitry, This fixes the regular DRM irq errors for me! Tested-by: Caleb Connolly # sm8250 OnePlus 8 --- drivers/gpu/drm/msm/disp/dpu1/dpu_e

Re: [PATCH] drm/msm/dpu: fix vblank IRQ handling for command panels

2024-05-05 Thread Caleb Connolly
On 03/05/2024 22:59, Dmitry Baryshkov wrote: On Fri, May 03, 2024 at 11:18:52AM +0200, Luca Weiss wrote: On Sun Apr 7, 2024 at 5:15 AM CEST, Dmitry Baryshkov wrote: On Sat, 30 Mar 2024 at 18:49, Marijn Suijten wrote: On 2024-03-30 05:52:29, Dmitry Baryshkov wrote: In case of CMD DSI pane

Re: [Freedreno] [PATCH v5 2/2] arm64: dts: qcom: sdm845-db845c: Mark cont splash memory region as reserved

2023-07-14 Thread Caleb Connolly
On 13/07/2023 17:52, Amit Pundir wrote: > Adding a reserved memory region for the framebuffer memory > (the splash memory region set up by the bootloader). > > Signed-off-by: Amit Pundir Reviewed-by: Caleb Connolly > --- > v5: Re-sending with updated dt-bindings pa

Re: [Freedreno] [PATCH v2.5] drm/msm/dsi: switch to DRM_PANEL_BRIDGE

2022-11-11 Thread Caleb Connolly
Hi, This patch has caused a regression on 6.1-rc for some devices that use DSI panels. The new behaviour results in the DSI controller being switched off before the panel unprepare hook is called. As a result, panel drivers which call mipi_dsi_dcs_write() or similar in unprepare() fail. I'v

Re: [Freedreno] [PATCH v3 06/10] drm/msm/dsi: Migrate to drm_dsc_compute_rc_parameters()

2022-10-17 Thread Caleb Connolly
On 17/10/2022 09:59, Marijn Suijten wrote: > On 2022-10-13 09:02:44, Abhinav Kumar wrote: >> On 10/13/2022 2:36 AM, Marijn Suijten wrote: >>> On 2022-10-12 16:03:06, Abhinav Kumar wrote: [..] But I would like to hold back this change till Vinod clarifies because Vinod had mentione

Re: [Freedreno] [PATCH] arm64: dts: qcom: sm8250: move DSI opp table to the dsi0 node

2022-08-24 Thread Caleb Connolly
On 22/08/2022 20:11, Dmitry Baryshkov wrote: > It makes no sense to have the OPP table for the DSI controllers in the > DSI1 PHY node. Move it to more logical dsi0 device node. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Caleb Connolly > --- > arch/arm64/boot/dt

Re: [Freedreno] [PATCH] drm/msm/devfreq: Restrict idle clamping to a618 for now

2021-10-18 Thread Caleb Connolly
s proper idling on a630, but that can wait for 5.16. Tested-by: Caleb Connolly thanks -john -- Kind Regards, Caleb (they/them)

Re: [Freedreno] [PATCH 2/2] drm/msm/devfreq: Add 1ms delay before clamping freq

2021-10-16 Thread Caleb Connolly
On 28/09/2021 00:04, Rob Clark wrote: From: Rob Clark Add a short delay before clamping to idle frequency on active->idle transition. It takes ~0.5ms to increase the freq again on the next idle->active transition, so this helps avoid extra freq transitions on workloads that bounce between CP

Re: [Freedreno] [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent

2021-09-30 Thread Caleb Connolly
Hi, On 30/09/2021 20:49, Amit Pundir wrote: On Thu, 30 Sept 2021 at 04:50, Rob Clark wrote: On Wed, Sep 29, 2021 at 2:51 PM John Stultz wrote: On Wed, Sep 29, 2021 at 2:32 PM John Stultz wrote: On Wed, Sep 29, 2021 at 2:27 PM John Stultz wrote: On Fri, Sep 10, 2021 at 3:12 AM Maxime Ri

Re: [Freedreno] [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-10 Thread Caleb Connolly
On 10/09/2021 18:18, Rob Clark wrote: On Tue, Sep 7, 2021 at 7:20 PM Bjorn Andersson wrote: On Mon 09 Aug 10:26 PDT 2021, Akhil P Oommen wrote: On 8/9/2021 9:48 PM, Caleb Connolly wrote: On 09/08/2021 17:12, Rob Clark wrote: On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen wrote

Re: [Freedreno] [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-08 Thread Caleb Connolly
On 08/09/2021 03:21, Bjorn Andersson wrote: On Mon 09 Aug 10:26 PDT 2021, Akhil P Oommen wrote: On 8/9/2021 9:48 PM, Caleb Connolly wrote: On 09/08/2021 17:12, Rob Clark wrote: On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen wrote: [..] I am a bit confused. We don't define a

Re: [Freedreno] [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-09 Thread Caleb Connolly
On 09/08/2021 18:58, Rob Clark wrote: On Mon, Aug 9, 2021 at 10:28 AM Akhil P Oommen wrote: On 8/9/2021 9:48 PM, Caleb Connolly wrote: On 09/08/2021 17:12, Rob Clark wrote: On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen wrote: On 8/8/2021 10:22 PM, Rob Clark wrote: On Sun, Aug 8

Re: [Freedreno] [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-09 Thread Caleb Connolly
On 09/08/2021 17:12, Rob Clark wrote: On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen wrote: On 8/8/2021 10:22 PM, Rob Clark wrote: On Sun, Aug 8, 2021 at 7:33 AM Caleb Connolly wrote: On 07/08/2021 21:04, Rob Clark wrote: On Sat, Aug 7, 2021 at 12:21 PM Caleb Connolly wrote: Hi

Re: [Freedreno] [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-08 Thread Caleb Connolly
On 07/08/2021 21:04, Rob Clark wrote: On Sat, Aug 7, 2021 at 12:21 PM Caleb Connolly wrote: Hi Rob, Akhil, On 29/07/2021 21:53, Rob Clark wrote: On Thu, Jul 29, 2021 at 1:28 PM Caleb Connolly wrote: On 29/07/2021 21:24, Rob Clark wrote: On Thu, Jul 29, 2021 at 1:06 PM Caleb

Re: [Freedreno] [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-07 Thread Caleb Connolly
Hi Rob, Akhil, On 29/07/2021 21:53, Rob Clark wrote: On Thu, Jul 29, 2021 at 1:28 PM Caleb Connolly wrote: On 29/07/2021 21:24, Rob Clark wrote: On Thu, Jul 29, 2021 at 1:06 PM Caleb Connolly wrote: Hi Rob, I've done some more testing! It looks like before that patch (&qu

Re: [Freedreno] [PATCH] drm/msm: Disable frequency clamping on a630

2021-07-29 Thread Caleb Connolly
On 29/07/2021 21:24, Rob Clark wrote: On Thu, Jul 29, 2021 at 1:06 PM Caleb Connolly wrote: Hi Rob, I've done some more testing! It looks like before that patch ("drm/msm: Devfreq tuning") the GPU would never get above the second frequency in the OPP table (342MHz) (a

Re: [Freedreno] [PATCH] drm/msm: Disable frequency clamping on a630

2021-07-29 Thread Caleb Connolly
t revert to previous devfreq behavior on a630 until the issue is understood. Reported-by: Caleb Connolly Fixes: 9bc95570175a ("drm/msm: Devfreq tuning") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 3 +++ drivers/gpu/drm/msm/msm_gpu.h | 2 ++ drivers

Re: [Freedreno] [early pull] drm/msm: drm-msm-next-2021-07-28 for v5.15

2021-07-28 Thread Caleb Connolly
r if the PocoPhone F1 has the same problem... BR, -R On Wed, Jul 28, 2021 at 5:35 PM Caleb Connolly wrote: Hi Rob, This series causes a fatal crash on my Oneplus 6, the device goes to Qualcomm crashdump mode shortly after reaching UI with the following errors: https://paste.ubuntu.com/p/Hvjmz

Re: [Freedreno] [early pull] drm/msm: drm-msm-next-2021-07-28 for v5.15

2021-07-28 Thread Caleb Connolly
Hi Rob, This series causes a fatal crash on my Oneplus 6, the device goes to Qualcomm crashdump mode shortly after reaching UI with the following errors: https://paste.ubuntu.com/p/HvjmzZYtgw/ I did a git bisect and the patch ("drm/msm: Devfreq tuning") seems to be the cause of the crash, re

[Freedreno] [PATCH] drm/msm: always parse interconnects

2021-04-17 Thread Caleb Connolly
The WARN_ON in dpu_runtime_resume() fires constantly on non-SC7180 platforms. As SDM845 now has interconnects hooked up we should always try and parse them. Fixes: 627dc55c273d ("drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume") Signed-off-by: Caleb Connolly --

Re: [Freedreno] [PATCH v16 00/20] iommu/arm-smmu + drm/msm: per-process GPU pgtables

2020-09-07 Thread Caleb Connolly
On 2020-09-01 17:46, Rob Clark wrote: > From: Rob Clark > > NOTE: I have re-ordered the series, and propose that we could merge this >series in the following order: > > 1) 01-11 - merge via drm / msm-next > 2) 12-15 - merge via iommu, no dependency on msm-next pull req >