Re: [PATCH 0/5] EDITME: Support for Adreno 623 GPU

2025-02-18 Thread Rob Herring (Arm)
On Thu, 13 Feb 2025 21:40:05 +0530, Akhil P Oommen wrote: > This series adds support for A623 GPU found in QCS8300 chipsets. This > GPU IP is very similar to A621 GPU, except for the UBWC configuration > and the GMU firmware. > > Both DT patches are for Bjorn and rest of the patches for Rob Clar

Re: [PATCH RFC 7/7] drm/display: dp-tunnel: use new DCPD access helpers

2025-02-18 Thread Lyude Paul
Reviewed-by: Lyude Paul On Fri, 2025-01-17 at 10:56 +0200, Dmitry Baryshkov wrote: > Switch drm_dp_tunnel.c to use new set of DPCD read / write helpers. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/display/drm_dp_tunnel.c | 20 ++-- > 1 file changed, 10 insertion

Re: [PATCH RFC 6/7] drm/display: dp-mst-topology: use new DCPD access helpers

2025-02-18 Thread Lyude Paul
Reviewed-by: Lyude Paul On Fri, 2025-01-17 at 10:56 +0200, Dmitry Baryshkov wrote: > Switch drm_dp_mst_topology.c to use new set of DPCD read / write helpers. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/display/drm_dp_mst_topology.c | 105 > +- > 1 file

Re: [PATCH RFC 5/7] drm/display: dp-cec: use new DCPD access helpers

2025-02-18 Thread Lyude Paul
Reviewed-by: Lyude Paul On Fri, 2025-01-17 at 10:56 +0200, Dmitry Baryshkov wrote: > Switch drm_dp_cec.c to use new set of DPCD read / write helpers. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/display/drm_dp_cec.c | 37 > ++-- > 1 file changed,

Re: [PATCH RFC 3/7] drm/display: dp: use new DCPD access helpers

2025-02-18 Thread Lyude Paul
Reviewed-by: Lyude Paul On Fri, 2025-01-17 at 10:56 +0200, Dmitry Baryshkov wrote: > Switch drm_dp_helper.c to use new set of DPCD read / write helpers. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/display/drm_dp_helper.c | 309 > > 1 file chang

Re: [PATCH RFC 1/7] drm/display: dp: change drm_dp_dpcd_read_link_status() return

2025-02-18 Thread Lyude Paul
I've been wanting to do this for ages and just never got the time, thank you for getting to this ♥ So this patch looks good to me, but msm isn't the only user of drm_dp_dpcd_read_link_status() - so we would need to convert other drivers using coccinelle or similar as well for this to not break dri

Re: [PATCH RFC 2/7] drm/display: dp: implement new access helpers

2025-02-18 Thread Lyude Paul
On Thu, 2025-01-23 at 13:04 +0200, Dmitry Baryshkov wrote: > On Thu, Jan 23, 2025 at 12:26:25PM +0200, Jani Nikula wrote: > > On Fri, 17 Jan 2025, Dmitry Baryshkov wrote: > > > Existing DPCD access functions return an error code or the number of > > > bytes being read / write in case of partial ac

Re: [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

2025-02-18 Thread Geert Uytterhoeven
Hi Thomas, On Tue, 18 Feb 2025 at 15:26, Thomas Zimmermann wrote: > Add drm_modes_size_dumb(), a helper to calculate the dumb-buffer > scanline pitch and allocation size. Implementations of struct > drm_driver.dumb_create can call the new helper for their size > computations. > > There is current

Re: [PATCH 1/5] drm/msm/a6xx: Fix gpucc register block for A621

2025-02-18 Thread Rob Clark
On Thu, Feb 13, 2025 at 8:10 AM Akhil P Oommen wrote: > > From: Jie Zhang > > Adreno 621 has a different memory map for GPUCC block. So update > a6xx_gpu_state code to dump the correct set of gpucc registers. > > Signed-off-by: Jie Zhang > Signed-off-by: Akhil P Oommen > --- > drivers/gpu/drm/

Re: [PATCH v2] drm/msm/dpu: Fall back to a single DSC encoder (1:1:1) on small SoCs

2025-02-18 Thread Danila Tikhonov
On 1/22/25 19:23, Marijn Suijten wrote: Some SoCs such as SC7280 (used in the Fairphone 5) have only a single DSC "hard slice" encoder. The current hardcoded use of 2:2:1 topology (2 LM and 2 DSC for a single interface) make it impossible to use Display Stream Compression panels with mainline, w

Re: [PATCH v3 06/25] drm/armada: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Russell King (Oracle)
On Tue, Feb 18, 2025 at 03:23:29PM +0100, Thomas Zimmermann wrote: > Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and > buffer size. No alignment required. > > Signed-off-by: Thomas Zimmermann > Cc: Russell King armada_pitch() does have some special alignment (it aligns the p

[PATCH v3 20/25] drm/tegra: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch according to hardware requirements. Signed-off-by: Thomas Zimmermann Cc: Thierry Reding Cc: Mikko Perttunen --- drivers/gpu/drm/tegra/gem.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletion

[PATCH v3 11/25] drm/loongson: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch according to hardware requirements. Signed-off-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng Cc: Sui Jingfeng --- drivers/gpu/drm/loongson/lsdc_gem.c | 29 - 1 file ch

[PATCH v3 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch according to hardware requirements. Signed-off-by: Thomas Zimmermann Cc: Laurent Pinchart Cc: Tomi Valkeinen --- drivers/gpu/drm/xlnx/zynqmp_kms.c | 7 +-- 1 file changed, 5 insertions(+), 2 de

[PATCH v3 13/25] drm/msm: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Alignment is specified in bytes, but the hardware requires the scanline pitch to be a multiple of 32 pixels. Therefore compute the byte size of 32 pixels in the given color mode and align the pitch accordingly. This re

[PATCH v3 17/25] drm/renesas/rcar-du: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch according to hardware requirements. Signed-off-by: Thomas Zimmermann Cc: Laurent Pinchart Cc: Kieran Bingham --- drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c | 7 +-- 1 file changed, 5 inserti

[PATCH v3 24/25] drm/xen: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 8. Signed-off-by: Thomas Zimmermann Cc: Oleksandr Andrushchenko --- drivers/gpu/drm/xen/xen_drm_front.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/dr

[PATCH v3 19/25] drm/rockchip: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 64. Signed-off-by: Thomas Zimmermann Acked-by: Heiko Stuebner Cc: Sandy Huang Cc: "Heiko Stübner" Cc: Andy Yan --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 12 ++--

[PATCH v3 23/25] drm/xe: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 8. Align the buffer size according to hardware requirements. Xe's internal calculation allowed for 64-bit wide buffer sizes, but the ioctl's internal checks always verified against 32-

[PATCH v3 22/25] drm/vmwgfx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. No alignment required. Signed-off-by: Thomas Zimmermann Reviewed-by: Zack Rusin Cc: Zack Rusin Cc: Broadcom internal kernel review list --- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 21 - 1 fi

[PATCH v3 21/25] drm/virtio: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 4. Signed-off-by: Thomas Zimmermann Cc: David Airlie Cc: Gerd Hoffmann Cc: Gurchetan Singh Cc: Chia-I Wu --- drivers/gpu/drm/virtio/virtgpu_gem.c | 11 +-- 1 file changed

[PATCH v3 12/25] drm/mediatek: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 8. Signed-off-by: Thomas Zimmermann Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc: Matthias Brugger Cc: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_gem.c | 13 --

[PATCH v3 10/25] drm/imx/ipuv3: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. The hardware requires the framebuffer width to be a multiple of 8. The scanline pitch has be large enough to support this. Therefore compute the byte size of 8 pixels in the given color mode and align the pitch accordi

[PATCH v3 18/25] drm/renesas/rz-du: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch according to hardware requirements. Signed-off-by: Thomas Zimmermann Cc: Biju Das --- drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff

[PATCH v3 09/25] drm/hibmc: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 128. The hibmc driver's new hibmc_dumb_create() is similar to the one in GEM VRAM helpers. The driver was the only caller of drm_gem_vram_fill_create_dumb(). Remove the now unused help

[PATCH v3 16/25] drm/qxl: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. No alignment required. Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_dumb.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/dr

[PATCH v3 14/25] drm/nouveau: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 256. Signed-off-by: Thomas Zimmermann Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_display.c | 7 --- 1 file changed, 4 insertions(

[PATCH v3 15/25] drm/omapdrm: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 8. Signed-off-by: Thomas Zimmermann Reviewed-by: Tomi Valkeinen Cc: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_gem.c | 15 +++ 1 file changed, 7 insertions(+), 8 d

[PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

2025-02-18 Thread Thomas Zimmermann
Add drm_modes_size_dumb(), a helper to calculate the dumb-buffer scanline pitch and allocation size. Implementations of struct drm_driver.dumb_create can call the new helper for their size computations. There is currently quite a bit of code duplication among DRM's memory managers. Each calculates

[PATCH v3 08/25] drm/gma500: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 64. Signed-off-by: Thomas Zimmermann Cc: Patrik Jakobsson --- drivers/gpu/drm/gma500/gem.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a

[PATCH v3 06/25] drm/armada: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. No alignment required. Signed-off-by: Thomas Zimmermann Cc: Russell King --- drivers/gpu/drm/armada/armada_gem.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/

[PATCH v3 05/25] drm/gem-vram: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Inline code from drm_gem_vram_fill_create_dumb() without the existing size computation. Align the pitch to a multiple of 8. Only hibmc and vboxvideo use gem-vram. Hibmc invokes the call to drm_gem_vram_fill_create_dum

[PATCH v3 07/25] drm/exynos: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. No alignment required. Signed-off-by: Thomas Zimmermann Cc: Inki Dae Cc: Seung-Woo Kim Cc: Kyungmin Park Cc: Krzysztof Kozlowski Cc: Alim Akhtar --- drivers/gpu/drm/exynos/exynos_drm_gem.c | 8 +--- 1 file

[PATCH v3 04/25] drm/gem-shmem: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 8. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_shmem_helper.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/d

[PATCH v3 03/25] drm/gem-dma: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-02-18 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 8. Push the current calculation into the only direct caller imx. Imx's hardware requires the framebuffer width to be aligned to 8. The driver's current approach is actually incorrect,

[PATCH v3 01/25] drm/dumb-buffers: Sanitize output on errors

2025-02-18 Thread Thomas Zimmermann
The ioctls MODE_CREATE_DUMB and MODE_MAP_DUMB return results into a memory buffer supplied by user space. On errors, it is possible that intermediate values are being returned. The exact semantics depends on the DRM driver's implementation of these ioctls. Although this is most-likely not a securit

[PATCH v3 00/25] drm/dumb-buffers: Fix and improve buffer-size calculation

2025-02-18 Thread Thomas Zimmermann
Dumb-buffer pitch and size is specified by width, height, bits-per-pixel plus various hardware-specific alignments. The calculation of these values is inconsistent and duplicated among drivers. The results for formats with bpp < 8 are incorrect. This series fixes this for most drivers. Default sca