Re: [PATCH v2 2/2] drm/msm/disp: Correct porch timing for SDM845

2025-02-12 Thread Abhinav Kumar
On 2/12/2025 4:04 PM, Dmitry Baryshkov wrote: On Wed, Feb 12, 2025 at 03:03:47PM -0800, James A. MacInnes wrote: Type-C DisplayPort inoperable due to incorrect porch settings. - Re-used wide_bus_en as flag to prevent porch shifting Unfortunately I don't know enough details to comment on thi

Re: [PATCH v2 1/2] drm/msm/dp: Disable wide bus support for SDM845

2025-02-12 Thread Abhinav Kumar
On 2/12/2025 3:41 PM, Marijn Suijten wrote: On 2025-02-12 15:03:46, James A. MacInnes wrote: SDM845 DPU hardware is rev 4.0.0 per hardware documents. Original patch to enable wide_bus operation did not take into account the SDM845 and it got carried over by accident. - Incorrect setting caus

Re: [PATCH v2 2/3] drm/msm/dsi: Set PHY usescase (and mode) before registering DSI host

2025-02-12 Thread Dmitry Baryshkov
On Wed, Feb 12, 2025 at 05:13:08PM -0800, Abhinav Kumar wrote: > Hi Marijn > > On 2/10/2025 2:17 PM, Abhinav Kumar wrote: > > > > > > On 2/10/2025 6:24 AM, Dmitry Baryshkov wrote: > > > On Mon, Feb 10, 2025 at 01:54:29PM +0100, Marijn Suijten wrote: > > > > On 2025-02-10 01:11:59, Dmitry Baryshk

Re: [PATCH v2] drm/msm/dpu: Fix uninitialized variable

2025-02-12 Thread Abhinav Kumar
On 2/11/2025 4:19 PM, Abhinav Kumar wrote: On 2/11/2025 4:13 PM, Dmitry Baryshkov wrote: On Tue, Feb 11, 2025 at 10:23:54AM +0100, Marijn Suijten wrote: On 2025-02-10 14:14:14, Abhinav Kumar wrote: On 2/9/2025 7:51 PM, Ethan Carter Edwards wrote: There is a possibility for an uninitial

Re: [PATCH] drm/msm/dpu: Disable dither in phys encoder cleanup

2025-02-12 Thread Abhinav Kumar
On 2/12/2025 12:23 PM, Abhinav Kumar wrote: On 2/11/2025 7:59 PM, Jessica Zhang wrote: Disable pingpong dither in dpu_encoder_helper_phys_cleanup(). This avoids the issue where an encoder unknowingly uses dither after reserving a pingpong block that was previously bound to an encoder that

Re: [PATCH v2 2/3] drm/msm/dsi: Set PHY usescase (and mode) before registering DSI host

2025-02-12 Thread Abhinav Kumar
Hi Marijn On 2/10/2025 2:17 PM, Abhinav Kumar wrote: On 2/10/2025 6:24 AM, Dmitry Baryshkov wrote: On Mon, Feb 10, 2025 at 01:54:29PM +0100, Marijn Suijten wrote: On 2025-02-10 01:11:59, Dmitry Baryshkov wrote: On Sun, Feb 09, 2025 at 10:42:53PM +0100, Marijn Suijten wrote: Ordering issues

Re: [PATCH RFC 4/7] drm/display: dp-aux-dev: use new DCPD access helpers

2025-02-12 Thread Dmitry Baryshkov
On Thu, Feb 13, 2025 at 01:56:12AM +0200, Ville Syrjälä wrote: > On Thu, Jan 23, 2025 at 01:05:47PM +0200, Dmitry Baryshkov wrote: > > On Thu, Jan 23, 2025 at 12:05:29PM +0200, Jani Nikula wrote: > > > On Fri, 17 Jan 2025, Dmitry Baryshkov wrote: > > > > Switch drm_dp_aux_dev.c to use new set of D

Re: [PATCH 4/4] arm64: dts: qcom: qcs8300: Add support for stream 1 clk for DP MST

2025-02-12 Thread Konrad Dybcio
On 12.02.2025 8:12 AM, Yongxing Mou wrote: > Add 2 streams MST support for qcs8300. Compatile with qcs8300 dp > controller driver and populate the stream clock for qcs8300 DP0 > controller in MST mode. > > Signed-off-by: Yongxing Mou > --- Please add all required resources for quad-MST operation

Re: [PATCH v2 2/2] drm/msm/disp: Correct porch timing for SDM845

2025-02-12 Thread Dmitry Baryshkov
On Wed, Feb 12, 2025 at 03:03:47PM -0800, James A. MacInnes wrote: > Type-C DisplayPort inoperable due to incorrect porch settings. > - Re-used wide_bus_en as flag to prevent porch shifting Unfortunately I don't know enough details to comment on this change. Maybe Abhinav can check it. I can only

Re: [PATCH v2 1/2] drm/msm/dp: Disable wide bus support for SDM845

2025-02-12 Thread Dmitry Baryshkov
On Thu, Feb 13, 2025 at 12:41:02AM +0100, Marijn Suijten wrote: > On 2025-02-12 15:03:46, James A. MacInnes wrote: > > SDM845 DPU hardware is rev 4.0.0 per hardware documents. > > Original patch to enable wide_bus operation did not take into account > > the SDM845 and it got carried over by acciden

Re: [PATCH RFC 4/7] drm/display: dp-aux-dev: use new DCPD access helpers

2025-02-12 Thread Ville Syrjälä
On Thu, Jan 23, 2025 at 01:05:47PM +0200, Dmitry Baryshkov wrote: > On Thu, Jan 23, 2025 at 12:05:29PM +0200, Jani Nikula wrote: > > On Fri, 17 Jan 2025, Dmitry Baryshkov wrote: > > > Switch drm_dp_aux_dev.c to use new set of DPCD read / write helpers. > > > > This might be one of the few places

Re: [PATCH v2 1/2] drm/msm/dp: Disable wide bus support for SDM845

2025-02-12 Thread Marijn Suijten
On 2025-02-12 15:03:46, James A. MacInnes wrote: > SDM845 DPU hardware is rev 4.0.0 per hardware documents. > Original patch to enable wide_bus operation did not take into account > the SDM845 and it got carried over by accident. > > - Incorrect setting caused inoperable DisplayPort. > - Corrected

Re: [PATCH] drm/msm/dpu: Disable dither in phys encoder cleanup

2025-02-12 Thread Abhinav Kumar
On 2/11/2025 7:59 PM, Jessica Zhang wrote: Disable pingpong dither in dpu_encoder_helper_phys_cleanup(). This avoids the issue where an encoder unknowingly uses dither after reserving a pingpong block that was previously bound to an encoder that had enabled dither. Reported-by: Dmitry Barysh

Re: [PATCH v4 3/4] dt-bindings: display/msm: Document MDSS on QCS8300

2025-02-12 Thread Krzysztof Kozlowski
On 12/02/2025 11:05, Dmitry Baryshkov wrote: > On Wed, Feb 12, 2025 at 09:38:07AM +0100, Krzysztof Kozlowski wrote: >> On 20/01/2025 04:49, Yongxing Mou wrote: >>> Document the MDSS hardware found on the Qualcomm QCS8300 platform. >>> QCS8300 use the same DPU hardware version as SA8775P, so we reus

Re: [PATCH 0/4] Add MST support for qcs8300 platform

2025-02-12 Thread Konrad Dybcio
On 12.02.2025 3:35 PM, Rob Herring wrote: > On Wed, Feb 12, 2025 at 03:12:23PM +0800, Yongxing Mou wrote: >> This series of patches introduces how to enable MST functionality on >> the qcs8300 platform. The qcs8300 platform uses dpu_8_4 hardware, which >> is the same as the sa8775p, but it only has

Re: [PATCH 0/4] Add MST support for qcs8300 platform

2025-02-12 Thread Rob Herring
On Wed, Feb 12, 2025 at 03:12:23PM +0800, Yongxing Mou wrote: > This series of patches introduces how to enable MST functionality on > the qcs8300 platform. The qcs8300 platform uses dpu_8_4 hardware, which > is the same as the sa8775p, but it only has one DPU. So it only has one > DP0 controller,

Re: [PATCH 1/4] dt-bindings: display/msm: Redocument the dp-controller for QCS8300

2025-02-12 Thread Konrad Dybcio
On 12.02.2025 12:28 PM, Krzysztof Kozlowski wrote: > On 12/02/2025 12:13, Yongxing Mou wrote: >> >> >> On 2025/2/12 16:35, Krzysztof Kozlowski wrote: >>> On 12/02/2025 08:12, Yongxing Mou wrote: We need to enable mst for qcs8300, dp0 controller will support 2 streams output. So not reuse

Re: [PATCH 4/4] arm64: dts: qcom: sm7325-nothing-spacewar: Enable panel and GPU

2025-02-12 Thread Luca Weiss
On dinsdag 11 februari 2025 14:31:14 Midden-Europese standaardtijd Konrad Dybcio wrote: > On 3.02.2025 7:14 PM, Danila Tikhonov wrote: > > From: Eugene Lepshy > > > > Enable the Adreno GPU and configure the Visionox RM692E5 panel. > > > > Signed-off-by: Eugene Lepshy > > Co-developed-by: Danil

Re: [PATCH v4] drm/sched: Use struct for drm_sched_init() params

2025-02-12 Thread Lizhi Hou
On 2/11/25 03:14, Philipp Stanner wrote: drm_sched_init() has a great many parameters and upcoming new functionality for the scheduler might add even more. Generally, the great number of parameters reduces readability and has already caused one missnaming, addressed in: commit 6f1cacf4eba7 ("d

Re: [PATCH 4/4] arm64: dts: qcom: sm7325-nothing-spacewar: Enable panel and GPU

2025-02-12 Thread Konrad Dybcio
On 12.02.2025 12:53 AM, Dmitry Baryshkov wrote: > On Tue, Feb 11, 2025 at 02:31:14PM +0100, Konrad Dybcio wrote: >> On 3.02.2025 7:14 PM, Danila Tikhonov wrote: >>> From: Eugene Lepshy >>> >>> Enable the Adreno GPU and configure the Visionox RM692E5 panel. >>> >>> Signed-off-by: Eugene Lepshy >>>

Re: [PATCH 1/4] dt-bindings: display/msm: Redocument the dp-controller for QCS8300

2025-02-12 Thread Dmitry Baryshkov
On Wed, 12 Feb 2025 at 12:54, Krzysztof Kozlowski wrote: > > On 12/02/2025 11:41, Dmitry Baryshkov wrote: > > On Wed, Feb 12, 2025 at 03:12:24PM +0800, Yongxing Mou wrote: > >> We need to enable mst for qcs8300, dp0 controller will support 2 streams > >> output. So not reuse sm8650 dp controller d

Re: [PATCH 1/4] dt-bindings: display/msm: Redocument the dp-controller for QCS8300

2025-02-12 Thread Krzysztof Kozlowski
On 12/02/2025 12:13, Yongxing Mou wrote: > > > On 2025/2/12 16:35, Krzysztof Kozlowski wrote: >> On 12/02/2025 08:12, Yongxing Mou wrote: >>> We need to enable mst for qcs8300, dp0 controller will support 2 streams >>> output. So not reuse sm8650 dp controller driver and will add a new driver >>>

Re: [PATCH 1/4] dt-bindings: display/msm: Redocument the dp-controller for QCS8300

2025-02-12 Thread Yongxing Mou
we reuse it. BTW, for dp phy hardware version, qcs8300 and sm8650 is different. For this patch series, https://lore.kernel.org/all/20250212-mst_qcs8300-v1-0-38a8aa083...@quicinc.com/ , it is made on top of https://lore.kernel.org/all/20241205-dp_mst-v1-0-f8618d42a...@quicinc.com/ which is a new

Re: [PATCH v4] drm/sched: Use struct for drm_sched_init() params

2025-02-12 Thread Philipp Stanner
On Tue, 2025-02-11 at 12:14 +0100, Philipp Stanner wrote: > drm_sched_init() has a great many parameters and upcoming new > functionality for the scheduler might add even more. Generally, the > great number of parameters reduces readability and has already caused > one missnaming, addressed in: >

Re: [PATCH] drm/msm/dpu: Disable dither in phys encoder cleanup

2025-02-12 Thread Dmitry Baryshkov
On Tue, Feb 11, 2025 at 07:59:19PM -0800, Jessica Zhang wrote: > Disable pingpong dither in dpu_encoder_helper_phys_cleanup(). > > This avoids the issue where an encoder unknowingly uses dither after > reserving a pingpong block that was previously bound to an encoder that > had enabled dither. >

Re: [PATCH v3 2/2] arm64: dts: qcom: sa8775p-ride: Enable Adreno 663 GPU

2025-02-12 Thread Dmitry Baryshkov
On Wed, Feb 12, 2025 at 12:48:01PM +0530, Akhil P Oommen wrote: > On 2/12/2025 5:30 AM, Dmitry Baryshkov wrote: > > On Tue, Feb 11, 2025 at 06:41:39PM +0530, Akhil P Oommen wrote: > >> On 2/9/2025 9:59 PM, Dmitry Baryshkov wrote: > >>> On Wed, Nov 13, 2024 at 02:18:43AM +0530, Akhil P Oommen wrote:

Re: [PATCH 1/4] dt-bindings: display/msm: Redocument the dp-controller for QCS8300

2025-02-12 Thread Krzysztof Kozlowski
On 12/02/2025 11:41, Dmitry Baryshkov wrote: > On Wed, Feb 12, 2025 at 03:12:24PM +0800, Yongxing Mou wrote: >> We need to enable mst for qcs8300, dp0 controller will support 2 streams >> output. So not reuse sm8650 dp controller driver and will add a new driver >> patch for qcs8300 mst feature. Mo

Re: [PATCH 0/4] Add MST support for qcs8300 platform

2025-02-12 Thread Dmitry Baryshkov
On Wed, Feb 12, 2025 at 03:12:23PM +0800, Yongxing Mou wrote: > This series of patches introduces how to enable MST functionality on > the qcs8300 platform. > The qcs8300 platform uses dpu_8_4 hardware, which > is the same as the sa8775p, but it only has one DPU. So it only has one > DP0 controlle

Re: [PATCH 1/4] dt-bindings: display/msm: Redocument the dp-controller for QCS8300

2025-02-12 Thread Dmitry Baryshkov
On Wed, Feb 12, 2025 at 03:12:24PM +0800, Yongxing Mou wrote: > We need to enable mst for qcs8300, dp0 controller will support 2 streams > output. So not reuse sm8650 dp controller driver and will add a new driver > patch for qcs8300 mst feature. Modify the corresponding dt-bingding file > to compa

Re: [PATCH 1/4] dt-bindings: display/msm: Redocument the dp-controller for QCS8300

2025-02-12 Thread Dmitry Baryshkov
On Wed, Feb 12, 2025 at 03:12:24PM +0800, Yongxing Mou wrote: > We need to enable mst for qcs8300, dp0 controller will support 2 streams > output. So not reuse sm8650 dp controller driver and will add a new driver > patch for qcs8300 mst feature. Modify the corresponding dt-bingding file > to compa

Re: [PATCH v4 3/4] dt-bindings: display/msm: Document MDSS on QCS8300

2025-02-12 Thread Dmitry Baryshkov
On Wed, Feb 12, 2025 at 09:38:07AM +0100, Krzysztof Kozlowski wrote: > On 20/01/2025 04:49, Yongxing Mou wrote: > > Document the MDSS hardware found on the Qualcomm QCS8300 platform. > > QCS8300 use the same DPU hardware version as SA8775P, so we reuse it's > > driver. But QCS8300 only have one DP

Re: [PATCH 3/4] drm/msm/dsi: Allow all bpc values

2025-02-12 Thread Marijn Suijten
On 2025-02-11 21:06:19, Danila Tikhonov wrote: > On 2/9/25 01:09, Marijn Suijten wrote: > > On 2025-02-03 21:14:26, Danila Tikhonov wrote: > >> From: Eugene Lepshy > >> > >> DRM DSC helper has parameters for various bpc values ​​other than 8: > > Weird zero-width \u200b spaces here between "values

Re: [PATCH 0/4] Add MST support for qcs8300 platform

2025-02-12 Thread Krzysztof Kozlowski
On 12/02/2025 08:12, Yongxing Mou wrote: > This series of patches introduces how to enable MST functionality on > the qcs8300 platform. The qcs8300 platform uses dpu_8_4 hardware, which > is the same as the sa8775p, but it only has one DPU. So it only has one > DP0 controller, supporting 4-stream M

Re: [PATCH v4 3/4] dt-bindings: display/msm: Document MDSS on QCS8300

2025-02-12 Thread Krzysztof Kozlowski
On 20/01/2025 04:49, Yongxing Mou wrote: > Document the MDSS hardware found on the Qualcomm QCS8300 platform. > QCS8300 use the same DPU hardware version as SA8775P, so we reuse it's > driver. But QCS8300 only have one DP controller, and offset is same with > sm8650, so dp controller reuse the sm86

Re: [PATCH v4 2/4] dt-bindings: display/msm: Document the dp-controller for QCS8300

2025-02-12 Thread Krzysztof Kozlowski
On 20/01/2025 04:49, Yongxing Mou wrote: > Add compatible string for the DisplayPort controller found on the > Qualcomm QCS8300 platform.QCS8300 only support one DisplayPort > controller and have the same base offset with sm8650, so we reuse > the sm8650 DisplayPort driver. > > Reviewed-by: Krzysz

Re: [PATCH 1/4] dt-bindings: display/msm: Redocument the dp-controller for QCS8300

2025-02-12 Thread Krzysztof Kozlowski
On 12/02/2025 08:12, Yongxing Mou wrote: > We need to enable mst for qcs8300, dp0 controller will support 2 streams > output. So not reuse sm8650 dp controller driver and will add a new driver > patch for qcs8300 mst feature. Modify the corresponding dt-bingding file > to compatible with the qcs830

Re: [PATCH v3 1/4] dt-bindings: display/msm: Document the DPU for QCS8300

2025-02-12 Thread Krzysztof Kozlowski
On 13/01/2025 09:03, Yongxing Mou wrote: > Document the DPU for Qualcomm QCS8300 platform. It use the same DPU > hardware with SA8775P and reuse it's driver. > > Reviewed-by: Krzysztof Kozlowski This also might not be correct, based on emails sent recently. No clue what to do with this patchset.

Re: [PATCH 2/4] dt-bindings: display/msm: Add stream 1 pixel clock for QCS8300

2025-02-12 Thread Krzysztof Kozlowski
On 12/02/2025 08:12, Yongxing Mou wrote: > Support mst for qcs8300 and add the stream 1 clock support in the mdss > dt-bindings. > > Signed-off-by: Yongxing Mou Your patchset leads to warnings - it is non-bisectable. Fix original code, don't post buggy patches just to fix them immediately. >

Re: [PATCH v3 2/4] dt-bindings: display: msm: dp-controller: document QCS8300 compatible

2025-02-12 Thread Krzysztof Kozlowski
On 13/01/2025 09:03, Yongxing Mou wrote: > Add compatible string for the DisplayPort controller found on the > Qualcomm QCS8300 platform.QCS8300 only support one DisplayPort > controller and have the same base offset with sm8650, so we reuse > the sm8650 DisplayPort driver. Un-reviewed. Other patc