Re: [PATCH v7 3/7] drm/msm/hdmi: make use of the drm_connector_hdmi framework

2025-02-07 Thread Abhinav Kumar
On 2/7/2025 4:27 PM, Dmitry Baryshkov wrote: Setup the HDMI connector on the MSM HDMI outputs. Make use of atomic_check hook and of the provided Infoframe infrastructure. Acked-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Kconfig| 2 + drivers/g

Re: [PATCH v7 2/7] drm/msm/hdmi: program HDMI timings during atomic_pre_enable

2025-02-07 Thread Dmitry Baryshkov
On Fri, Feb 07, 2025 at 04:42:46PM -0800, Abhinav Kumar wrote: > > > On 2/7/2025 4:27 PM, Dmitry Baryshkov wrote: > > The mode_set callback is deprecated, it doesn't get the > > drm_bridge_state, just mode-related argumetns. Also Abhinav pointed out > > that HDMI timings should be programmed afte

Re: [PATCH v7 6/7] drm/msm/hdmi: also send the SPD and HDMI Vendor Specific InfoFrames

2025-02-07 Thread Dmitry Baryshkov
On Fri, Feb 07, 2025 at 07:05:14PM -0800, Abhinav Kumar wrote: > > > On 2/7/2025 6:04 PM, Dmitry Baryshkov wrote: > > On Fri, Feb 07, 2025 at 05:31:20PM -0800, Abhinav Kumar wrote: > > > > > > > > > On 2/7/2025 4:27 PM, Dmitry Baryshkov wrote: > > > > Extend the driver to send SPD and HDMI Vend

Re: [PATCH v7 6/7] drm/msm/hdmi: also send the SPD and HDMI Vendor Specific InfoFrames

2025-02-07 Thread Abhinav Kumar
On 2/7/2025 6:04 PM, Dmitry Baryshkov wrote: On Fri, Feb 07, 2025 at 05:31:20PM -0800, Abhinav Kumar wrote: On 2/7/2025 4:27 PM, Dmitry Baryshkov wrote: Extend the driver to send SPD and HDMI Vendor Specific InfoFrames. While the HDMI block has special block to send HVS InfoFrame, use GEN

Re: [PATCH v7 6/7] drm/msm/hdmi: also send the SPD and HDMI Vendor Specific InfoFrames

2025-02-07 Thread Dmitry Baryshkov
On Fri, Feb 07, 2025 at 05:31:20PM -0800, Abhinav Kumar wrote: > > > On 2/7/2025 4:27 PM, Dmitry Baryshkov wrote: > > Extend the driver to send SPD and HDMI Vendor Specific InfoFrames. > > > > While the HDMI block has special block to send HVS InfoFrame, use > > GENERIC0 block instead. VENSPEC_I

Re: [PATCH v7 6/7] drm/msm/hdmi: also send the SPD and HDMI Vendor Specific InfoFrames

2025-02-07 Thread Abhinav Kumar
On 2/7/2025 4:27 PM, Dmitry Baryshkov wrote: Extend the driver to send SPD and HDMI Vendor Specific InfoFrames. While the HDMI block has special block to send HVS InfoFrame, use GENERIC0 block instead. VENSPEC_INFO registers pack frame data in a way that requires manual repacking in the drive

[PATCH v7 0/7] drm/msm: make use of the HDMI connector infrastructure

2025-02-07 Thread Dmitry Baryshkov
This patchset sits on top Maxime's HDMI connector patchset ([1]). Currently this is an RFC exploring the interface between HDMI bridges and HDMI connector code. This has been lightly verified on the Qualcomm DB820c, which has native HDMI output. If this approach is considered to be acceptable, I'l

Re: [PATCH v7 2/7] drm/msm/hdmi: program HDMI timings during atomic_pre_enable

2025-02-07 Thread Abhinav Kumar
On 2/7/2025 4:27 PM, Dmitry Baryshkov wrote: The mode_set callback is deprecated, it doesn't get the drm_bridge_state, just mode-related argumetns. Also Abhinav pointed out that HDMI timings should be programmed after setting up HDMI PHY and PLL. Rework the code to program HDMI timings at the

[PATCH v7 6/7] drm/msm/hdmi: also send the SPD and HDMI Vendor Specific InfoFrames

2025-02-07 Thread Dmitry Baryshkov
Extend the driver to send SPD and HDMI Vendor Specific InfoFrames. While the HDMI block has special block to send HVS InfoFrame, use GENERIC0 block instead. VENSPEC_INFO registers pack frame data in a way that requires manual repacking in the driver, while GENERIC0 doesn't have such format require

[PATCH v7 7/7] drm/msm/hdmi: use DRM HDMI Audio framework

2025-02-07 Thread Dmitry Baryshkov
In order to simplify the driver even further and to remove the boilerplate code, rewrite the audio interface to use the DRM HDMI Audio framework. Audio InfoFames are controlled centrally via the DRM HDMI framework. Correct InfoFrame data is programmed at the atomic_pre_enable() time (if it was set

[PATCH v7 1/7] drm/msm/hdmi: switch to atomic bridge callbacks

2025-02-07 Thread Dmitry Baryshkov
Change MSM HDMI bridge to use atomic_* callbacks in preparation to enablign the HDMI connector support. Acked-by: Maxime Ripard Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 13 + 1 file changed, 9 insertions(+), 4 deletions

[PATCH v7 4/7] drm/msm/hdmi: get rid of hdmi_mode

2025-02-07 Thread Dmitry Baryshkov
Use connector->display_info.is_hdmi instead of manually using drm_detect_hdmi_monitor(). Acked-by: Maxime Ripard Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c| 2 +- drivers/gpu/drm/msm/hdmi/hdmi.h| 2 -- drivers/gpu/drm/msm/hd

[PATCH v7 3/7] drm/msm/hdmi: make use of the drm_connector_hdmi framework

2025-02-07 Thread Dmitry Baryshkov
Setup the HDMI connector on the MSM HDMI outputs. Make use of atomic_check hook and of the provided Infoframe infrastructure. Acked-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Kconfig| 2 + drivers/gpu/drm/msm/hdmi/hdmi.c| 45 ++--- drive

[PATCH v7 2/7] drm/msm/hdmi: program HDMI timings during atomic_pre_enable

2025-02-07 Thread Dmitry Baryshkov
The mode_set callback is deprecated, it doesn't get the drm_bridge_state, just mode-related argumetns. Also Abhinav pointed out that HDMI timings should be programmed after setting up HDMI PHY and PLL. Rework the code to program HDMI timings at the end of atomic_pre_enable(). Reviewed-by: Maxime R

[PATCH v7 5/7] drm/msm/hdmi: update HDMI_GEN_PKT_CTRL_GENERIC0_UPDATE definition

2025-02-07 Thread Dmitry Baryshkov
The GENERIC0_UPDATE field is a single bit. Redefine it as boolean to simplify its usage in the driver. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/registers/display/hdmi.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/dr

Re: [PATCH v6 3/7] drm/msm/hdmi: make use of the drm_connector_hdmi framework

2025-02-07 Thread Dmitry Baryshkov
On Fri, Feb 07, 2025 at 02:27:41PM -0800, Abhinav Kumar wrote: > > > On 2/7/2025 2:03 PM, Dmitry Baryshkov wrote: > > On Fri, Feb 07, 2025 at 01:34:35PM -0800, Abhinav Kumar wrote: > > > > > > > > > On 2/3/2025 5:30 PM, Dmitry Baryshkov wrote: > > > > On Mon, Feb 03, 2025 at 04:25:59PM -0800, A

Re: [PATCH v6 3/7] drm/msm/hdmi: make use of the drm_connector_hdmi framework

2025-02-07 Thread Abhinav Kumar
On 2/7/2025 2:03 PM, Dmitry Baryshkov wrote: On Fri, Feb 07, 2025 at 01:34:35PM -0800, Abhinav Kumar wrote: On 2/3/2025 5:30 PM, Dmitry Baryshkov wrote: On Mon, Feb 03, 2025 at 04:25:59PM -0800, Abhinav Kumar wrote: On 1/24/2025 1:47 PM, Dmitry Baryshkov wrote: Setup the HDMI connector

Re: [PATCH v6 2/7] drm/msm/hdmi: program HDMI timings during atomic_pre_enable

2025-02-07 Thread Dmitry Baryshkov
On Fri, Feb 07, 2025 at 12:11:55PM -0800, Abhinav Kumar wrote: > > > On 2/6/2025 5:19 PM, Dmitry Baryshkov wrote: > > On Thu, Feb 06, 2025 at 12:41:30PM -0800, Abhinav Kumar wrote: > > > > > > > > > On 2/3/2025 4:59 PM, Dmitry Baryshkov wrote: > > > > On Mon, Feb 03, 2025 at 11:34:00AM -0800, A

Re: [PATCH v6 3/7] drm/msm/hdmi: make use of the drm_connector_hdmi framework

2025-02-07 Thread Dmitry Baryshkov
On Fri, Feb 07, 2025 at 01:34:35PM -0800, Abhinav Kumar wrote: > > > On 2/3/2025 5:30 PM, Dmitry Baryshkov wrote: > > On Mon, Feb 03, 2025 at 04:25:59PM -0800, Abhinav Kumar wrote: > > > > > > > > > On 1/24/2025 1:47 PM, Dmitry Baryshkov wrote: > > > > Setup the HDMI connector on the MSM HDMI o

Re: [PATCH v6 3/7] drm/msm/hdmi: make use of the drm_connector_hdmi framework

2025-02-07 Thread Abhinav Kumar
On 2/3/2025 5:30 PM, Dmitry Baryshkov wrote: On Mon, Feb 03, 2025 at 04:25:59PM -0800, Abhinav Kumar wrote: On 1/24/2025 1:47 PM, Dmitry Baryshkov wrote: Setup the HDMI connector on the MSM HDMI outputs. Make use of atomic_check hook and of the provided Infoframe infrastructure. By atom

Re: [PATCH v6 2/7] drm/msm/hdmi: program HDMI timings during atomic_pre_enable

2025-02-07 Thread Abhinav Kumar
On 2/6/2025 5:19 PM, Dmitry Baryshkov wrote: On Thu, Feb 06, 2025 at 12:41:30PM -0800, Abhinav Kumar wrote: On 2/3/2025 4:59 PM, Dmitry Baryshkov wrote: On Mon, Feb 03, 2025 at 11:34:00AM -0800, Abhinav Kumar wrote: On 1/24/2025 1:47 PM, Dmitry Baryshkov wrote: The mode_set callback is

Re: [PATCH v2 1/2] dt-bindings: display: qcom,sm8550-mdss: only document the mdp0-mem interconnect path

2025-02-07 Thread Dmitry Baryshkov
On Fri, 7 Feb 2025 at 16:02, Neil Armstrong wrote: > > The mdp1-mem is not supported on the SM8550 SoCs, so only support a single > mdp0-mem interconnect entry. v2 went too fast. Please add cpu-cfg instead. > > Signed-off-by: Neil Armstrong > --- > .../devicetree/bindings/display/msm/qcom,sm85

Re: [PATCH 2/2] dt-bindings: display: qcom, sm8650-mdss: only document the mdp0-mem interconnect path

2025-02-07 Thread Dmitry Baryshkov
On Fri, 7 Feb 2025 at 12:50, Neil Armstrong wrote: > > The mdp1-mem is not supported on the SM8650 SoCs, so only support a single > mdp0-mem interconnect entry. No, please add cpu-cfg interconnect instead. > > Signed-off-by: Neil Armstrong > --- > Documentation/devicetree/bindings/display/msm/

[PATCH v2 2/2] dt-bindings: display: qcom,sm8650-mdss: only document the mdp0-mem interconnect path

2025-02-07 Thread Neil Armstrong
The mdp1-mem is not supported on the SM8650 SoCs, so only support a single mdp0-mem interconnect entry. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/dev

[PATCH v2 1/2] dt-bindings: display: qcom,sm8550-mdss: only document the mdp0-mem interconnect path

2025-02-07 Thread Neil Armstrong
The mdp1-mem is not supported on the SM8550 SoCs, so only support a single mdp0-mem interconnect entry. Signed-off-by: Neil Armstrong --- .../devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml| 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/Documentation/d

[PATCH v2 0/2] dt-bindings: display: qcom,sm8[56]50-mdss: only document the mdp0-mem interconnect path

2025-02-07 Thread Neil Armstrong
to v1: https://lore.kernel.org/r/20250207-topic-sm8x50-mdss-interconnect-bindings-fix-v1-0-852b1d6ae...@linaro.org --- Neil Armstrong (2): dt-bindings: display: qcom,sm8550-mdss: only document the mdp0-mem interconnect path dt-bindings: display: qcom,sm8650-mdss: only documen

Re: [PATCH 1/2] dt-bindings: display: qcom, sm8550-mdss: only document the mdp0-mem interconnect path

2025-02-07 Thread Neil Armstrong
ake refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250207-topic-sm8x50-mdss-interconnect-bindings-fix-v1-1-852b1d6ae...@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'ma

Re: [PATCH 1/2] dt-bindings: display: qcom,sm8550-mdss: only document the mdp0-mem interconnect path

2025-02-07 Thread Rob Herring (Arm)
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250207-topic-sm8x50-mdss-interconnect-bindings-fix-v1-1-852b1d6ae...@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_bindi

Re: [PATCH v3] drm/sched: Use struct for drm_sched_init() params

2025-02-07 Thread Tvrtko Ursulin
On 07/02/2025 11:02, Philipp Stanner wrote: drm_sched_init() has a great many parameters and upcoming new functionality for the scheduler might add even more. Generally, the great number of parameters reduces readability and has already caused one missnaming in: commit 6f1cacf4eba7 ("drm/nouve

[PATCH v3] drm/sched: Use struct for drm_sched_init() params

2025-02-07 Thread Philipp Stanner
drm_sched_init() has a great many parameters and upcoming new functionality for the scheduler might add even more. Generally, the great number of parameters reduces readability and has already caused one missnaming in: commit 6f1cacf4eba7 ("drm/nouveau: Improve variable name in nouveau_sched_init(

[PATCH 0/2] dt-bindings: display: qcom,sm8[56]50-mdss: only document the mdp0-mem interconnect path

2025-02-07 Thread Neil Armstrong
les changed, 4 insertions(+), 4 deletions(-) --- base-commit: 808eb958781e4ebb6e9c0962af2e856767e20f45 change-id: 20250207-topic-sm8x50-mdss-interconnect-bindings-fix-dd975f223d05 Best regards, -- Neil Armstrong

[PATCH 1/2] dt-bindings: display: qcom,sm8550-mdss: only document the mdp0-mem interconnect path

2025-02-07 Thread Neil Armstrong
The mdp1-mem is not supported on the SM8550 SoCs, so only support a single mdp0-mem interconnect entry. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/dev

[PATCH 2/2] dt-bindings: display: qcom,sm8650-mdss: only document the mdp0-mem interconnect path

2025-02-07 Thread Neil Armstrong
The mdp1-mem is not supported on the SM8650 SoCs, so only support a single mdp0-mem interconnect entry. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/dev