Re: [PATCH v2 2/4] drm/msm/dsi/phy: Protect PHY_CMN_CLK_CFG1 against clock driver

2025-02-04 Thread Dmitry Baryshkov
On Tue, Feb 04, 2025 at 04:46:04PM +0100, Krzysztof Kozlowski wrote: > On 04/02/2025 15:26, Dmitry Baryshkov wrote: > > On Tue, Feb 04, 2025 at 10:21:25AM +0100, Krzysztof Kozlowski wrote: > >> On 03/02/2025 18:41, Dmitry Baryshkov wrote: > >>> On Mon, Feb 03, 2025 at 06:29:19PM +0100, Krzysztof Ko

Re: [PATCH v5 07/14] drm/msm/dpu: Reserve resources for CWB

2025-02-04 Thread Dmitry Baryshkov
On Tue, Feb 04, 2025 at 01:29:23PM -0800, Jessica Zhang wrote: > > > On 1/29/2025 2:11 PM, Dmitry Baryshkov wrote: > > On Tue, Jan 28, 2025 at 07:20:39PM -0800, Jessica Zhang wrote: > > > Add support for RM to reserve dedicated CWB PINGPONGs and CWB muxes > > > > > > For concurrent writeback, ev

Re: [PATCH v5 07/14] drm/msm/dpu: Reserve resources for CWB

2025-02-04 Thread Jessica Zhang
On 1/29/2025 2:11 PM, Dmitry Baryshkov wrote: On Tue, Jan 28, 2025 at 07:20:39PM -0800, Jessica Zhang wrote: Add support for RM to reserve dedicated CWB PINGPONGs and CWB muxes For concurrent writeback, even-indexed CWB muxes must be assigned to even-indexed LMs and odd-indexed CWB muxes for

Re: [PATCH v2 4/4] drm/msm/dsi/phy: Define PHY_CMN_CLK_CFG[01] bitfields and simplify saving

2025-02-04 Thread Krzysztof Kozlowski
On 04/02/2025 15:28, Dmitry Baryshkov wrote: drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 31 -- .../gpu/drm/msm/registers/display/dsi_phy_7nm.xml | 12 +++-- 2 files changed, 27 insertions(+), 16 deletions(-) diff --git a/drivers/gpu

Re: [PATCH v2 3/4] drm/msm/dsi/phy: Do not overwite PHY_CMN_CLK_CFG1 when choosing bitclk source

2025-02-04 Thread Krzysztof Kozlowski
On 04/02/2025 15:27, Dmitry Baryshkov wrote: struct dsi_pll_7nm *pll_7nm = to_pll_7nm(phy->vco_hw); - void __iomem *base = phy->base; u32 data = 0x0; /* internal PLL */ DBG("DSI PLL%d", pll_7nm->phy->id); @@ -635,7 +634,7 @@ static int dsi_7nm_set_usecase(s

Re: [PATCH v2 4/4] drm/msm/dsi/phy: Define PHY_CMN_CLK_CFG[01] bitfields and simplify saving

2025-02-04 Thread Dmitry Baryshkov
On Tue, Feb 04, 2025 at 04:48:43PM +0100, Krzysztof Kozlowski wrote: > On 04/02/2025 15:28, Dmitry Baryshkov wrote: > drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 31 > -- > .../gpu/drm/msm/registers/display/dsi_phy_7nm.xml | 12 +++-- > 2 file

Re: [PATCH v2 2/4] drm/msm/dsi/phy: Protect PHY_CMN_CLK_CFG1 against clock driver

2025-02-04 Thread Krzysztof Kozlowski
On 04/02/2025 15:26, Dmitry Baryshkov wrote: > On Tue, Feb 04, 2025 at 10:21:25AM +0100, Krzysztof Kozlowski wrote: >> On 03/02/2025 18:41, Dmitry Baryshkov wrote: >>> On Mon, Feb 03, 2025 at 06:29:19PM +0100, Krzysztof Kozlowski wrote: PHY_CMN_CLK_CFG1 register is updated by the PHY driver an

Re: [PATCH v2 1/4] drm/msm/dsi/phy: Protect PHY_CMN_CLK_CFG0 updated from driver side

2025-02-04 Thread Dmitry Baryshkov
On Tue, Feb 04, 2025 at 10:20:51AM +0100, Krzysztof Kozlowski wrote: > On 03/02/2025 18:42, Dmitry Baryshkov wrote: > > On Mon, Feb 03, 2025 at 06:29:18PM +0100, Krzysztof Kozlowski wrote: > >> PHY_CMN_CLK_CFG0 register is updated by the PHY driver and by two > >> divider clocks from Common Clock F

Re: [PATCH v2 4/4] drm/msm/dsi/phy: Define PHY_CMN_CLK_CFG[01] bitfields and simplify saving

2025-02-04 Thread Dmitry Baryshkov
On Tue, Feb 04, 2025 at 10:24:28AM +0100, Krzysztof Kozlowski wrote: > On 03/02/2025 18:58, Dmitry Baryshkov wrote: > > On Mon, Feb 03, 2025 at 06:29:21PM +0100, Krzysztof Kozlowski wrote: > >> Add bitfields for PHY_CMN_CLK_CFG0 and PHY_CMN_CLK_CFG1 registers to > >> avoid hard-coding bit masks and

Re: [PATCH v2 3/4] drm/msm/dsi/phy: Do not overwite PHY_CMN_CLK_CFG1 when choosing bitclk source

2025-02-04 Thread Dmitry Baryshkov
On Tue, Feb 04, 2025 at 10:22:19AM +0100, Krzysztof Kozlowski wrote: > On 03/02/2025 18:40, Dmitry Baryshkov wrote: > > On Mon, Feb 03, 2025 at 06:29:20PM +0100, Krzysztof Kozlowski wrote: > >> PHY_CMN_CLK_CFG1 register has four fields being used in the driver: DSI > >> clock divider, source of bit

Re: [PATCH v2 2/4] drm/msm/dsi/phy: Protect PHY_CMN_CLK_CFG1 against clock driver

2025-02-04 Thread Dmitry Baryshkov
On Tue, Feb 04, 2025 at 10:21:25AM +0100, Krzysztof Kozlowski wrote: > On 03/02/2025 18:41, Dmitry Baryshkov wrote: > > On Mon, Feb 03, 2025 at 06:29:19PM +0100, Krzysztof Kozlowski wrote: > >> PHY_CMN_CLK_CFG1 register is updated by the PHY driver and by a mux > >> clock from Common Clock Framewor

Re: [PATCH v2 4/4] drm/msm/dsi/phy: Define PHY_CMN_CLK_CFG[01] bitfields and simplify saving

2025-02-04 Thread Krzysztof Kozlowski
On 03/02/2025 18:58, Dmitry Baryshkov wrote: > On Mon, Feb 03, 2025 at 06:29:21PM +0100, Krzysztof Kozlowski wrote: >> Add bitfields for PHY_CMN_CLK_CFG0 and PHY_CMN_CLK_CFG1 registers to >> avoid hard-coding bit masks and shifts and make the code a bit more >> readable. While touching the lines i

Re: [PATCH v2 3/4] drm/msm/dsi/phy: Do not overwite PHY_CMN_CLK_CFG1 when choosing bitclk source

2025-02-04 Thread Krzysztof Kozlowski
On 03/02/2025 18:40, Dmitry Baryshkov wrote: > On Mon, Feb 03, 2025 at 06:29:20PM +0100, Krzysztof Kozlowski wrote: >> PHY_CMN_CLK_CFG1 register has four fields being used in the driver: DSI >> clock divider, source of bitclk and two for enabling the DSI PHY PLL >> clocks. >> >> dsi_7nm_set_usecase

Re: [PATCH v2 2/4] drm/msm/dsi/phy: Protect PHY_CMN_CLK_CFG1 against clock driver

2025-02-04 Thread Krzysztof Kozlowski
On 03/02/2025 18:41, Dmitry Baryshkov wrote: > On Mon, Feb 03, 2025 at 06:29:19PM +0100, Krzysztof Kozlowski wrote: >> PHY_CMN_CLK_CFG1 register is updated by the PHY driver and by a mux >> clock from Common Clock Framework: >> devm_clk_hw_register_mux_parent_hws(). There could be a path leading t

Re: [PATCH v2 1/4] drm/msm/dsi/phy: Protect PHY_CMN_CLK_CFG0 updated from driver side

2025-02-04 Thread Krzysztof Kozlowski
On 03/02/2025 18:42, Dmitry Baryshkov wrote: > On Mon, Feb 03, 2025 at 06:29:18PM +0100, Krzysztof Kozlowski wrote: >> PHY_CMN_CLK_CFG0 register is updated by the PHY driver and by two >> divider clocks from Common Clock Framework: >> devm_clk_hw_register_divider_parent_hw(). Concurrent access by