Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-19 Thread Thomas Zimmermann
Hi Am 16.01.25 um 11:03 schrieb Tomi Valkeinen: [...] Harmonizing code is fine, but I think that can be done with a function that only does the fallback-case. So... I can only speak for the platforms I'm using and maintaining, but I'd rather keep the old behavior for CREATE_DUMB that we've

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-19 Thread Thomas Zimmermann
Hi Am 16.01.25 um 11:03 schrieb Tomi Valkeinen: [...] Aligning video= and dumb buffers almost sounds like going backwards. video= parameter is bad, Who told you that? Video= is still the way to specify an initial display mode to the kernel and it will remain so. Of course, it is better to

Re: [PATCH v4 3/4] dt-bindings: display/msm: Document MDSS on QCS8300

2025-01-19 Thread Krzysztof Kozlowski
On Mon, Jan 20, 2025 at 11:49:20AM +0800, Yongxing Mou wrote: > Document the MDSS hardware found on the Qualcomm QCS8300 platform. > QCS8300 use the same DPU hardware version as SA8775P, so we reuse it's > driver. But QCS8300 only have one DP controller, and offset is same with > sm8650, so dp cont

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-19 Thread Sui Jingfeng
Hi, On 2025/1/20 04:14, Laurent Pinchart wrote: On Mon, Jan 20, 2025 at 12:26:30AM +0800, Sui Jingfeng wrote: On 2025/1/19 23:22, Tomi Valkeinen wrote: On 19/01/2025 16:59, Sui Jingfeng wrote: But userspace must be able to continue allocating YUV buffers through CREATE_DUMB. I think, alloca

[PATCH v4 3/4] dt-bindings: display/msm: Document MDSS on QCS8300

2025-01-19 Thread Yongxing Mou
Document the MDSS hardware found on the Qualcomm QCS8300 platform. QCS8300 use the same DPU hardware version as SA8775P, so we reuse it's driver. But QCS8300 only have one DP controller, and offset is same with sm8650, so dp controller reuse the sm8650's driver. Signed-off-by: Yongxing Mou --- .

[PATCH v4 4/4] drm/msm: mdss: Add QCS8300 support

2025-01-19 Thread Yongxing Mou
Add Mobile Display Subsystem (MDSS) support for the QCS8300 platform. Due to different memory type, it use different mdss_data with SA8775P although using the same dpu. Reviewed-by: Dmitry Baryshkov Signed-off-by: Yongxing Mou --- drivers/gpu/drm/msm/msm_mdss.c | 11 +++ 1 file changed,

[PATCH v4 2/4] dt-bindings: display/msm: Document the dp-controller for QCS8300

2025-01-19 Thread Yongxing Mou
Add compatible string for the DisplayPort controller found on the Qualcomm QCS8300 platform.QCS8300 only support one DisplayPort controller and have the same base offset with sm8650, so we reuse the sm8650 DisplayPort driver. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Yongxing Mou --- Docu

[PATCH v4 1/4] dt-bindings: display/msm: Document the DPU for QCS8300

2025-01-19 Thread Yongxing Mou
Document the DPU for Qualcomm QCS8300 platform. It use the same DPU hardware with SA8775P and reuse it's driver. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Yongxing Mou --- .../devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml| 13 + 1 file changed, 9 insertions(+), 4 de

[PATCH v4 0/4] Display enablement changes for Qualcomm QCS8300 platform

2025-01-19 Thread Yongxing Mou
This series introduces support to enable the Mobile Display Subsystem (MDSS) , Display Processing Unit (DPU), DisplayPort controller for the Qualcomm QCS8300 target. It includes the addition of the hardware catalog, compatible string, and their YAML bindings. Signed-off-by: Yongxing Mou --- Chan

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-19 Thread Sui Jingfeng
Hi, On 2025/1/16 18:17, Geert Uytterhoeven wrote: On Thu, Jan 16, 2025 at 11:03 AM Tomi Valkeinen wrote: On 16/01/2025 10:09, Thomas Zimmermann wrote: Am 15.01.25 um 15:20 schrieb Tomi Valkeinen: [...] My point is that we have the current UAPI, and we have userspace using it, but we don't ha

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-19 Thread Laurent Pinchart
On Mon, Jan 20, 2025 at 12:26:30AM +0800, Sui Jingfeng wrote: > On 2025/1/19 23:22, Tomi Valkeinen wrote: > > On 19/01/2025 16:59, Sui Jingfeng wrote: > > > > But userspace must be able to continue allocating YUV buffers through > > CREATE_DUMB. > > I think, allocating YUV buffers

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-19 Thread Laurent Pinchart
On Thu, Jan 16, 2025 at 12:07:49PM +0200, Tomi Valkeinen wrote: > On 16/01/2025 11:38, Laurent Pinchart wrote: > > On Thu, Jan 16, 2025 at 10:43:40AM +0200, Laurent Pinchart wrote: > >> On Wed, Jan 15, 2025 at 02:34:26PM +, Daniel Stone wrote: > >>> On Wed, 15 Jan 2025 at 14:20, Tomi Valkeinen

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-19 Thread Sui Jingfeng
Hi, On 2025/1/19 23:22, Tomi Valkeinen wrote: On 19/01/2025 16:59, Sui Jingfeng wrote: But userspace must be able to continue allocating YUV buffers through CREATE_DUMB. I think, allocating YUV buffers through CREATE_DUMB interface is just an *abuse* and *misuse* of this API for now. Take t

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-19 Thread Tomi Valkeinen
On 19/01/2025 16:59, Sui Jingfeng wrote: But userspace must be able to continue allocating YUV buffers through CREATE_DUMB. I think, allocating YUV buffers through CREATE_DUMB interface is just an *abuse* and *misuse* of this API for now. Take the NV12 format as an example, NV12 is YUV420 pla

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-19 Thread Sui Jingfeng
Hi, On 2025/1/19 20:18, Tomi Valkeinen wrote: Hi, On 19/01/2025 13:29, Sui Jingfeng wrote: Hi, On 2025/1/16 18:35, Dmitry Baryshkov wrote: On Thu, Jan 16, 2025 at 11:17:50AM +0100, Geert Uytterhoeven wrote: On Thu, Jan 16, 2025 at 11:03 AM Tomi Valkeinen wrote: On 16/01/2025 10:09, Thomas

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-19 Thread Tomi Valkeinen
Hi, On 19/01/2025 13:29, Sui Jingfeng wrote: Hi, On 2025/1/16 18:35, Dmitry Baryshkov wrote: On Thu, Jan 16, 2025 at 11:17:50AM +0100, Geert Uytterhoeven wrote: On Thu, Jan 16, 2025 at 11:03 AM Tomi Valkeinen wrote: On 16/01/2025 10:09, Thomas Zimmermann wrote: Am 15.01.25 um 15:20 schrieb

Re: [PATCH v2 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-01-19 Thread Sui Jingfeng
Hi, On 2025/1/16 18:35, Dmitry Baryshkov wrote: On Thu, Jan 16, 2025 at 11:17:50AM +0100, Geert Uytterhoeven wrote: On Thu, Jan 16, 2025 at 11:03 AM Tomi Valkeinen wrote: On 16/01/2025 10:09, Thomas Zimmermann wrote: Am 15.01.25 um 15:20 schrieb Tomi Valkeinen: [...] My point is that we hav